[GitHub] jiazhai commented on a change in pull request #2400: PIP-22: Dead Letter Topic

2018-08-21 Thread GitBox
jiazhai commented on a change in pull request #2400: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400#discussion_r211836331 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleProducerConsumerTest.java ## @@ -2662

[GitHub] jiazhai commented on a change in pull request #2400: PIP-22: Dead Letter Topic

2018-08-21 Thread GitBox
jiazhai commented on a change in pull request #2400: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400#discussion_r211835573 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleProducerConsumerTest.java ## @@ -2662

[GitHub] jiazhai commented on a change in pull request #2400: PIP-22: Dead Letter Topic

2018-08-21 Thread GitBox
jiazhai commented on a change in pull request #2400: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400#discussion_r211835151 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/utils/Quorum.java ## @@ -0,0 +1,59 @@ +/** + * Licensed

[GitHub] merlimat commented on issue #2423: [client] add properties to consumer for cpp & python client

2018-08-21 Thread GitBox
merlimat commented on issue #2423: [client] add properties to consumer for cpp & python client URL: https://github.com/apache/incubator-pulsar/pull/2423#issuecomment-414917527 @sijie This seems a dup of #2420, which one should get merged? ---

[GitHub] merlimat commented on issue #2423: [client] add properties to consumer for cpp & python client

2018-08-21 Thread GitBox
merlimat commented on issue #2423: [client] add properties to consumer for cpp & python client URL: https://github.com/apache/incubator-pulsar/pull/2423#issuecomment-414917313 run integration tests This is an automated messag

[GitHub] codelipenghui commented on a change in pull request #2400: PIP-22: Dead Letter Topic

2018-08-21 Thread GitBox
codelipenghui commented on a change in pull request #2400: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400#discussion_r211831981 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleCon

[GitHub] codelipenghui commented on a change in pull request #2400: PIP-22: Dead Letter Topic

2018-08-21 Thread GitBox
codelipenghui commented on a change in pull request #2400: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400#discussion_r211831981 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleCon

[GitHub] srkukarni closed pull request #2422: Improve the documentation about publish function

2018-08-21 Thread GitBox
srkukarni closed pull request #2422: Improve the documentation about publish function URL: https://github.com/apache/incubator-pulsar/pull/2422 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As t

[incubator-pulsar] branch master updated: Improve the documentation about publish function (#2422)

2018-08-21 Thread sanjeevrk
This is an automated email from the ASF dual-hosted git repository. sanjeevrk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 6ddc2ad Improve the documentation

[GitHub] codelipenghui commented on a change in pull request #2400: PIP-22: Dead Letter Topic

2018-08-21 Thread GitBox
codelipenghui commented on a change in pull request #2400: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400#discussion_r211807555 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleCon

[GitHub] rdhabalia commented on issue #2416: Fix: authorization while redirecting function admin call

2018-08-21 Thread GitBox
rdhabalia commented on issue #2416: Fix: authorization while redirecting function admin call URL: https://github.com/apache/incubator-pulsar/pull/2416#issuecomment-414884730 rerun java8 tests This is an automated message from

[GitHub] codelipenghui commented on a change in pull request #2400: PIP-22: Dead Letter Topic

2018-08-21 Thread GitBox
codelipenghui commented on a change in pull request #2400: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400#discussion_r211807555 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleCon

[GitHub] srkukarni commented on issue #2422: Improve the documentation about publish function

2018-08-21 Thread GitBox
srkukarni commented on issue #2422: Improve the documentation about publish function URL: https://github.com/apache/incubator-pulsar/pull/2422#issuecomment-414859049 run integration tests This is an automated message from the

[GitHub] srkukarni commented on issue #2422: Improve the documentation about publish function

2018-08-21 Thread GitBox
srkukarni commented on issue #2422: Improve the documentation about publish function URL: https://github.com/apache/incubator-pulsar/pull/2422#issuecomment-414859021 run java8 tests This is an automated message from the Apach

[GitHub] srkukarni commented on issue #2422: Improve the documentation about publish function

2018-08-21 Thread GitBox
srkukarni commented on issue #2422: Improve the documentation about publish function URL: https://github.com/apache/incubator-pulsar/pull/2422#issuecomment-414858935 run cpp tests This is an automated message from the Apache

[GitHub] sijie commented on a change in pull request #2423: [client] add properties to consumer for cpp & python client

2018-08-21 Thread GitBox
sijie commented on a change in pull request #2423: [client] add properties to consumer for cpp & python client URL: https://github.com/apache/incubator-pulsar/pull/2423#discussion_r211793997 ## File path: pulsar-client-cpp/docker-build.sh ## @@ -41,4 +41,4 @@ DOCKER_CMD="d

[GitHub] rdhabalia commented on a change in pull request #2421: Fix bug during user publish

2018-08-21 Thread GitBox
rdhabalia commented on a change in pull request #2421: Fix bug during user publish URL: https://github.com/apache/incubator-pulsar/pull/2421#discussion_r211787361 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/ContextImpl.java ##

[GitHub] merlimat commented on a change in pull request #2423: [client] add properties to consumer for cpp & python client

2018-08-21 Thread GitBox
merlimat commented on a change in pull request #2423: [client] add properties to consumer for cpp & python client URL: https://github.com/apache/incubator-pulsar/pull/2423#discussion_r211785148 ## File path: pulsar-client-cpp/docker-build.sh ## @@ -41,4 +41,4 @@ DOCKER_CMD

[incubator-pulsar] branch master updated: remove 'to delete' (#2418)

2018-08-21 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 3bd1ad9 remove 'to delete' (#2418) 3bd

[GitHub] sijie closed pull request #2418: Fix Description of Options on Pulsar Admin

2018-08-21 Thread GitBox
sijie closed pull request #2418: Fix Description of Options on Pulsar Admin URL: https://github.com/apache/incubator-pulsar/pull/2418 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a fo

[GitHub] sijie commented on a change in pull request #2420: [client] add properties to producer for cpp & python client

2018-08-21 Thread GitBox
sijie commented on a change in pull request #2420: [client] add properties to producer for cpp & python client URL: https://github.com/apache/incubator-pulsar/pull/2420#discussion_r211781198 ## File path: pulsar-client-cpp/python/pulsar/__init__.py ## @@ -321,7 +321,8 @@ d

[GitHub] sijie opened a new pull request #2423: [client] add properties to consumer for cpp & python client

2018-08-21 Thread GitBox
sijie opened a new pull request #2423: [client] add properties to consumer for cpp & python client URL: https://github.com/apache/incubator-pulsar/pull/2423 ### Motivation This is a caught-up change to enable properties for consumer as java clients. ### Changes Enable

[GitHub] srkukarni commented on a change in pull request #2411: [functions] change instance id from string to int and expose number of instances in context

2018-08-21 Thread GitBox
srkukarni commented on a change in pull request #2411: [functions] change instance id from string to int and expose number of instances in context URL: https://github.com/apache/incubator-pulsar/pull/2411#discussion_r211776412 ## File path: pulsar-functions/api-java/src/main/java/o

[GitHub] srkukarni opened a new pull request #2422: Improve the documentation about publish function

2018-08-21 Thread GitBox
srkukarni opened a new pull request #2422: Improve the documentation about publish function URL: https://github.com/apache/incubator-pulsar/pull/2422 ### Motivation Cleaned up the comments around publish ### Modifications Describe the modifications you've done. ### R

[GitHub] sijie commented on issue #2346: Issue #2330: change getTopicName in MultiTopicsConsumer

2018-08-21 Thread GitBox
sijie commented on issue #2346: Issue #2330: change getTopicName in MultiTopicsConsumer URL: https://github.com/apache/incubator-pulsar/pull/2346#issuecomment-414835396 @jiazhai can you rebase this PR to master? @merlimat can you review it again? we need this for 2.1.1 release

[GitHub] sijie commented on a change in pull request #2420: [client] add properties to producer for cpp & python client

2018-08-21 Thread GitBox
sijie commented on a change in pull request #2420: [client] add properties to producer for cpp & python client URL: https://github.com/apache/incubator-pulsar/pull/2420#discussion_r211773131 ## File path: pulsar-client-cpp/python/pulsar/__init__.py ## @@ -321,7 +321,8 @@ d

[GitHub] sijie commented on issue #2411: [functions] change instance id from string to int and expose number of instances in context

2018-08-21 Thread GitBox
sijie commented on issue #2411: [functions] change instance id from string to int and expose number of instances in context URL: https://github.com/apache/incubator-pulsar/pull/2411#issuecomment-414834875 > What about python changes? okay will take a look at python

[GitHub] sijie commented on a change in pull request #2411: [functions] change instance id from string to int and expose number of instances in context

2018-08-21 Thread GitBox
sijie commented on a change in pull request #2411: [functions] change instance id from string to int and expose number of instances in context URL: https://github.com/apache/incubator-pulsar/pull/2411#discussion_r211772934 ## File path: pulsar-functions/api-java/src/main/java/org/a

[GitHub] srkukarni opened a new pull request #2421: Fix bug during user publish

2018-08-21 Thread GitBox
srkukarni opened a new pull request #2421: Fix bug during user publish URL: https://github.com/apache/incubator-pulsar/pull/2421 ### Motivation This pr fixes two bugs in the path of user publish 1. Stackoverflow error in ContextImpl where getSchema was calling itself 2. Add topi

[GitHub] merlimat commented on a change in pull request #2420: [client] add properties to producer for cpp & python client

2018-08-21 Thread GitBox
merlimat commented on a change in pull request #2420: [client] add properties to producer for cpp & python client URL: https://github.com/apache/incubator-pulsar/pull/2420#discussion_r211769327 ## File path: pulsar-client-cpp/python/pulsar/__init__.py ## @@ -321,7 +321,8 @

[GitHub] sijie opened a new pull request #2420: [client] add properties to producer for cpp & python client

2018-08-21 Thread GitBox
sijie opened a new pull request #2420: [client] add properties to producer for cpp & python client URL: https://github.com/apache/incubator-pulsar/pull/2420 ### Motivation This is a caught-up change to enable properties for producer as java clients. ### Changes Enable

[GitHub] sijie commented on issue #2418: Fix Description of Options on Pulsar Admin

2018-08-21 Thread GitBox
sijie commented on issue #2418: Fix Description of Options on Pulsar Admin URL: https://github.com/apache/incubator-pulsar/pull/2418#issuecomment-414827155 run cpp tests This is an automated message from the Apache Git Service

[GitHub] srkukarni commented on a change in pull request #2411: [functions] change instance id from string to int and expose number of instances in context

2018-08-21 Thread GitBox
srkukarni commented on a change in pull request #2411: [functions] change instance id from string to int and expose number of instances in context URL: https://github.com/apache/incubator-pulsar/pull/2411#discussion_r211750888 ## File path: pulsar-functions/api-java/src/main/java/o

[GitHub] sijie closed issue #2282: Document the settings to enable authorization

2018-08-21 Thread GitBox
sijie closed issue #2282: Document the settings to enable authorization URL: https://github.com/apache/incubator-pulsar/issues/2282 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] sijie commented on issue #2282: Document the settings to enable authorization

2018-08-21 Thread GitBox
sijie commented on issue #2282: Document the settings to enable authorization URL: https://github.com/apache/incubator-pulsar/issues/2282#issuecomment-414793036 yeah the documentation is great! This is an automated message fr

[GitHub] sijie commented on issue #2379: Initializing cluster metadata should handle /managed-ledger path better

2018-08-21 Thread GitBox
sijie commented on issue #2379: Initializing cluster metadata should handle /managed-ledger path better URL: https://github.com/apache/incubator-pulsar/issues/2379#issuecomment-414792602 @ivankelly I think we should two changes here: 1) disable initializing /managed-ledgers in manag

[GitHub] sijie commented on a change in pull request #2400: PIP-22: Dead Letter Topic

2018-08-21 Thread GitBox
sijie commented on a change in pull request #2400: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400#discussion_r211723819 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.ja

[GitHub] sijie commented on a change in pull request #2400: PIP-22: Dead Letter Topic

2018-08-21 Thread GitBox
sijie commented on a change in pull request #2400: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400#discussion_r211724307 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.ja

[GitHub] sijie opened a new pull request #2419: [documentation] cherry-pick deploy-kubernetes documentation changes

2018-08-21 Thread GitBox
sijie opened a new pull request #2419: [documentation] cherry-pick deploy-kubernetes documentation changes URL: https://github.com/apache/incubator-pulsar/pull/2419 Cherry-pick changes from #2363 to 2.1.0 documentation ---

[incubator-pulsar.wiki] branch master updated: Updated PIP 23: Message Tracing By Interceptors (markdown)

2018-08-21 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.wiki.git The following commit(s) were added to refs/heads/master by this push: new ed4b0e9 Updated PIP 23: Message T

[GitHub] merlimat commented on issue #2418: Fix Description of Options on Pulsar Admin

2018-08-21 Thread GitBox
merlimat commented on issue #2418: Fix Description of Options on Pulsar Admin URL: https://github.com/apache/incubator-pulsar/pull/2418#issuecomment-414754274 run cpp tests This is an automated message from the Apache Git Serv

[GitHub] jerrypeng commented on issue #2414: allow predicates concerning publish time to push down to pulsar

2018-08-21 Thread GitBox
jerrypeng commented on issue #2414: allow predicates concerning publish time to push down to pulsar URL: https://github.com/apache/incubator-pulsar/pull/2414#issuecomment-414744387 rerun java8 tests This is an automated mess

[GitHub] massakam commented on issue #2401: Consumer often discards received messages

2018-08-21 Thread GitBox
massakam commented on issue #2401: Consumer often discards received messages URL: https://github.com/apache/incubator-pulsar/issues/2401#issuecomment-414642945 This phenomenon seems to happen when the consumer is receiving a lot of messages. For example, it is prone to happen when the cons

[incubator-pulsar.wiki] branch master updated: Created PIP 23: Message Tracing By Interceptors (markdown)

2018-08-21 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.wiki.git The following commit(s) were added to refs/heads/master by this push: new e0388dd Created PIP 23: Message T

[incubator-pulsar.wiki] branch master updated: Updated Home (markdown)

2018-08-21 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.wiki.git The following commit(s) were added to refs/heads/master by this push: new 7d081a9 Updated Home (markdown) 7

[GitHub] k2la opened a new pull request #2418: Fix Description of Options on Pulsar Admin

2018-08-21 Thread GitBox
k2la opened a new pull request #2418: Fix Description of Options on Pulsar Admin URL: https://github.com/apache/incubator-pulsar/pull/2418 ### Motivation https://pulsar.incubator.apache.org/docs/en/pulsar-admin/#get-1 https://pulsar.incubator.apache.org/docs/en/pulsar-admin/#getsta

[GitHub] srkukarni commented on a change in pull request #2397: Integrate Functions with Schema

2018-08-21 Thread GitBox
srkukarni commented on a change in pull request #2397: Integrate Functions with Schema URL: https://github.com/apache/incubator-pulsar/pull/2397#discussion_r211515618 ## File path: pulsar-functions/api-java/src/main/java/org/apache/pulsar/functions/api/Context.java ## @@

[GitHub] srkukarni commented on a change in pull request #2397: Integrate Functions with Schema

2018-08-21 Thread GitBox
srkukarni commented on a change in pull request #2397: Integrate Functions with Schema URL: https://github.com/apache/incubator-pulsar/pull/2397#discussion_r211515762 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java ## @@ -469,20 +