[GitHub] codelipenghui commented on a change in pull request #2508: PIP-22: Dead Letter Topic

2018-09-13 Thread GitBox
codelipenghui commented on a change in pull request #2508: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2508#discussion_r217272237 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java

[GitHub] codelipenghui commented on a change in pull request #2508: PIP-22: Dead Letter Topic

2018-09-13 Thread GitBox
codelipenghui commented on a change in pull request #2508: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2508#discussion_r217270244 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java ## @@ -265,7

[GitHub] codelipenghui commented on a change in pull request #2508: PIP-22: Dead Letter Topic

2018-09-11 Thread GitBox
codelipenghui commented on a change in pull request #2508: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2508#discussion_r216567558 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java ## @@ -265,7

[GitHub] codelipenghui commented on a change in pull request #2508: PIP-22: Dead Letter Topic

2018-09-10 Thread GitBox
codelipenghui commented on a change in pull request #2508: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2508#discussion_r216551734 ## File path:

[GitHub] codelipenghui commented on a change in pull request #2508: PIP-22: Dead Letter Topic

2018-09-10 Thread GitBox
codelipenghui commented on a change in pull request #2508: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2508#discussion_r216539085 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java ## @@ -338,4

[GitHub] codelipenghui commented on a change in pull request #2508: PIP-22: Dead Letter Topic

2018-09-10 Thread GitBox
codelipenghui commented on a change in pull request #2508: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2508#discussion_r216538878 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java ## @@ -1184,6

[GitHub] codelipenghui commented on a change in pull request #2508: PIP-22: Dead Letter Topic

2018-09-10 Thread GitBox
codelipenghui commented on a change in pull request #2508: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2508#discussion_r216538381 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/DeadLetterPolicy.java ##

[GitHub] codelipenghui commented on a change in pull request #2508: PIP-22: Dead Letter Topic

2018-09-10 Thread GitBox
codelipenghui commented on a change in pull request #2508: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2508#discussion_r216538312 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/DeadLetterPolicy.java ##

[GitHub] codelipenghui commented on a change in pull request #2508: PIP-22: Dead Letter Topic

2018-09-10 Thread GitBox
codelipenghui commented on a change in pull request #2508: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2508#discussion_r216538263 ## File path: