[GitHub] jai1 commented on issue #1297: Add Configuration to set tlsClientAuth

2018-03-27 Thread GitBox
jai1 commented on issue #1297: Add Configuration to set tlsClientAuth URL: https://github.com/apache/incubator-pulsar/pull/1297#issuecomment-376703491 @merlimat - can you please review this when you get time. This is an

[GitHub] jai1 commented on issue #1297: Add Configuration to set tlsClientAuth

2018-03-27 Thread GitBox
jai1 commented on issue #1297: Add Configuration to set tlsClientAuth URL: https://github.com/apache/incubator-pulsar/pull/1297#issuecomment-376410187 retest this please This is an automated message from the Apache Git

[GitHub] jai1 commented on issue #1297: Add Configuration to set tlsClientAuth

2018-03-26 Thread GitBox
jai1 commented on issue #1297: Add Configuration to set tlsClientAuth URL: https://github.com/apache/incubator-pulsar/pull/1297#issuecomment-376057341 retest this please This is an automated message from the Apache

[GitHub] jai1 commented on issue #1297: Add Configuration to set tlsClientAuth

2018-03-22 Thread GitBox
jai1 commented on issue #1297: Add Configuration to set tlsClientAuth URL: https://github.com/apache/incubator-pulsar/pull/1297#issuecomment-375540220 retest this please This is an automated message from the Apache Git

[GitHub] jai1 commented on issue #1297: Add Configuration to set tlsClientAuth

2018-03-22 Thread GitBox
jai1 commented on issue #1297: Add Configuration to set tlsClientAuth URL: https://github.com/apache/incubator-pulsar/pull/1297#issuecomment-375388466 retest this please This is an automated message from the Apache Git

[GitHub] jai1 commented on issue #1297: Add Configuration to set tlsClientAuth

2018-03-21 Thread GitBox
jai1 commented on issue #1297: Add Configuration to set tlsClientAuth URL: https://github.com/apache/incubator-pulsar/pull/1297#issuecomment-375131394 @maskit @merlimat - have addressed all your concerns and added additional test cases. Kindly review it again and give me a +1

[GitHub] jai1 commented on issue #1297: Add Configuration to set tlsClientAuth

2018-02-28 Thread GitBox
jai1 commented on issue #1297: Add Configuration to set tlsClientAuth URL: https://github.com/apache/incubator-pulsar/pull/1297#issuecomment-369370856 retest this please This is an automated message from the Apache Git

[GitHub] jai1 commented on issue #1297: Add Configuration to set tlsClientAuth

2018-02-28 Thread GitBox
jai1 commented on issue #1297: Add Configuration to set tlsClientAuth URL: https://github.com/apache/incubator-pulsar/pull/1297#issuecomment-369370600 @maskit @merlimat - Once the client is connected the authentication happens on handleConnect, if I am a mischief maker (not using

[GitHub] jai1 commented on issue #1297: Add Configuration to set tlsClientAuth

2018-02-27 Thread GitBox
jai1 commented on issue #1297: Add Configuration to set tlsClientAuth URL: https://github.com/apache/incubator-pulsar/pull/1297#issuecomment-369092518 > How is it different for HTTP connections? TLS connections, in general, can be made without client certificates and authentication.

[GitHub] jai1 commented on issue #1297: Add Configuration to set tlsClientAuth

2018-02-27 Thread GitBox
jai1 commented on issue #1297: Add Configuration to set tlsClientAuth URL: https://github.com/apache/incubator-pulsar/pull/1297#issuecomment-369092518 > How is it different for HTTP connections? TLS connections, in general, can be made without client certificates and authentication.

[GitHub] jai1 commented on issue #1297: Add Configuration to set tlsClientAuth

2018-02-27 Thread GitBox
jai1 commented on issue #1297: Add Configuration to set tlsClientAuth URL: https://github.com/apache/incubator-pulsar/pull/1297#issuecomment-368988700 retest this please This is an automated message from the Apache Git