[GitHub] jerrypeng commented on issue #1758: Windowing for Pulsar Functions

2018-05-11 Thread GitBox
jerrypeng commented on issue #1758: Windowing for Pulsar Functions URL: https://github.com/apache/incubator-pulsar/pull/1758#issuecomment-388469042 @srkukarni thanks for the review. I have addressed your comments This is an

[GitHub] jerrypeng commented on issue #1758: Windowing for Pulsar Functions

2018-05-11 Thread GitBox
jerrypeng commented on issue #1758: Windowing for Pulsar Functions URL: https://github.com/apache/incubator-pulsar/pull/1758#issuecomment-388434193 @srkukarni i think that is a good approach. Let me refactor the code This is

[GitHub] jerrypeng commented on issue #1758: Windowing for Pulsar Functions

2018-05-11 Thread GitBox
jerrypeng commented on issue #1758: Windowing for Pulsar Functions URL: https://github.com/apache/incubator-pulsar/pull/1758#issuecomment-388275692 @srkukarni well I thought you didn't like that approach since WindowFunction would be an abstract class that users would extend. It would

[GitHub] jerrypeng commented on issue #1758: Windowing for Pulsar Functions

2018-05-11 Thread GitBox
jerrypeng commented on issue #1758: Windowing for Pulsar Functions URL: https://github.com/apache/incubator-pulsar/pull/1758#issuecomment-388275692 @srkukarni well I thought you didn't like that approach since WindowFunction would be an abstract method that users would extend. It would