[GitHub] jerrypeng commented on issue #1766: Implementing PushSource on top of Source

2018-05-11 Thread GitBox
jerrypeng commented on issue #1766: Implementing PushSource on top of Source URL: https://github.com/apache/incubator-pulsar/pull/1766#issuecomment-388435528 I discussed with @srkukarni and we are going to leave the KakfaSource as it is for now

[GitHub] jerrypeng commented on issue #1766: Implementing PushSource on top of Source

2018-05-11 Thread GitBox
jerrypeng commented on issue #1766: Implementing PushSource on top of Source URL: https://github.com/apache/incubator-pulsar/pull/1766#issuecomment-388279505 @srkukarni but isn't that just the same as using the PushSource but instead you a pulling the queuing logic back into the

[GitHub] jerrypeng commented on issue #1766: Implementing PushSource on top of Source

2018-05-11 Thread GitBox
jerrypeng commented on issue #1766: Implementing PushSource on top of Source URL: https://github.com/apache/incubator-pulsar/pull/1766#issuecomment-388277056 @srkukarni using a push source might be more efficient since not we are doing async reads in a sense. Remember the actual source

[GitHub] jerrypeng commented on issue #1766: Implementing PushSource on top of Source

2018-05-11 Thread GitBox
jerrypeng commented on issue #1766: Implementing PushSource on top of Source URL: https://github.com/apache/incubator-pulsar/pull/1766#issuecomment-388277056 @srkukarni using a push source might be more efficient since not we are doing async reads in a sense. Remember the actual source

[GitHub] jerrypeng commented on issue #1766: Implementing PushSource on top of Source

2018-05-11 Thread GitBox
jerrypeng commented on issue #1766: Implementing PushSource on top of Source URL: https://github.com/apache/incubator-pulsar/pull/1766#issuecomment-388277056 @srkukarni using a push source might be more efficient since not we are doing async reads in a sense. Remember the actual source

[GitHub] jerrypeng commented on issue #1766: Implementing PushSource on top of Source

2018-05-11 Thread GitBox
jerrypeng commented on issue #1766: Implementing PushSource on top of Source URL: https://github.com/apache/incubator-pulsar/pull/1766#issuecomment-388277056 @srkukarni user a push source might be more efficient since not we are doing async reads in a sense. Remember the actual source

[GitHub] jerrypeng commented on issue #1766: Implementing PushSource on top of Source

2018-05-11 Thread GitBox
jerrypeng commented on issue #1766: Implementing PushSource on top of Source URL: https://github.com/apache/incubator-pulsar/pull/1766#issuecomment-388276631 @srkukarni are you suggesting we poll one tuple at a time? e.g. onsumerRecords = consumer.poll(1); is that

[GitHub] jerrypeng commented on issue #1766: Implementing PushSource on top of Source

2018-05-11 Thread GitBox
jerrypeng commented on issue #1766: Implementing PushSource on top of Source URL: https://github.com/apache/incubator-pulsar/pull/1766#issuecomment-388271445 @sijie @srkukarni please review This is an automated message from