[GitHub] maskit commented on a change in pull request #1089: PIP-12 Introduce builder for creating Producer Consumer Reader

2018-02-15 Thread GitBox
maskit commented on a change in pull request #1089: PIP-12 Introduce builder for creating Producer Consumer Reader URL: https://github.com/apache/incubator-pulsar/pull/1089#discussion_r168492833 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.

[GitHub] maskit commented on a change in pull request #1089: PIP-12 Introduce builder for creating Producer Consumer Reader

2018-02-15 Thread GitBox
maskit commented on a change in pull request #1089: PIP-12 Introduce builder for creating Producer Consumer Reader URL: https://github.com/apache/incubator-pulsar/pull/1089#discussion_r168494543 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/ClientBuilder.ja

[GitHub] maskit commented on a change in pull request #1089: PIP-12 Introduce builder for creating Producer Consumer Reader

2018-02-15 Thread GitBox
maskit commented on a change in pull request #1089: PIP-12 Introduce builder for creating Producer Consumer Reader URL: https://github.com/apache/incubator-pulsar/pull/1089#discussion_r168495214 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/ClientBuilder.ja

[GitHub] maskit commented on a change in pull request #1089: PIP-12 Introduce builder for creating Producer Consumer Reader

2018-02-15 Thread GitBox
maskit commented on a change in pull request #1089: PIP-12 Introduce builder for creating Producer Consumer Reader URL: https://github.com/apache/incubator-pulsar/pull/1089#discussion_r168496502 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/ProducerConfigur

[GitHub] maskit commented on a change in pull request #1089: PIP-12 Introduce builder for creating Producer Consumer Reader

2018-02-16 Thread GitBox
maskit commented on a change in pull request #1089: PIP-12 Introduce builder for creating Producer Consumer Reader URL: https://github.com/apache/incubator-pulsar/pull/1089#discussion_r168908209 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.

[GitHub] maskit commented on a change in pull request #1089: PIP-12 Introduce builder for creating Producer Consumer Reader

2018-02-16 Thread GitBox
maskit commented on a change in pull request #1089: PIP-12 Introduce builder for creating Producer Consumer Reader URL: https://github.com/apache/incubator-pulsar/pull/1089#discussion_r168908209 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.