[GitHub] merlimat commented on a change in pull request #1381: Schema registry 4/N

2018-04-02 Thread GitBox
merlimat commented on a change in pull request #1381: Schema registry 4/N URL: https://github.com/apache/incubator-pulsar/pull/1381#discussion_r178500417 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/Schema.java ## @@ -18,10 +18,14 @@ */ package

[GitHub] merlimat commented on a change in pull request #1381: Schema registry 4/N

2018-04-02 Thread GitBox
merlimat commented on a change in pull request #1381: Schema registry 4/N URL: https://github.com/apache/incubator-pulsar/pull/1381#discussion_r178500572 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java ## @@ -77,7 +79,7 @@ privat

[GitHub] merlimat commented on a change in pull request #1381: Schema registry 4/N

2018-04-02 Thread GitBox
merlimat commented on a change in pull request #1381: Schema registry 4/N URL: https://github.com/apache/incubator-pulsar/pull/1381#discussion_r178501024 ## File path: pulsar-common/src/main/proto/PulsarApi.proto ## @@ -398,7 +397,6 @@ message CommandRedeliverUnacknowledged

[GitHub] merlimat commented on a change in pull request #1381: Schema registry 4/N

2018-04-02 Thread GitBox
merlimat commented on a change in pull request #1381: Schema registry 4/N URL: https://github.com/apache/incubator-pulsar/pull/1381#discussion_r178501324 ## File path: pulsar-common/src/main/proto/PulsarApi.proto ## @@ -31,7 +31,6 @@ message Schema { } requir

[GitHub] merlimat commented on a change in pull request #1381: Schema registry 4/N

2018-03-14 Thread GitBox
merlimat commented on a change in pull request #1381: Schema registry 4/N URL: https://github.com/apache/incubator-pulsar/pull/1381#discussion_r174546254 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/SchemasResource.java ## @@ -0,0 +1,273 @@ +/**

[GitHub] merlimat commented on a change in pull request #1381: Schema registry 4/N

2018-03-14 Thread GitBox
merlimat commented on a change in pull request #1381: Schema registry 4/N URL: https://github.com/apache/incubator-pulsar/pull/1381#discussion_r174546852 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/SchemasResource.java ## @@ -0,0 +1,273 @@ +/**

[GitHub] merlimat commented on a change in pull request #1381: Schema registry 4/N

2018-03-14 Thread GitBox
merlimat commented on a change in pull request #1381: Schema registry 4/N URL: https://github.com/apache/incubator-pulsar/pull/1381#discussion_r174545638 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/SchemasResource.java ## @@ -0,0 +1,273 @@ +/**

[GitHub] merlimat commented on a change in pull request #1381: Schema registry 4/N

2018-03-14 Thread GitBox
merlimat commented on a change in pull request #1381: Schema registry 4/N URL: https://github.com/apache/incubator-pulsar/pull/1381#discussion_r174546539 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/SchemasResource.java ## @@ -0,0 +1,273 @@ +/**