merlimat commented on a change in pull request #1494: In Namespace.addClusters
and Properties.addRoles changed dataType to Set
URL: https://github.com/apache/incubator-pulsar/pull/1494#discussion_r179027633
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
##########
@@ -388,7 +388,7 @@ protected void
internalSetNamespaceReplicationClusters(List<String> clusterIds)
// Force to read the data s.t. the watch to the cache content is
setup.
policiesNode = policiesCache().getWithStat(path(POLICIES,
namespaceName.toString())).orElseThrow(
() -> new RestException(Status.NOT_FOUND, "Namespace " +
namespaceName + " does not exist"));
- policiesNode.getKey().replication_clusters = clusterIds;
+ policiesNode.getKey().replication_clusters =
Lists.newArrayList(replicationClusterSet);
Review comment:
Can we also make `replication_clusters` as a set?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
