[GitHub] merlimat commented on a change in pull request #1743: ByteBuffer schema

merlimat commented on a change in pull request #1743: ByteBuffer schema URL: https://github.com/apache/incubator-pulsar/pull/1743#discussion_r186574681 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageImpl.java ## @@ -205,7 +205,8 @@ public bo

[GitHub] merlimat commented on a change in pull request #1743: ByteBuffer schema

merlimat commented on a change in pull request #1743: ByteBuffer schema URL: https://github.com/apache/incubator-pulsar/pull/1743#discussion_r186575830 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/BytesSchema.java ## @@ -21,15 +21,17 @@ i

[GitHub] merlimat commented on a change in pull request #1743: ByteBuffer schema

merlimat commented on a change in pull request #1743: ByteBuffer schema URL: https://github.com/apache/incubator-pulsar/pull/1743#discussion_r186575966 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/JSONSchema.java ## @@ -43,18 +44,19 @@ pri

[GitHub] merlimat commented on a change in pull request #1743: ByteBuffer schema

merlimat commented on a change in pull request #1743: ByteBuffer schema URL: https://github.com/apache/incubator-pulsar/pull/1743#discussion_r186576446 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/StringSchema.java ## @@ -37,19 +37,16 @@ p

[GitHub] merlimat commented on a change in pull request #1743: ByteBuffer schema

merlimat commented on a change in pull request #1743: ByteBuffer schema URL: https://github.com/apache/incubator-pulsar/pull/1743#discussion_r186575900 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/BytesSchema.java ## @@ -21,15 +21,17 @@ i

[GitHub] merlimat commented on a change in pull request #1743: ByteBuffer schema

merlimat commented on a change in pull request #1743: ByteBuffer schema URL: https://github.com/apache/incubator-pulsar/pull/1743#discussion_r186576324 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/StringSchema.java ## @@ -37,19 +37,16 @@ p

[GitHub] merlimat commented on a change in pull request #1743: ByteBuffer schema

merlimat commented on a change in pull request #1743: ByteBuffer schema URL: https://github.com/apache/incubator-pulsar/pull/1743#discussion_r186576051 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/JSONSchema.java ## @@ -43,18 +44,19 @@ pri

[GitHub] merlimat commented on a change in pull request #1743: ByteBuffer schema

merlimat commented on a change in pull request #1743: ByteBuffer schema URL: https://github.com/apache/incubator-pulsar/pull/1743#discussion_r186559436 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/ByteBufferSchema.java ## @@ -0,0 +1,41 @@