merlimat commented on a change in pull request #2423: [client] add properties to consumer for cpp & python client URL: https://github.com/apache/incubator-pulsar/pull/2423#discussion_r211785148
########## File path: pulsar-client-cpp/docker-build.sh ########## @@ -41,4 +41,4 @@ DOCKER_CMD="docker run -i -v $ROOT_DIR:/pulsar $IMAGE" find . -name CMakeCache.txt | xargs rm -f find . -name CMakeFiles | xargs rm -rf -$DOCKER_CMD bash -c "cd /pulsar/pulsar-client-cpp && cmake . $CMAKE_ARGS && make check-format && make" +$DOCKER_CMD bash -c "cd /pulsar/pulsar-client-cpp && cmake . $CMAKE_ARGS && make format && make check-format && make" Review comment: `make format` should not be performed always (though it would be nice to expose it as a script that runs inside docker to do it) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
