[GitHub] mgodave commented on a change in pull request #1319: Schema registry (2/N)

mgodave commented on a change in pull request #1319: Schema registry (2/N) URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171976063 ## File path: pulsar-broker/pom.xml ## @@ -54,6 +54,12 @@ netty-all + + com.google.protobuf +

[GitHub] mgodave commented on a change in pull request #1319: Schema registry (2/N)

mgodave commented on a change in pull request #1319: Schema registry (2/N) URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171976063 ## File path: pulsar-broker/pom.xml ## @@ -54,6 +54,12 @@ netty-all + + com.google.protobuf +

[GitHub] mgodave commented on a change in pull request #1319: Schema registry (2/N)

mgodave commented on a change in pull request #1319: Schema registry (2/N) URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171976281 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Topic.java ## @@ -125,4 +126,8 @@ void upda

[GitHub] mgodave commented on a change in pull request #1319: Schema registry (2/N)

mgodave commented on a change in pull request #1319: Schema registry (2/N) URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171976424 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Topic.java ## @@ -125,4 +126,8 @@ void upda

[GitHub] mgodave commented on a change in pull request #1319: Schema registry (2/N)

mgodave commented on a change in pull request #1319: Schema registry (2/N) URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171976281 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Topic.java ## @@ -125,4 +126,8 @@ void upda

[GitHub] mgodave commented on a change in pull request #1319: Schema registry (2/N)

mgodave commented on a change in pull request #1319: Schema registry (2/N) URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171976581 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/SchemaRegistry.java ## @@ -0,0 +1,79

[GitHub] mgodave commented on a change in pull request #1319: Schema registry (2/N)

mgodave commented on a change in pull request #1319: Schema registry (2/N) URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171977100 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/SchemaRegistryFormat.java ## @@ -0,0

[GitHub] mgodave commented on a change in pull request #1319: Schema registry (2/N)

mgodave commented on a change in pull request #1319: Schema registry (2/N) URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171977305 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/schema/Schema.java ## @@ -0,0 +1,32 @@ +/** + * Lic

[GitHub] mgodave commented on a change in pull request #1319: Schema registry (2/N)

mgodave commented on a change in pull request #1319: Schema registry (2/N) URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171977549 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/schema/SchemaVersion.java ## @@ -0,0 +1,26 @@ +/**

[GitHub] mgodave commented on a change in pull request #1319: Schema registry (2/N)

mgodave commented on a change in pull request #1319: Schema registry (2/N) URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171977696 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/naming/TopicName.java ## @@ -288,6 +288,13 @@ publi

[GitHub] mgodave commented on a change in pull request #1319: Schema registry (2/N)

mgodave commented on a change in pull request #1319: Schema registry (2/N) URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171977969 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/api/data/SchemaInfo.java ## @@ -0,0 +1,34 @@ +/** +

[GitHub] mgodave commented on a change in pull request #1319: Schema registry (2/N)

mgodave commented on a change in pull request #1319: Schema registry (2/N) URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171978467 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/SchemaStorage.java ## @@ -0,0 +1,83

[GitHub] mgodave commented on a change in pull request #1319: Schema registry (2/N)

mgodave commented on a change in pull request #1319: Schema registry (2/N) URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171979540 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/schema/SchemaVersion.java ## @@ -0,0 +1,26 @@ +/**

[GitHub] mgodave commented on a change in pull request #1319: Schema registry (2/N)

mgodave commented on a change in pull request #1319: Schema registry (2/N) URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171979881 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/SchemaRegistry.java ## @@ -0,0 +1,79

[GitHub] mgodave commented on a change in pull request #1319: Schema registry (2/N)

mgodave commented on a change in pull request #1319: Schema registry (2/N) URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171985679 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/naming/TopicName.java ## @@ -288,6 +288,13 @@ publi

[GitHub] mgodave commented on a change in pull request #1319: Schema registry (2/N)

mgodave commented on a change in pull request #1319: Schema registry (2/N) URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171985692 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/naming/TopicName.java ## @@ -288,6 +288,13 @@ publi