sijie commented on a change in pull request #1223: Add a
`internalConfiguration` admin restful endpoint for query internal configuration
URL: https://github.com/apache/incubator-pulsar/pull/1223#discussion_r168466596
##########
File path:
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/PulsarAdmin.java
##########
@@ -154,6 +156,7 @@ public PulsarAdmin(URL serviceUrl, ClientConfiguration
pulsarConfig) throws Puls
WebTarget root = client.target(serviceUrl.toString());
web = root.path("/admin");
+ this.internalConfiguration = new InternalConfigurationImpl(web, auth);
Review comment:
- I was following how brokerStats is organized, which is not part of broker
as well.
- "brokers" is more about "brokers" in a cluster, not about internal stuffs
for a broker. configuration here is more about "confiugration" in either
cluster/broker level. I am feeling it is much better to have configuration
stuffs in a separate endpoint.
let me know what is your opinons
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
