[GitHub] sijie commented on issue #2570: Fix BC issue in functions trigger function submitted by old CLI

2018-09-13 Thread GitBox
sijie commented on issue #2570: Fix BC issue in functions trigger function submitted by old CLI URL: https://github.com/apache/incubator-pulsar/pull/2570#issuecomment-421231232 @srkukarni : ``` @Parameter(names = "--topicsPattern", description = "TopicsPattern to consume from l

[GitHub] sijie commented on issue #2570: Fix BC issue in functions trigger function submitted by old CLI

2018-09-13 Thread GitBox
sijie commented on issue #2570: Fix BC issue in functions trigger function submitted by old CLI URL: https://github.com/apache/incubator-pulsar/pull/2570#issuecomment-421232435 https://github.com/apache/incubator-pulsar/pull/1903/files#diff-cae1c6ad6356263a1292cfcb9fddc015R110 if --

[GitHub] sijie commented on issue #2570: Fix BC issue in functions trigger function submitted by old CLI

2018-09-13 Thread GitBox
sijie commented on issue #2570: Fix BC issue in functions trigger function submitted by old CLI URL: https://github.com/apache/incubator-pulsar/pull/2570#issuecomment-421232586 looking into the refactor. I believe the refactor mess up this - https://github.com/apache/incubator-pulsar/blob/

[GitHub] sijie commented on issue #2570: Fix BC issue in functions trigger function submitted by old CLI

2018-09-13 Thread GitBox
sijie commented on issue #2570: Fix BC issue in functions trigger function submitted by old CLI URL: https://github.com/apache/incubator-pulsar/pull/2570#issuecomment-421231882 > --topic-pattern = Input Topic Pattern with default schema hmm, I don't believe so. Let me find the origin