[GitHub] srkukarni commented on issue #1766: Implementing PushSource on top of Source

2018-05-11 Thread GitBox
srkukarni commented on issue #1766: Implementing PushSource on top of Source URL: https://github.com/apache/incubator-pulsar/pull/1766#issuecomment-388279890 Not really. Infact this is closer to Storm's KafkaSpout which is a pull model

[GitHub] srkukarni commented on issue #1766: Implementing PushSource on top of Source

2018-05-11 Thread GitBox
srkukarni commented on issue #1766: Implementing PushSource on top of Source URL: https://github.com/apache/incubator-pulsar/pull/1766#issuecomment-388278263 So the main interface is the Source<> interface which has a read() blocking call. Since kafka is also a pull interface, kafkasource

[GitHub] srkukarni commented on issue #1766: Implementing PushSource on top of Source

2018-05-11 Thread GitBox
srkukarni commented on issue #1766: Implementing PushSource on top of Source URL: https://github.com/apache/incubator-pulsar/pull/1766#issuecomment-388275286 Since this is a smallish change, would rather do it here itself? It actually simpifies the code of kafka source