[GitHub] zhaijack commented on issue #1593: PIP-17: the part of index block for offload.

2018-04-26 Thread GitBox
zhaijack commented on issue #1593: PIP-17: the part of index block for offload. URL: https://github.com/apache/incubator-pulsar/pull/1593#issuecomment-384674684 @ivankelly Thanks for the comments, updated to avoid using org.apache.bookkeeper.client.LedgerMetadata serialization ---

[GitHub] zhaijack commented on issue #1593: PIP-17: the part of index block for offload.

2018-04-24 Thread GitBox
zhaijack commented on issue #1593: PIP-17: the part of index block for offload. URL: https://github.com/apache/incubator-pulsar/pull/1593#issuecomment-384160243 retest this please This is an automated message from the Apache

[GitHub] zhaijack commented on issue #1593: PIP-17: the part of index block for offload.

2018-04-24 Thread GitBox
zhaijack commented on issue #1593: PIP-17: the part of index block for offload. URL: https://github.com/apache/incubator-pulsar/pull/1593#issuecomment-384160243 retest this please for `org.apache.pulsar.broker.service.PersistentFailoverE2ETest.testSimpleConsumerEventsWithoutPartition`

[GitHub] zhaijack commented on issue #1593: PIP-17: the part of index block for offload.

2018-04-23 Thread GitBox
zhaijack commented on issue #1593: PIP-17: the part of index block for offload. URL: https://github.com/apache/incubator-pulsar/pull/1593#issuecomment-383760988 retest this please for `org.apache.pulsar.broker.service.PersistentFailoverE2ETest.testSimpleConsumerEventsWithoutPartition`

[GitHub] zhaijack commented on issue #1593: PIP-17: the part of index block for offload.

2018-04-23 Thread GitBox
zhaijack commented on issue #1593: PIP-17: the part of index block for offload. URL: https://github.com/apache/incubator-pulsar/pull/1593#issuecomment-383760988 retest this please This is an automated message from the Apache

[GitHub] zhaijack commented on issue #1593: PIP-17: the part of index block for offload.

2018-04-23 Thread GitBox
zhaijack commented on issue #1593: PIP-17: the part of index block for offload. URL: https://github.com/apache/incubator-pulsar/pull/1593#issuecomment-383623164 Thanks @ivankelly for the comments, changed following your comments and add the logic for reading back.

[GitHub] zhaijack commented on issue #1593: PIP-17: the part of index block for offload.

2018-04-18 Thread GitBox
zhaijack commented on issue #1593: PIP-17: the part of index block for offload. URL: https://github.com/apache/incubator-pulsar/pull/1593#issuecomment-382442101 Thanks @ivankelly for the comments, will change it and add the logic for reading back. -

[GitHub] zhaijack commented on issue #1593: PIP-17: the part of index block for offload.

2018-04-17 Thread GitBox
zhaijack commented on issue #1593: PIP-17: the part of index block for offload. URL: https://github.com/apache/incubator-pulsar/pull/1593#issuecomment-382061476 @ivankelly @sijie Would you please help on review it? Thanks. Th