This is an automated email from the ASF dual-hosted git repository.
tabish pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/qpid-proton-dotnet.git
The following commit(s) were added to refs/heads/main by this push:
new de8aac5 PROTON-2793 Fix build warnings under .NET 8 in tests
de8aac5 is described below
commit de8aac5a6883dd9a6335590f5aec274239c80c20
Author: Timothy Bish <tabish...@gmail.com>
AuthorDate: Tue Feb 20 18:26:50 2024 -0500
PROTON-2793 Fix build warnings under .NET 8 in tests
Some tests have warnings related to logger formatting.
---
.../Client/Implementation/ClientConnectionTest.cs | 6 +--
.../Client/Implementation/ClientReceiverTest.cs | 44 +++++++++++-----------
.../Implementation/ClientReconnectReceiverTest.cs | 2 +-
.../Implementation/ClientReconnectSessionTest.cs | 4 +-
.../ClientReconnectTransactionTest.cs | 8 ++--
.../Client/Implementation/ClientSenderTest.cs | 28 +++++++-------
.../Client/Implementation/ClientSessionTest.cs | 18 ++++-----
.../Implementation/ClientStreamReceiverTest.cs | 26 ++++++-------
.../Implementation/ClientStreamSenderTest.cs | 22 +++++------
.../Implementation/ClilentTransactionsTest.cs | 4 +-
10 files changed, 81 insertions(+), 81 deletions(-)
diff --git
a/test/Proton.Client.Tests/Client/Implementation/ClientConnectionTest.cs
b/test/Proton.Client.Tests/Client/Implementation/ClientConnectionTest.cs
index 0d70eca..3b4198a 100644
--- a/test/Proton.Client.Tests/Client/Implementation/ClientConnectionTest.cs
+++ b/test/Proton.Client.Tests/Client/Implementation/ClientConnectionTest.cs
@@ -1452,7 +1452,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (ClientException ex)
{
- logger.LogDebug("Caught expected exception from blocking
call", ex.Message);
+ logger.LogDebug("Caught expected exception from blocking
call: {0}", ex.Message);
}
}
@@ -1519,7 +1519,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (ClientException ex)
{
- logger.LogDebug("Caught expected exception from blocking
call", ex.Message);
+ logger.LogDebug("Caught expected exception from blocking
call: {0}", ex.Message);
}
}
@@ -1586,7 +1586,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (ClientException ex)
{
- logger.LogDebug("Caught expected exception from blocking
call", ex.Message);
+ logger.LogDebug("Caught expected exception from blocking
call: {0}", ex.Message);
}
}
diff --git
a/test/Proton.Client.Tests/Client/Implementation/ClientReceiverTest.cs
b/test/Proton.Client.Tests/Client/Implementation/ClientReceiverTest.cs
index fdb21f0..d41a470 100644
--- a/test/Proton.Client.Tests/Client/Implementation/ClientReceiverTest.cs
+++ b/test/Proton.Client.Tests/Client/Implementation/ClientReceiverTest.cs
@@ -598,7 +598,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception cliEx)
{
- logger.LogDebug("Receiver threw error on drain call", cliEx);
+ logger.LogDebug("Receiver threw error on drain call: {0}",
cliEx.Message);
Assert.IsTrue(cliEx.InnerException is
ClientIllegalStateException);
}
@@ -908,7 +908,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (ClientException ex)
{
- logger.LogDebug("Caught expected exception from address
call", ex);
+ logger.LogDebug("Caught expected exception from address
call: {0}", ex.Message);
}
}
@@ -918,7 +918,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception ex)
{
- logger.LogDebug("Caught unexpected exception from close call",
ex);
+ logger.LogDebug("Caught unexpected exception from close call:
{0}", ex.Message);
Assert.Fail("Should not fail to close when connection not
closed and detach sent");
}
@@ -1048,7 +1048,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (ClientException ex)
{
- logger.LogDebug("Caught expected exception from blocking
call", ex);
+ logger.LogDebug("Caught expected exception from blocking
call: {0}", ex.Message);
}
}
@@ -1058,7 +1058,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception ex)
{
- logger.LogDebug("Caught unexpected exception from close call",
ex);
+ logger.LogDebug("Caught unexpected exception from close call:
{0}", ex.Message);
Assert.Fail("Should not fail to close when connection not
closed and detach sent");
}
@@ -1131,7 +1131,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (ClientException ex)
{
- logger.LogDebug("Caught expected exception from blocking
call", ex);
+ logger.LogDebug("Caught expected exception from blocking
call: {0}", ex.Message);
}
}
@@ -1141,7 +1141,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception ex)
{
- logger.LogDebug("Caught unexpected exception from close call",
ex);
+ logger.LogDebug("Caught unexpected exception from close call:
{0}", ex.Message);
Assert.Fail("Should not fail to close when connection not
closed and detach sent");
}
@@ -1218,7 +1218,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (ClientException ex)
{
- logger.LogDebug("Caught expected exception from blocking
call", ex);
+ logger.LogDebug("Caught expected exception from blocking
call: {0}", ex.Message);
}
}
@@ -1228,7 +1228,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception ex)
{
- logger.LogDebug("Caught unexpected exception from close call",
ex);
+ logger.LogDebug("Caught unexpected exception from close call:
{0}", ex.Message);
Assert.Fail("Should not fail to close when connection not
closed and detach sent");
}
@@ -1303,7 +1303,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (ClientException ex)
{
- logger.LogDebug("Caught expected exception from blocking
call", ex);
+ logger.LogDebug("Caught expected exception from blocking
call: {0}", ex.Message);
}
}
@@ -1313,7 +1313,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception ex)
{
- logger.LogDebug("Caught unexpected exception from close call",
ex);
+ logger.LogDebug("Caught unexpected exception from close call:
{0}", ex.Message);
Assert.Fail("Should not fail to close when connection not
closed and detach sent");
}
@@ -1388,7 +1388,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (ClientException ex)
{
- logger.LogDebug("Caught expected exception from blocking
call", ex);
+ logger.LogDebug("Caught expected exception from blocking
call: {0}", ex.Message);
}
}
@@ -1398,7 +1398,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception ex)
{
- logger.LogDebug("Caught unexpected exception from close call",
ex);
+ logger.LogDebug("Caught unexpected exception from close call:
{0}", ex.Message);
Assert.Fail("Should not fail to close when connection not
closed and detach sent");
}
@@ -1929,7 +1929,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (ClientIllegalStateException cliEx)
{
- logger.LogDebug("Receiver threw error on receive call", cliEx);
+ logger.LogDebug("Receiver threw error on receive call: {0}",
cliEx.Message);
}
peer.ExpectClose().Respond();
@@ -2076,7 +2076,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (ClientIllegalStateException cliEx)
{
- logger.LogDebug("Receiver threw error on receive call", cliEx);
+ logger.LogDebug("Receiver threw error on receive call: {0}",
cliEx.Message);
}
peer.ExpectClose().Respond();
@@ -2143,7 +2143,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception cliEx)
{
- logger.LogDebug("Receiver threw error on drain call", cliEx);
+ logger.LogDebug("Receiver threw error on drain call: {0}",
cliEx.Message);
Assert.IsTrue(cliEx.InnerException is ClientException);
}
@@ -2200,7 +2200,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception cliEx)
{
- logger.LogDebug("Receiver threw error on drain call", cliEx);
+ logger.LogDebug("Receiver threw error on drain call: {0}",
cliEx.Message);
Assert.IsTrue(cliEx.InnerException is ClientException);
}
@@ -2244,7 +2244,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception cliEx)
{
- logger.LogDebug("Receiver threw error on drain call", cliEx);
+ logger.LogDebug("Receiver threw error on drain call: {0}",
cliEx.Message);
Assert.IsTrue(cliEx.InnerException is ClientException);
}
@@ -2285,7 +2285,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception cliEx)
{
- logger.LogDebug("Receiver threw error on drain call", cliEx);
+ logger.LogDebug("Receiver threw error on drain call: {0}",
cliEx.Message);
Assert.IsTrue(cliEx.InnerException is ClientException);
}
@@ -2330,7 +2330,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception cliEx)
{
- logger.LogDebug("Receiver threw error on drain call", cliEx);
+ logger.LogDebug("Receiver threw error on drain call: {0}",
cliEx.Message);
Assert.IsTrue(cliEx.InnerException is
ClientOperationTimedOutException);
}
@@ -2375,7 +2375,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception cliEx)
{
- logger.LogDebug("Receiver threw error on drain call", cliEx);
+ logger.LogDebug("Receiver threw error on drain call: {0}",
cliEx.Message);
Assert.IsTrue(cliEx.InnerException is
ClientOperationTimedOutException);
}
@@ -2420,7 +2420,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception cliEx)
{
- logger.LogDebug("Receiver threw error on drain call", cliEx);
+ logger.LogDebug("Receiver threw error on drain call: {0}",
cliEx.Message);
Assert.IsTrue(cliEx.InnerException is
ClientOperationTimedOutException);
}
diff --git
a/test/Proton.Client.Tests/Client/Implementation/ClientReconnectReceiverTest.cs
b/test/Proton.Client.Tests/Client/Implementation/ClientReconnectReceiverTest.cs
index 9a46d29..99a0be4 100644
---
a/test/Proton.Client.Tests/Client/Implementation/ClientReconnectReceiverTest.cs
+++
b/test/Proton.Client.Tests/Client/Implementation/ClientReconnectReceiverTest.cs
@@ -177,7 +177,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (ClientConnectionRemotelyClosedException ex)
{
- logger.LogTrace("Error caught: ", ex);
+ logger.LogTrace("Error caught: {0}", ex.Message);
}
receiver.Close();
diff --git
a/test/Proton.Client.Tests/Client/Implementation/ClientReconnectSessionTest.cs
b/test/Proton.Client.Tests/Client/Implementation/ClientReconnectSessionTest.cs
index 7504fef..027e5aa 100644
---
a/test/Proton.Client.Tests/Client/Implementation/ClientReconnectSessionTest.cs
+++
b/test/Proton.Client.Tests/Client/Implementation/ClientReconnectSessionTest.cs
@@ -267,7 +267,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception error)
{
- logger.LogInformation("Session open failed with error: ",
error);
+ logger.LogInformation("Session open failed with error: {0}",
error.Message);
}
connection.Close();
@@ -360,7 +360,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception e)
{
- logger.LogDebug("Exception in next receiver task", e);
+ logger.LogDebug("Exception in next receiver task: {0}",
e.Message);
}
});
diff --git
a/test/Proton.Client.Tests/Client/Implementation/ClientReconnectTransactionTest.cs
b/test/Proton.Client.Tests/Client/Implementation/ClientReconnectTransactionTest.cs
index 0c95e04..fce4423 100644
---
a/test/Proton.Client.Tests/Client/Implementation/ClientReconnectTransactionTest.cs
+++
b/test/Proton.Client.Tests/Client/Implementation/ClientReconnectTransactionTest.cs
@@ -145,7 +145,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (ClientTransactionRolledBackException cliEx)
{
- logger.LogInformation("Caught expected error from test", cliEx);
+ logger.LogInformation("Caught expected error from test: {0}",
cliEx);
}
connection.Close();
@@ -216,7 +216,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (ClientTransactionRolledBackException cliEx)
{
- logger.LogInformation("Caught expected error from test", cliEx);
+ logger.LogInformation("Caught expected error from test: {0}",
cliEx.Message);
}
connection.Close();
@@ -292,7 +292,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (ClientTransactionRolledBackException cliEx)
{
- logger.LogInformation("Caught expected error from test", cliEx);
+ logger.LogInformation("Caught expected error from test: {0}",
cliEx.Message);
}
session.BeginTransaction();
@@ -313,7 +313,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (ClientException cliEx)
{
- logger.LogInformation("Caught unexpected error from test",
cliEx);
+ logger.LogInformation("Caught unexpected error from test: {0}",
cliEx.Message);
Assert.Fail("Should not have failed to declare transaction");
}
diff --git a/test/Proton.Client.Tests/Client/Implementation/ClientSenderTest.cs
b/test/Proton.Client.Tests/Client/Implementation/ClientSenderTest.cs
index 53f84f9..7cb31cd 100644
--- a/test/Proton.Client.Tests/Client/Implementation/ClientSenderTest.cs
+++ b/test/Proton.Client.Tests/Client/Implementation/ClientSenderTest.cs
@@ -1353,7 +1353,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (ClientUnsupportedOperationException unsupported)
{
- logger.LogInformation("Caught expected error: ", unsupported);
+ logger.LogInformation("Caught expected error: {0}",
unsupported.Message);
}
connection.Close();
@@ -1397,7 +1397,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (ClientUnsupportedOperationException unsupported)
{
- logger.LogInformation("Caught expected error: ", unsupported);
+ logger.LogInformation("Caught expected error: {0}",
unsupported.Message);
}
connection.Close();
@@ -1553,7 +1553,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (ClientException ex)
{
- logger.LogDebug("Caught expected exception from blocking
call", ex);
+ logger.LogDebug("Caught expected exception from blocking
call: {0}", ex.Message);
}
}
@@ -1563,7 +1563,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (AggregateException ex)
{
- logger.LogDebug("Caught unexpected exception from close call",
ex);
+ logger.LogDebug("Caught unexpected exception from close call:
{0}", ex.Message);
Assert.Fail("Should not fail to close when connection not
closed and detach sent.");
}
@@ -1639,7 +1639,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (ClientException ex)
{
- logger.LogDebug("Caught expected exception from blocking
call", ex);
+ logger.LogDebug("Caught expected exception from blocking
call: {0}", ex.Message);
}
}
@@ -1649,7 +1649,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception ex)
{
- logger.LogDebug("Caught unexpected exception from close call",
ex);
+ logger.LogDebug("Caught unexpected exception from close call:
{0}", ex.Message);
Assert.Fail("Should not fail to close when connection not
closed and detach sent.");
}
@@ -1723,7 +1723,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (ClientException ex)
{
- logger.LogDebug("Caught expected exception from blocking
call", ex);
+ logger.LogDebug("Caught expected exception from blocking
call: {0}", ex.Message);
}
}
@@ -1733,7 +1733,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception ex)
{
- logger.LogDebug("Caught unexpected exception from close call",
ex);
+ logger.LogDebug("Caught unexpected exception from close call:
{0}", ex.Message);
Assert.Fail("Should not fail to close when connection not
closed and detach sent.");
}
@@ -2354,7 +2354,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception e)
{
- logger.LogInformation("send failed with error: ", e);
+ logger.LogInformation("send failed with error: {0}",
e.Message);
sendFailed = true;
}
});
@@ -2423,7 +2423,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception e)
{
- logger.LogInformation("send failed with error: ", e);
+ logger.LogInformation("send failed with error: {0}",
e.Message);
sendFailed = true;
}
});
@@ -2577,7 +2577,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception e)
{
- logger.LogInformation("Test send 1 failed with error: ", e);
+ logger.LogInformation("Test send 1 failed with error: {0}",
e.Message);
sendFailed = true;
}
});
@@ -2594,7 +2594,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception e)
{
- logger.LogInformation("Test send 2 failed with error: ", e);
+ logger.LogInformation("Test send 2 failed with error: {0}",
e.Message);
sendFailed = true;
}
});
@@ -2661,7 +2661,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception e)
{
- logger.LogInformation("Test send 1 failed with error: ", e);
+ logger.LogInformation("Test send 1 failed with error: {0}",
e.Message);
sendFailed = true;
}
});
@@ -2678,7 +2678,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception e)
{
- logger.LogInformation("Test send 2 failed with error: ", e);
+ logger.LogInformation("Test send 2 failed with error: {0}",
e.Message);
sendFailed = true;
}
});
diff --git
a/test/Proton.Client.Tests/Client/Implementation/ClientSessionTest.cs
b/test/Proton.Client.Tests/Client/Implementation/ClientSessionTest.cs
index 8bcf1d6..c65c3b7 100644
--- a/test/Proton.Client.Tests/Client/Implementation/ClientSessionTest.cs
+++ b/test/Proton.Client.Tests/Client/Implementation/ClientSessionTest.cs
@@ -83,7 +83,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception error)
{
- logger.LogInformation("Session open failed with error: ",
error.Message);
+ logger.LogInformation("Session open failed with error: {0}",
error.Message);
}
connection.CloseAsync().Wait();
@@ -138,7 +138,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception error)
{
- logger.LogInformation("Session open failed with error: ",
error.Message);
+ logger.LogInformation("Session open failed with error: {0}",
error.Message);
Assert.IsTrue(error.InnerException is ClientIOException);
}
@@ -197,7 +197,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception error)
{
- logger.LogInformation("Session close failed with error: ",
error);
+ logger.LogInformation("Session close failed with error: {0}",
error);
}
connection.CloseAsync().Wait();
@@ -370,7 +370,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (ClientException ex)
{
- logger.LogDebug("Caught expected exception from blocking
call", ex.Message);
+ logger.LogDebug("Caught expected exception from blocking
call: {0}", ex.Message);
}
}
@@ -380,7 +380,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception ex)
{
- logger.LogDebug("Caught unexpected exception from close call",
ex);
+ logger.LogDebug("Caught unexpected exception from close call:
{0}", ex.Message);
Assert.Fail("Should not fail to close when connection not
closed and end was sent");
}
@@ -451,7 +451,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (ClientException ex)
{
- logger.LogDebug("Caught expected exception from blocking
call", ex);
+ logger.LogDebug("Caught expected exception from blocking
call: {0}", ex.Message);
}
}
@@ -461,7 +461,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception ex)
{
- logger.LogDebug("Caught unexpected exception from close call",
ex.Message);
+ logger.LogDebug("Caught unexpected exception from close call:
{0}", ex.Message);
Assert.Fail("Should not fail to close when connection not
closed and end was sent");
}
@@ -531,7 +531,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (ClientException ex)
{
- logger.LogDebug("Caught expected exception from blocking
call", ex);
+ logger.LogDebug("Caught expected exception from blocking
call: {0}", ex.Message);
}
}
@@ -541,7 +541,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception ex)
{
- logger.LogDebug("Caught unexpected exception from close call",
ex);
+ logger.LogDebug("Caught unexpected exception from close call:
{0}", ex.Message);
Assert.Fail("Should not fail to close when connection not
closed and end sent");
}
diff --git
a/test/Proton.Client.Tests/Client/Implementation/ClientStreamReceiverTest.cs
b/test/Proton.Client.Tests/Client/Implementation/ClientStreamReceiverTest.cs
index ad0ce6b..a04330f 100644
--- a/test/Proton.Client.Tests/Client/Implementation/ClientStreamReceiverTest.cs
+++ b/test/Proton.Client.Tests/Client/Implementation/ClientStreamReceiverTest.cs
@@ -3471,7 +3471,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception cliEx)
{
- logger.LogInformation("Receiver threw error on drain call",
cliEx);
+ logger.LogInformation("Receiver threw error on drain call:
{0}", cliEx.Message);
Assert.IsTrue(cliEx.InnerException is
ClientOperationTimedOutException);
}
@@ -3515,7 +3515,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception cliEx)
{
- logger.LogDebug("Receiver threw error on drain call", cliEx);
+ logger.LogDebug("Receiver threw error on drain call: {0}",
cliEx.Message);
Assert.IsTrue(cliEx.InnerException is
ClientOperationTimedOutException);
}
@@ -3594,7 +3594,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception cliEx)
{
- logger.LogDebug("Receiver threw error on drain call", cliEx);
+ logger.LogDebug("Receiver threw error on drain call: {0}",
cliEx.Message);
Assert.IsTrue(cliEx.InnerException is
ClientIllegalStateException);
}
@@ -3671,7 +3671,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (ClientException ex)
{
- logger.LogDebug("Caught expected exception from blocking
call", ex);
+ logger.LogDebug("Caught expected exception from blocking
call: {0}", ex.Message);
}
}
@@ -3681,7 +3681,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception ex)
{
- logger.LogDebug("Caught unexpected exception from close call",
ex);
+ logger.LogDebug("Caught unexpected exception from close call:
{0}", ex.Message);
Assert.Fail("Should not fail to close when connection not
closed and detach sent");
}
@@ -3757,7 +3757,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (ClientException ex)
{
- logger.LogDebug("Caught expected exception from blocking
call", ex);
+ logger.LogDebug("Caught expected exception from blocking
call: {0}", ex.Message);
}
}
@@ -3767,7 +3767,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception ex)
{
- logger.LogDebug("Caught unexpected exception from close call",
ex);
+ logger.LogDebug("Caught unexpected exception from close call:
{0}", ex.Message);
Assert.Fail("Should not fail to close when connection not
closed and detach sent");
}
@@ -3843,7 +3843,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (ClientException ex)
{
- logger.LogDebug("Caught expected exception from blocking
call", ex);
+ logger.LogDebug("Caught expected exception from blocking
call: {0}", ex.Message);
}
}
@@ -3853,7 +3853,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception ex)
{
- logger.LogDebug("Caught unexpected exception from close call",
ex);
+ logger.LogDebug("Caught unexpected exception from close call:
{0}", ex.Message);
Assert.Fail("Should not fail to close when connection not
closed and detach sent");
}
@@ -3927,7 +3927,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (ClientException ex)
{
- logger.LogDebug("Caught expected exception from blocking
call", ex);
+ logger.LogDebug("Caught expected exception from blocking
call: {0}", ex.Message);
}
}
@@ -3937,7 +3937,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception ex)
{
- logger.LogDebug("Caught unexpected exception from close call",
ex);
+ logger.LogDebug("Caught unexpected exception from close call:
{0}", ex.Message);
Assert.Fail("Should not fail to close when connection not
closed and detach sent");
}
@@ -4012,7 +4012,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (ClientException ex)
{
- logger.LogDebug("Caught expected exception from blocking call",
ex);
+ logger.LogDebug("Caught expected exception from blocking call:
{0}", ex.Message);
}
}
@@ -4022,7 +4022,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception ex)
{
- logger.LogDebug("Caught unexpected exception from close call", ex);
+ logger.LogDebug("Caught unexpected exception from close call:
{0}", ex.Message);
Assert.Fail("Should not fail to close when connection not closed
and detach sent");
}
diff --git
a/test/Proton.Client.Tests/Client/Implementation/ClientStreamSenderTest.cs
b/test/Proton.Client.Tests/Client/Implementation/ClientStreamSenderTest.cs
index 4054e68..c5b8f11 100644
--- a/test/Proton.Client.Tests/Client/Implementation/ClientStreamSenderTest.cs
+++ b/test/Proton.Client.Tests/Client/Implementation/ClientStreamSenderTest.cs
@@ -1149,7 +1149,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (IOException e)
{
- logger.LogInformation("send failed with error: ", e);
+ logger.LogInformation("send failed with error: {0}",
e.Message);
sendFailed = true;
}
finally
@@ -1993,7 +1993,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception e)
{
- logger.LogInformation("send failed with error: ", e);
+ logger.LogInformation("send failed with error: {0}",
e.Message);
sendFailed = true;
}
});
@@ -2070,7 +2070,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception e)
{
- logger.LogInformation("Test send 1 failed with error: ", e);
+ logger.LogInformation("Test send 1 failed with error: {0}",
e.Message);
sendFailed = true;
}
});
@@ -2085,7 +2085,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception e)
{
- logger.LogInformation("Test send 2 failed with error: ", e);
+ logger.LogInformation("Test send 2 failed with error: {0}",
e.Message);
sendFailed = true;
}
});
@@ -2141,7 +2141,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception e)
{
- logger.LogInformation("Test send 1 failed with error: ", e);
+ logger.LogInformation("Test send 1 failed with error: {0}",
e.Message);
sendFailed = true;
}
});
@@ -2158,7 +2158,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception e)
{
- logger.LogInformation("Test send 2 failed with error: ", e);
+ logger.LogInformation("Test send 2 failed with error: {0}",
e.Message);
sendFailed = true;
}
});
@@ -2226,7 +2226,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception e)
{
- logger.LogInformation("Test send 1 failed with error: ", e);
+ logger.LogInformation("Test send 1 failed with error: {0}",
e.Message);
sendFailed = true;
}
});
@@ -2243,7 +2243,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception e)
{
- logger.LogInformation("Test send 2 failed with error: ", e);
+ logger.LogInformation("Test send 2 failed with error: {0}",
e.Message);
sendFailed = true;
}
});
@@ -2320,7 +2320,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception e)
{
- logger.LogInformation("Test send 1 failed with error: ", e);
+ logger.LogInformation("Test send 1 failed with error: {0}",
e.Message);
sendFailed = true;
}
});
@@ -2450,7 +2450,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (IOException e)
{
- logger.LogInformation("send failed with error: ", e);
+ logger.LogInformation("send failed with error: {0}",
e.Message);
sendFailed = true;
}
finally
@@ -2480,7 +2480,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception e)
{
- logger.LogInformation("Test send 1 failed with error: ", e);
+ logger.LogInformation("Test send 1 failed with error: {0}",
e.Message);
sendFailed = true;
}
finally
diff --git
a/test/Proton.Client.Tests/Client/Implementation/ClilentTransactionsTest.cs
b/test/Proton.Client.Tests/Client/Implementation/ClilentTransactionsTest.cs
index 2e2f3bd..653b631 100644
--- a/test/Proton.Client.Tests/Client/Implementation/ClilentTransactionsTest.cs
+++ b/test/Proton.Client.Tests/Client/Implementation/ClilentTransactionsTest.cs
@@ -599,7 +599,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
}
catch (Exception ex)
{
- logger.LogDebug("Caught unexpected exception from rollback",
ex);
+ logger.LogDebug("Caught unexpected exception from rollback:
{0}", ex.Message);
Assert.Fail("Rollback should not have failed after link
closed.");
}
}
@@ -1404,7 +1404,7 @@ namespace Apache.Qpid.Proton.Client.Implementation
catch (ClientException cliEx)
{
// Expected error as connection was dropped
- logger.LogDebug("Client threw error on begin after connection
drop", cliEx);
+ logger.LogDebug("Client threw error on begin after connection
drop: {0}", cliEx.Message);
}
connection.Close();
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@qpid.apache.org
For additional commands, e-mail: commits-h...@qpid.apache.org
