RANGER-1313: Fix issue found during coverity scan in one of the ranger usersync unit tests
Signed-off-by: Velmurugan Periasamy <v...@apache.org> Project: http://git-wip-us.apache.org/repos/asf/incubator-ranger/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-ranger/commit/1a68c958 Tree: http://git-wip-us.apache.org/repos/asf/incubator-ranger/tree/1a68c958 Diff: http://git-wip-us.apache.org/repos/asf/incubator-ranger/diff/1a68c958 Branch: refs/heads/master Commit: 1a68c9586dcf74c4c0ed29035678d28a907ce94e Parents: 823f51f Author: Sailaja Polavarapu <spolavar...@hortonworks.com> Authored: Tue Jan 17 14:44:20 2017 -0800 Committer: Velmurugan Periasamy <v...@apache.org> Committed: Fri Jan 20 20:25:54 2017 -0500 ---------------------------------------------------------------------- .../test/java/org/apache/ranger/usergroupsync/TestRegEx.java | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-ranger/blob/1a68c958/ugsync/src/test/java/org/apache/ranger/usergroupsync/TestRegEx.java ---------------------------------------------------------------------- diff --git a/ugsync/src/test/java/org/apache/ranger/usergroupsync/TestRegEx.java b/ugsync/src/test/java/org/apache/ranger/usergroupsync/TestRegEx.java index cf61d22..d118265 100644 --- a/ugsync/src/test/java/org/apache/ranger/usergroupsync/TestRegEx.java +++ b/ugsync/src/test/java/org/apache/ranger/usergroupsync/TestRegEx.java @@ -56,7 +56,7 @@ public class TestRegEx { public void testGroupNameTransform() throws Throwable { groupRegexPatterns.add("s/\\s/_/g"); groupRegexPatterns.add("s/_/\\$/g"); - groupNameRegEx.populateReplacementPatterns(userNameBaseProperty, groupRegexPatterns); + groupNameRegEx.populateReplacementPatterns(groupNameBaseProperty, groupRegexPatterns); assertEquals("ldap$grp", groupNameRegEx.transform("ldap grp")); } @@ -69,9 +69,11 @@ public class TestRegEx { @Test public void testTransform() throws Throwable { userRegexPatterns.add("s/\\s/_/g"); + groupRegexPatterns.add("s/\\s/_/g"); userNameRegEx.populateReplacementPatterns(userNameBaseProperty, userRegexPatterns); + groupNameRegEx.populateReplacementPatterns(groupNameBaseProperty, groupRegexPatterns); assertEquals("test_user", userNameRegEx.transform("test user")); - assertEquals("ldap grp", groupNameRegEx.transform("ldap grp")); + assertEquals("ldap_grp", groupNameRegEx.transform("ldap grp")); } @Test @@ -82,7 +84,7 @@ public class TestRegEx { groupRegexPatterns.add("s/\\s/\\$/g"); groupRegexPatterns.add("s/\\s"); groupRegexPatterns.add("s/\\$//g"); - groupNameRegEx.populateReplacementPatterns(userNameBaseProperty, groupRegexPatterns); + groupNameRegEx.populateReplacementPatterns(groupNameBaseProperty, groupRegexPatterns); assertEquals("test user", userNameRegEx.transform("test\\user")); assertEquals("ldapgrp", groupNameRegEx.transform("ldap grp")); }
