Repository: ranger Updated Branches: refs/heads/master e3b0ce2d9 -> 4d9eca776
RANGER-1334: Good coding practices in Ranger Usersync Signed-off-by: Velmurugan Periasamy <v...@apache.org> Project: http://git-wip-us.apache.org/repos/asf/ranger/repo Commit: http://git-wip-us.apache.org/repos/asf/ranger/commit/4d9eca77 Tree: http://git-wip-us.apache.org/repos/asf/ranger/tree/4d9eca77 Diff: http://git-wip-us.apache.org/repos/asf/ranger/diff/4d9eca77 Branch: refs/heads/master Commit: 4d9eca77698db58097b5266f71535a854d1b9bda Parents: e3b0ce2 Author: Sailaja Polavarapu <spolavar...@hortonworks.com> Authored: Mon Jan 30 14:16:25 2017 -0800 Committer: Velmurugan Periasamy <v...@apache.org> Committed: Wed Feb 1 15:52:33 2017 -0500 ---------------------------------------------------------------------- .../ranger/ldapusersync/process/LdapDeltaUserGroupBuilder.java | 2 +- .../ldapusersync/process/LdapPolicyMgrUserGroupBuilder.java | 3 +-- .../apache/ranger/unixusersync/config/UserGroupSyncConfig.java | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/ranger/blob/4d9eca77/ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapDeltaUserGroupBuilder.java ---------------------------------------------------------------------- diff --git a/ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapDeltaUserGroupBuilder.java b/ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapDeltaUserGroupBuilder.java index 0779918..d65ba52 100644 --- a/ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapDeltaUserGroupBuilder.java +++ b/ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapDeltaUserGroupBuilder.java @@ -695,7 +695,7 @@ public class LdapDeltaUserGroupBuilder extends AbstractUserGroupSource { LOG.info("LdapDeltaUserGroupBuilder.getGroups() completed with group count: " + counter); } catch (Throwable t) { - LOG.error("LdapDeltaUserGroupBuilder.getGroups() failed with exception: " + t.getStackTrace()); + LOG.error("LdapDeltaUserGroupBuilder.getGroups() failed with exception: " + t); LOG.info("LdapDeltaUserGroupBuilder.getGroups() group count: " + counter); } http://git-wip-us.apache.org/repos/asf/ranger/blob/4d9eca77/ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapPolicyMgrUserGroupBuilder.java ---------------------------------------------------------------------- diff --git a/ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapPolicyMgrUserGroupBuilder.java b/ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapPolicyMgrUserGroupBuilder.java index 0b909d1..3337f61 100644 --- a/ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapPolicyMgrUserGroupBuilder.java +++ b/ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapPolicyMgrUserGroupBuilder.java @@ -125,8 +125,7 @@ private static final Logger LOG = Logger.getLogger(LdapPolicyMgrUserGroupBuilder } } - @Override - public void init() throws Throwable { + synchronized public void init() throws Throwable { policyMgrBaseUrl = config.getPolicyManagerBaseURL(); isMockRun = config.isMockRunEnabled(); http://git-wip-us.apache.org/repos/asf/ranger/blob/4d9eca77/ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java ---------------------------------------------------------------------- diff --git a/ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java b/ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java index 25c0824..3b8b0f6 100644 --- a/ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java +++ b/ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java @@ -481,7 +481,7 @@ public class UserGroupSyncConfig { private String getUserGroupSourceClassName() { String val = prop.getProperty(UGSYNC_SOURCE_CLASS_PARAM); - String className = null; + String className = UGSYNC_SOURCE_CLASS; String syncSource = null;
