Re: [PR] [ISSUE #8058] Support for upgrading metadata in json to rocksdb (#8045) [rocketmq]

2024-08-22 Thread via GitHub
lizhimins merged PR #8571: URL: https://github.com/apache/rocketmq/pull/8571 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketm

Re: [PR] [ISSUE #8058]Support for upgrading metadata in json to rocksdb (#8045) [rocketmq]

2024-08-22 Thread via GitHub
lizhimins commented on code in PR #8571: URL: https://github.com/apache/rocketmq/pull/8571#discussion_r1726645397 ## broker/src/main/java/org/apache/rocketmq/broker/subscription/RocksDBSubscriptionGroupManager.java: ## @@ -16,39 +16,116 @@ */ package org.apache.rocketmq.broke

Re: [PR] [ISSUE #8058]Support for upgrading metadata in json to rocksdb (#8045) [rocketmq]

2024-08-22 Thread via GitHub
lizhimins commented on code in PR #8571: URL: https://github.com/apache/rocketmq/pull/8571#discussion_r1726620165 ## broker/src/main/java/org/apache/rocketmq/broker/RocksDBConfigManager.java: ## @@ -103,6 +123,20 @@ public void delete(final byte[] keyBytes) throws Exception {

Re: [PR] [ISSUE #8058]Support for upgrading metadata in json to rocksdb (#8045) [rocketmq]

2024-08-21 Thread via GitHub
codecov-commenter commented on PR #8571: URL: https://github.com/apache/rocketmq/pull/8571#issuecomment-2303601656 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8571?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comment

[PR] [ISSUE #8058]Support for upgrading metadata in json to rocksdb (#8045) [rocketmq]

2024-08-21 Thread via GitHub
LetLetMe opened a new pull request, #8571: URL: https://github.com/apache/rocketmq/pull/8571 ### Which Issue(s) This PR Fixes Fixes #8058 ### Brief Description ### How Did You Test This Change? -- This is an automated message from the A

Re: [PR] [ISSUE #8058] Support for upgrading metadata in json to rocksdb (#8045) [rocketmq]

2024-07-10 Thread via GitHub
LetLetMe closed pull request #8116: [ISSUE #8058] Support for upgrading metadata in json to rocksdb (#8045) URL: https://github.com/apache/rocketmq/pull/8116 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] [ISSUE #8058] Support for upgrading metadata in json to rocksdb (#8045) [rocketmq]

2024-05-24 Thread via GitHub
lollipopjin commented on code in PR #8116: URL: https://github.com/apache/rocketmq/pull/8116#discussion_r1613034293 ## broker/src/main/java/org/apache/rocketmq/broker/subscription/RocksDBSubscriptionGroupManager.java: ## @@ -16,39 +16,116 @@ */ package org.apache.rocketmq.bro

Re: [PR] [ISSUE #8058]Support for upgrading metadata in json to rocksdb (#8045) [rocketmq]

2024-05-21 Thread via GitHub
LetLetMe commented on PR #8116: URL: https://github.com/apache/rocketmq/pull/8116#issuecomment-2123820289 > I checked the code, and it seems that upgrading from the 5.2.0 version with RocksDB enabled to this modified version is fully compatible, isn't it? 没问题 No problem -- This

Re: [PR] [ISSUE #8058]Support for upgrading metadata in json to rocksdb (#8045) [rocketmq]

2024-05-10 Thread via GitHub
codecov-commenter commented on PR #8116: URL: https://github.com/apache/rocketmq/pull/8116#issuecomment-2105512083 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8116?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comment

[PR] [ISSUE #8058]Support for upgrading metadata in json to rocksdb (#8045) [rocketmq]

2024-05-10 Thread via GitHub
LetLetMe opened a new pull request, #8116: URL: https://github.com/apache/rocketmq/pull/8116 ### Which Issue(s) This PR Fixes Fixes #issue_id ### Brief Description ### How Did You Test This Change? -- This is an automated message fro

[PR] [ISSUE #8058]Support for upgrading metadata in json to rocksdb (#8045) [rocketmq]

2024-04-29 Thread via GitHub
LetLetMe opened a new pull request, #8081: URL: https://github.com/apache/rocketmq/pull/8081 ### Which Issue(s) This PR Fixes Fixes #8058 ### Brief Description ### How Did You Test This Change? -- This is an automated message from th