LetLetMe closed pull request #8081: [ISSUE #8058] Support for upgrading
metadata in json to rocksdb
URL: https://github.com/apache/rocketmq/pull/8081
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
lizhimins commented on code in PR #8081:
URL: https://github.com/apache/rocketmq/pull/8081#discussion_r1594894709
##
broker/src/main/java/org/apache/rocketmq/broker/RocksDBConfigManager.java:
##
@@ -62,6 +81,44 @@ public boolean load(String configFilePath,
BiConsumer biConsumer
lizhimins commented on code in PR #8081:
URL: https://github.com/apache/rocketmq/pull/8081#discussion_r1591745079
##
common/src/main/java/org/apache/rocketmq/common/config/ConfigRocksDBStorage.java:
##
@@ -52,8 +47,23 @@
import org.rocksdb.WriteOptions;
import org.rocksdb.util
lizhimins commented on code in PR #8081:
URL: https://github.com/apache/rocketmq/pull/8081#discussion_r1591743621
##
broker/src/test/java/org/apache/rocketmq/broker/topic/RocksdbTopicConfigManagerTest.java:
##
@@ -370,6 +378,7 @@ private void supportAttributes(List
supportAttri
lizhimins commented on PR #8081:
URL: https://github.com/apache/rocketmq/pull/8081#issuecomment-2097311806
Suggest adding a feature switch to broker config
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
RongtongJin commented on code in PR #8081:
URL: https://github.com/apache/rocketmq/pull/8081#discussion_r1590770277
##
tools/src/main/java/org/apache/rocketmq/tools/command/metadata/RocksDBConfigToJsonCommand.java:
##
Review Comment:
I wonder know why this command was delet
