Re: [PR] [JAVA]only readable message queues are allowed to be assigned to push consumer [rocketmq-clients]

2024-02-14 Thread via GitHub
github-actions[bot] commented on PR #665: URL: https://github.com/apache/rocketmq-clients/pull/665#issuecomment-1945132183 This PR was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [JAVA]only readable message queues are allowed to be assigned to push consumer [rocketmq-clients]

2024-02-14 Thread via GitHub
github-actions[bot] closed pull request #665: [JAVA]only readable message queues are allowed to be assigned to push consumer URL: https://github.com/apache/rocketmq-clients/pull/665 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [JAVA]only readable message queues are allowed to be assigned to push consumer [rocketmq-clients]

2024-02-10 Thread via GitHub
github-actions[bot] commented on PR #665: URL: https://github.com/apache/rocketmq-clients/pull/665#issuecomment-1937366846 This PR is stale because it has been open for 30 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale,

Re: [PR] [JAVA]only readable message queues are allowed to be assigned to push consumer [rocketmq-clients]

2024-01-11 Thread via GitHub
aaron-ai commented on PR #665: URL: https://github.com/apache/rocketmq-clients/pull/665#issuecomment-1886647603 The queue returned by the server must always be readable, which is actually an agreement established with the server side. @drpmma please review whether this modification i

Re: [PR] [JAVA]only readable message queues are allowed to be assigned to push consumer [rocketmq-clients]

2024-01-11 Thread via GitHub
glcrazier commented on code in PR #665: URL: https://github.com/apache/rocketmq-clients/pull/665#discussion_r1448457023 ## java/client/src/main/java/org/apache/rocketmq/client/java/impl/consumer/PushConsumerImpl.java: ## @@ -389,6 +390,14 @@ public void onSuccess(Assignments lat

Re: [PR] [JAVA]only readable message queues are allowed to be assigned to push consumer [rocketmq-clients]

2024-01-11 Thread via GitHub
aaron-ai commented on code in PR #665: URL: https://github.com/apache/rocketmq-clients/pull/665#discussion_r1448452521 ## java/client/src/main/java/org/apache/rocketmq/client/java/impl/consumer/PushConsumerImpl.java: ## @@ -389,6 +390,14 @@ public void onSuccess(Assignments late

[PR] [JAVA]only readable message queues are allowed to be assigned to push consumer [rocketmq-clients]

2024-01-03 Thread via GitHub
glcrazier opened a new pull request, #665: URL: https://github.com/apache/rocketmq-clients/pull/665 ### Which Issue(s) This PR Fixes When PushConsumer gets new assignments from the server, it does not check permission of message queues. ### Brief Description