This is an automated email from the ASF dual-hosted git repository. aharui pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
The following commit(s) were added to refs/heads/develop by this push: new 11cd8dd clean up some warnings 11cd8dd is described below commit 11cd8ddea0311ec0ee2c841b4e213f27a62fc62d Author: Alex Harui <aha...@apache.org> AuthorDate: Wed Dec 26 17:55:17 2018 -0800 clean up some warnings --- .../VirtualDataItemRendererFactoryForICollectionViewData.as | 4 ++-- .../projects/SparkRoyale/src/main/royale/spark/components/Group.as | 6 ++++-- .../main/royale/spark/layouts/supportClasses/LayoutElementHelper.as | 2 +- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/frameworks/projects/MXRoyale/src/main/royale/mx/controls/listClasses/VirtualDataItemRendererFactoryForICollectionViewData.as b/frameworks/projects/MXRoyale/src/main/royale/mx/controls/listClasses/VirtualDataItemRendererFactoryForICollectionViewData.as index 20a5a5f..14520b2 100644 --- a/frameworks/projects/MXRoyale/src/main/royale/mx/controls/listClasses/VirtualDataItemRendererFactoryForICollectionViewData.as +++ b/frameworks/projects/MXRoyale/src/main/royale/mx/controls/listClasses/VirtualDataItemRendererFactoryForICollectionViewData.as @@ -153,11 +153,11 @@ package mx.controls.listClasses cursor = dp.createCursor(); } + var view:IListView = (_strand as IStrandWithModelView).view as IListView; + var dataGroup:IItemRendererParent = view.dataGroup; ir = itemRendererFactory.createItemRenderer(dataGroup) as ISelectableItemRenderer; var dataItemRenderer:DataItemRenderer = ir as DataItemRenderer; - var view:IListView = (_strand as IStrandWithModelView).view as IListView; - var dataGroup:IItemRendererParent = view.dataGroup; dataGroup.addItemRendererAt(ir, elementIndex); ir.index = index; ir.labelField = labelField; diff --git a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/Group.as b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/Group.as index 4e2250c..34610f2 100644 --- a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/Group.as +++ b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/Group.as @@ -498,13 +498,15 @@ public class Group extends GroupBase /*implements IVisualElementContainer, // if there's old content and it's different than what // we're trying to set it to, then let's remove all the old // elements first. + /* if (_mxmlContent != null && _mxmlContent != value) { - /*for (i = _mxmlContent.length - 1; i >= 0; i--) + for (i = _mxmlContent.length - 1; i >= 0; i--) { elementRemoved(_mxmlContent[i], i); - }*/ + } } + */ _mxmlContent = (value) ? value.concat() : null; // defensive copy diff --git a/frameworks/projects/SparkRoyale/src/main/royale/spark/layouts/supportClasses/LayoutElementHelper.as b/frameworks/projects/SparkRoyale/src/main/royale/spark/layouts/supportClasses/LayoutElementHelper.as index f15b056..ceec9d7 100644 --- a/frameworks/projects/SparkRoyale/src/main/royale/spark/layouts/supportClasses/LayoutElementHelper.as +++ b/frameworks/projects/SparkRoyale/src/main/royale/spark/layouts/supportClasses/LayoutElementHelper.as @@ -80,7 +80,7 @@ public class LayoutElementHelper * so that an array is returned where the first value is * the offset (ie: 10) and the second value is * the boundary (ie: "col1") - * @arg result : optional Array to save an Array memory allocation + * @param result : optional Array to save an Array memory allocation */ public static function parseConstraintExp(val:Object, result:Array=null):Array {