[GitHub] [samza] mynameborat commented on a change in pull request #1449: SAMZA-2609: Data model changes to track lifecycle information of job coordinator

2020-12-07 Thread GitBox
mynameborat commented on a change in pull request #1449: URL: https://github.com/apache/samza/pull/1449#discussion_r537983477 ## File path: samza-api/src/main/java/org/apache/samza/job/JobCoordinatorMetadata.java ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [samza] lakshmi-manasa-g commented on a change in pull request #1449: SAMZA-2609: Data model changes to track lifecycle information of job coordinator

2020-12-07 Thread GitBox
lakshmi-manasa-g commented on a change in pull request #1449: URL: https://github.com/apache/samza/pull/1449#discussion_r537918515 ## File path: samza-api/src/main/java/org/apache/samza/job/JobCoordinatorMetadata.java ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [samza] lakshmi-manasa-g commented on a change in pull request #1446: [WIP] SAMZA-2605: Make Standby Container Requests Rack Aware

2020-12-07 Thread GitBox
lakshmi-manasa-g commented on a change in pull request #1446: URL: https://github.com/apache/samza/pull/1446#discussion_r537893226 ## File path: samza-yarn/src/main/java/org/apache/samza/job/yarn/RackManager.java ## @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [samza] mynameborat removed a comment on pull request #1450: SAMZA-2610: Handle Metadata changes for AM HA orchestration

2020-12-07 Thread GitBox
mynameborat removed a comment on pull request #1450: URL: https://github.com/apache/samza/pull/1450#issuecomment-737668815 Will handle the merge conflicts once the other dependent PRs #1448 & #1449 are committed. This is an

[samza] branch master updated (220cbe2 -> 5a099eb)

2020-12-07 Thread bharathkk
This is an automated email from the ASF dual-hosted git repository. bharathkk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/samza.git. from 220cbe2 SAMZA-2611: [AM-HA] heartbeat reestablish causes container's heartbeat thread to die (#1452) add 5a0

[GitHub] [samza] mynameborat merged pull request #1448: SAMZA-2606: container orchestration for AM HA

2020-12-07 Thread GitBox
mynameborat merged pull request #1448: URL: https://github.com/apache/samza/pull/1448 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [samza] mynameborat commented on a change in pull request #1448: SAMZA-2606: container orchestration for AM HA

2020-12-07 Thread GitBox
mynameborat commented on a change in pull request #1448: URL: https://github.com/apache/samza/pull/1448#discussion_r537826816 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/ContainerProcessManager.java ## @@ -254,10 +257,10 @@ public void start() {

[GitHub] [samza] lakshmi-manasa-g commented on a change in pull request #1448: SAMZA-2606: container orchestration for AM HA

2020-12-07 Thread GitBox
lakshmi-manasa-g commented on a change in pull request #1448: URL: https://github.com/apache/samza/pull/1448#discussion_r537659102 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/ContainerProcessManager.java ## @@ -236,11 +236,20 @@ public void start() {

[GitHub] [samza] mynameborat commented on a change in pull request #1448: SAMZA-2606: container orchestration for AM HA

2020-12-07 Thread GitBox
mynameborat commented on a change in pull request #1448: URL: https://github.com/apache/samza/pull/1448#discussion_r537620505 ## File path: samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaYarnAppMasterLifecycle.scala ## @@ -48,6 +52,19 @@ class SamzaYarnAppMasterLifec

[GitHub] [samza] mynameborat commented on a change in pull request #1448: SAMZA-2606: container orchestration for AM HA

2020-12-07 Thread GitBox
mynameborat commented on a change in pull request #1448: URL: https://github.com/apache/samza/pull/1448#discussion_r536481015 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/ContainerProcessManager.java ## @@ -653,6 +656,20 @@ private String getPendingPr

[GitHub] [samza] mynameborat commented on a change in pull request #1448: SAMZA-2606: container orchestration for AM HA

2020-12-07 Thread GitBox
mynameborat commented on a change in pull request #1448: URL: https://github.com/apache/samza/pull/1448#discussion_r537618206 ## File path: samza-core/src/main/java/org/apache/samza/coordinator/stream/messages/SetExecutionContainerIdMapping.java ## @@ -0,0 +1,65 @@ +/* Review

[samza] branch master updated: SAMZA-2611: [AM-HA] heartbeat reestablish causes container's heartbeat thread to die (#1452)

2020-12-07 Thread bharathkk
This is an automated email from the ASF dual-hosted git repository. bharathkk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/samza.git The following commit(s) were added to refs/heads/master by this push: new 220cbe2 SAMZA-2611: [AM-HA] heartbeat reestab

[GitHub] [samza] mynameborat merged pull request #1452: SAMZA-2611: [AM-HA] heartbeat reestablish causes container's heartbeat thread to die

2020-12-07 Thread GitBox
mynameborat merged pull request #1452: URL: https://github.com/apache/samza/pull/1452 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [samza] mynameborat removed a comment on pull request #1452: SAMZA-2611: [AM-HA] heartbeat reestablish causes container's heartbeat thread to die

2020-12-07 Thread GitBox
mynameborat removed a comment on pull request #1452: URL: https://github.com/apache/samza/pull/1452#issuecomment-740003171 Symptom: When new AM takes a long time to to start up, already running container's heartbeat thread silently dies and does not make any heartbeat requests to the new A

[GitHub] [samza] mynameborat commented on pull request #1452: SAMZA-2611: [AM-HA] heartbeat reestablish causes container's heartbeat thread to die

2020-12-07 Thread GitBox
mynameborat commented on pull request #1452: URL: https://github.com/apache/samza/pull/1452#issuecomment-740003171 Symptom: When new AM takes a long time to to start up, already running container's heartbeat thread silently dies and does not make any heartbeat requests to the new AM.

[GitHub] [samza] mynameborat commented on a change in pull request #1452: SAMZA-2611: [AM-HA] heartbeat reestablish causes container's heartbeat thread to die

2020-12-07 Thread GitBox
mynameborat commented on a change in pull request #1452: URL: https://github.com/apache/samza/pull/1452#discussion_r537610193 ## File path: samza-core/src/main/java/org/apache/samza/container/ContainerHeartbeatMonitor.java ## @@ -92,17 +93,19 @@ public void start() { if