[GitHub] [samza] ajothomas commented on a diff in pull request #1639: SAMZA-2741: [Pipeline Drain] Fix processing of Drain messages for High-Level and Low-level API

2022-11-03 Thread GitBox
ajothomas commented on code in PR #1639: URL: https://github.com/apache/samza/pull/1639#discussion_r1013123301 ## samza-core/src/main/java/org/apache/samza/container/RunLoop.java: ## @@ -875,49 +876,40 @@ private boolean shouldDrain() { return false; } - i

[GitHub] [samza] ajothomas commented on a diff in pull request #1639: SAMZA-2741: [Pipeline Drain] Fix processing of Drain messages for High-Level and Low-level API

2022-11-03 Thread GitBox
ajothomas commented on code in PR #1639: URL: https://github.com/apache/samza/pull/1639#discussion_r1013123456 ## samza-core/src/main/java/org/apache/samza/container/RunLoop.java: ## @@ -875,49 +876,40 @@ private boolean shouldDrain() { return false; } - i

[GitHub] [samza] ajothomas commented on a diff in pull request #1639: SAMZA-2741: [Pipeline Drain] Fix processing of Drain messages for High-Level and Low-level API

2022-11-03 Thread GitBox
ajothomas commented on code in PR #1639: URL: https://github.com/apache/samza/pull/1639#discussion_r1013123821 ## samza-test/src/test/java/org/apache/samza/test/drain/DrainHighLevelApiIntegrationTest.java: ## @@ -74,20 +74,30 @@ public void describe(StreamApplicationDescriptor

[GitHub] [samza] xinyuiscool merged pull request #1639: SAMZA-2741: [Pipeline Drain] Fix processing of Drain messages for High-Level and Low-level API

2022-11-03 Thread GitBox
xinyuiscool merged PR #1639: URL: https://github.com/apache/samza/pull/1639 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@samza.ap

[samza] branch master updated: SAMZA-2741: Pipeline Drain- Fix processing of Drain messages for both low-level and high level API (#1639)

2022-11-03 Thread xinyu
This is an automated email from the ASF dual-hosted git repository. xinyu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/samza.git The following commit(s) were added to refs/heads/master by this push: new 3d4747c5c SAMZA-2741: Pipeline Drain- Fix processi

[GitHub] [samza] mynameborat commented on a diff in pull request #1637: SAMZA-2765: [Pipeline Drain] Adding config for task callback timeout during drain

2022-11-03 Thread GitBox
mynameborat commented on code in PR #1637: URL: https://github.com/apache/samza/pull/1637#discussion_r1013403151 ## samza-core/src/main/java/org/apache/samza/task/TaskCallbackManager.java: ## @@ -106,7 +110,10 @@ public void run() { callback.failure(new SamzaException

[GitHub] [samza] mynameborat merged pull request #1638: SAMZA-2764: add the metric "container-active-threads" back

2022-11-03 Thread GitBox
mynameborat merged PR #1638: URL: https://github.com/apache/samza/pull/1638 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@samza.ap

[samza] branch master updated: add the metric "container-active-threads" back (#1638)

2022-11-03 Thread bharathkk
This is an automated email from the ASF dual-hosted git repository. bharathkk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/samza.git The following commit(s) were added to refs/heads/master by this push: new 95a0c3334 add the metric "container-active-thr