[GitHub] [samza] alnzng commented on a diff in pull request #1641: LISAMZA-27395 removing the current recursive call prevention logic

2022-11-14 Thread GitBox
alnzng commented on code in PR #1641: URL: https://github.com/apache/samza/pull/1641#discussion_r1021917783 ## samza-log4j2/src/main/java/org/apache/samza/logging/log4j2/StreamAppenderMetrics.java: ## @@ -46,7 +43,6 @@ public class StreamAppenderMetrics extends MetricsBase {

[GitHub] [samza] jia-gao commented on pull request #1641: LISAMZA-27395 removing the current recursive call prevention logic

2022-11-14 Thread GitBox
jia-gao commented on PR #1641: URL: https://github.com/apache/samza/pull/1641#issuecomment-1314166098 > Is the default support to prevent recursion not available when this change was introduced or did we upgrade to newer version of log4j that adds this prevention at the framework layer?