[GitHub] [samza] PawasChhokra commented on a change in pull request #1446: SAMZA-2605: Make Standby Container Requests Rack Aware

PawasChhokra commented on a change in pull request #1446: URL: https://github.com/apache/samza/pull/1446#discussion_r548372801 ## File path: samza-yarn/src/main/java/org/apache/samza/job/yarn/YarnClusterResourceManager.java ## @@ -241,6 +241,11 @@ public void requestResources(

[GitHub] [samza] PawasChhokra commented on a change in pull request #1446: SAMZA-2605: Make Standby Container Requests Rack Aware

PawasChhokra commented on a change in pull request #1446: URL: https://github.com/apache/samza/pull/1446#discussion_r547140581 ## File path: samza-yarn/src/main/java/org/apache/samza/job/yarn/RackManager.java ## @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [samza] PawasChhokra commented on a change in pull request #1446: SAMZA-2605: Make Standby Container Requests Rack Aware

PawasChhokra commented on a change in pull request #1446: URL: https://github.com/apache/samza/pull/1446#discussion_r547138145 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/StandbyContainerManager.java ## @@ -168,11 +173,13 @@ public void handleContain

[GitHub] [samza] PawasChhokra commented on a change in pull request #1446: SAMZA-2605: Make Standby Container Requests Rack Aware

PawasChhokra commented on a change in pull request #1446: URL: https://github.com/apache/samza/pull/1446#discussion_r547138145 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/StandbyContainerManager.java ## @@ -168,11 +173,13 @@ public void handleContain

[GitHub] [samza] PawasChhokra commented on a change in pull request #1446: SAMZA-2605: Make Standby Container Requests Rack Aware

PawasChhokra commented on a change in pull request #1446: URL: https://github.com/apache/samza/pull/1446#discussion_r547138145 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/StandbyContainerManager.java ## @@ -168,11 +173,13 @@ public void handleContain

[GitHub] [samza] PawasChhokra commented on a change in pull request #1446: SAMZA-2605: Make Standby Container Requests Rack Aware

PawasChhokra commented on a change in pull request #1446: URL: https://github.com/apache/samza/pull/1446#discussion_r547120067 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/StandbyContainerManager.java ## @@ -233,9 +275,13 @@ private void initiateStand

[GitHub] [samza] PawasChhokra commented on a change in pull request #1446: SAMZA-2605: Make Standby Container Requests Rack Aware

PawasChhokra commented on a change in pull request #1446: URL: https://github.com/apache/samza/pull/1446#discussion_r547119767 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/StandbyContainerManager.java ## @@ -361,8 +407,41 @@ private FailoverMetadata

[GitHub] [samza] PawasChhokra commented on a change in pull request #1446: SAMZA-2605: Make Standby Container Requests Rack Aware

PawasChhokra commented on a change in pull request #1446: URL: https://github.com/apache/samza/pull/1446#discussion_r547101266 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/StandbyContainerManager.java ## @@ -375,24 +454,39 @@ boolean checkStandbyConst

[GitHub] [samza] PawasChhokra commented on a change in pull request #1446: SAMZA-2605: Make Standby Container Requests Rack Aware

PawasChhokra commented on a change in pull request #1446: URL: https://github.com/apache/samza/pull/1446#discussion_r546192683 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/StandbyContainerManager.java ## @@ -409,16 +470,18 @@ public void checkStandby

[GitHub] [samza] PawasChhokra commented on a change in pull request #1446: SAMZA-2605: Make Standby Container Requests Rack Aware

PawasChhokra commented on a change in pull request #1446: URL: https://github.com/apache/samza/pull/1446#discussion_r546189549 ## File path: samza-yarn/src/main/java/org/apache/samza/job/yarn/YarnFaultDomainManager.java ## @@ -117,4 +120,8 @@ public boolean hasSameFaultDomains

[GitHub] [samza] PawasChhokra commented on a change in pull request #1446: SAMZA-2605: Make Standby Container Requests Rack Aware

PawasChhokra commented on a change in pull request #1446: URL: https://github.com/apache/samza/pull/1446#discussion_r546189004 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/StandbyContainerManager.java ## @@ -181,13 +207,14 @@ private void handleStandb

[GitHub] [samza] PawasChhokra commented on a change in pull request #1446: SAMZA-2605: Make Standby Container Requests Rack Aware

PawasChhokra commented on a change in pull request #1446: URL: https://github.com/apache/samza/pull/1446#discussion_r546188896 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/StandbyContainerManager.java ## @@ -375,24 +421,39 @@ boolean checkStandbyConst

[GitHub] [samza] PawasChhokra commented on a change in pull request #1446: SAMZA-2605: Make Standby Container Requests Rack Aware

PawasChhokra commented on a change in pull request #1446: URL: https://github.com/apache/samza/pull/1446#discussion_r546188838 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/StandbyContainerManager.java ## @@ -375,24 +421,39 @@ boolean checkStandbyConst

[GitHub] [samza] PawasChhokra commented on a change in pull request #1446: SAMZA-2605: Make Standby Container Requests Rack Aware

PawasChhokra commented on a change in pull request #1446: URL: https://github.com/apache/samza/pull/1446#discussion_r546166427 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/SamzaApplicationState.java ## @@ -170,6 +170,26 @@ */ public final Atomi

[GitHub] [samza] PawasChhokra commented on a change in pull request #1446: SAMZA-2605: Make Standby Container Requests Rack Aware

PawasChhokra commented on a change in pull request #1446: URL: https://github.com/apache/samza/pull/1446#discussion_r546164722 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/FaultDomainManager.java ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Soft

[GitHub] [samza] PawasChhokra commented on a change in pull request #1446: SAMZA-2605: Make Standby Container Requests Rack Aware

PawasChhokra commented on a change in pull request #1446: URL: https://github.com/apache/samza/pull/1446#discussion_r546153415 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/ContainerAllocator.java ## @@ -381,6 +428,9 @@ public final void issueResourceR

[GitHub] [samza] PawasChhokra commented on a change in pull request #1446: SAMZA-2605: Make Standby Container Requests Rack Aware

PawasChhokra commented on a change in pull request #1446: URL: https://github.com/apache/samza/pull/1446#discussion_r545289191 ## File path: samza-yarn/src/main/java/org/apache/samza/config/YarnConfig.java ## @@ -49,6 +49,11 @@ */ public static final String CONTAINER_LAB

[GitHub] [samza] PawasChhokra commented on a change in pull request #1446: SAMZA-2605: Make Standby Container Requests Rack Aware

PawasChhokra commented on a change in pull request #1446: URL: https://github.com/apache/samza/pull/1446#discussion_r545287853 ## File path: samza-yarn/src/main/java/org/apache/samza/job/yarn/YarnFaultDomainManager.java ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Softw

[GitHub] [samza] PawasChhokra commented on a change in pull request #1446: SAMZA-2605: Make Standby Container Requests Rack Aware

PawasChhokra commented on a change in pull request #1446: URL: https://github.com/apache/samza/pull/1446#discussion_r545287416 ## File path: samza-core/src/main/java/org/apache/samza/config/ClusterManagerConfig.java ## @@ -38,6 +38,9 @@ private static final String CLUSTER_M

[GitHub] [samza] PawasChhokra commented on a change in pull request #1446: SAMZA-2605: Make Standby Container Requests Rack Aware

PawasChhokra commented on a change in pull request #1446: URL: https://github.com/apache/samza/pull/1446#discussion_r545286825 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/SamzaApplicationState.java ## @@ -170,6 +170,31 @@ */ public final Atomi

[GitHub] [samza] PawasChhokra commented on a change in pull request #1446: SAMZA-2605: Make Standby Container Requests Rack Aware

PawasChhokra commented on a change in pull request #1446: URL: https://github.com/apache/samza/pull/1446#discussion_r545284839 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/FaultDomainManager.java ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Soft

[GitHub] [samza] PawasChhokra commented on a change in pull request #1446: SAMZA-2605: Make Standby Container Requests Rack Aware

PawasChhokra commented on a change in pull request #1446: URL: https://github.com/apache/samza/pull/1446#discussion_r545283845 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/FaultDomain.java ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [samza] PawasChhokra commented on a change in pull request #1446: SAMZA-2605: Make Standby Container Requests Rack Aware

PawasChhokra commented on a change in pull request #1446: URL: https://github.com/apache/samza/pull/1446#discussion_r544913652 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/SamzaResourceRequest.java ## @@ -63,7 +69,11 @@ private final Instant reques

[GitHub] [samza] PawasChhokra commented on a change in pull request #1446: SAMZA-2605: Make Standby Container Requests Rack Aware

PawasChhokra commented on a change in pull request #1446: URL: https://github.com/apache/samza/pull/1446#discussion_r542557637 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/FaultDomainManager.java ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Soft

[GitHub] [samza] PawasChhokra commented on a change in pull request #1446: SAMZA-2605: Make Standby Container Requests Rack Aware

PawasChhokra commented on a change in pull request #1446: URL: https://github.com/apache/samza/pull/1446#discussion_r539872461 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/SamzaResourceRequest.java ## @@ -63,7 +69,11 @@ private final Instant reques

[GitHub] [samza] PawasChhokra commented on a change in pull request #1446: SAMZA-2605: Make Standby Container Requests Rack Aware

PawasChhokra commented on a change in pull request #1446: URL: https://github.com/apache/samza/pull/1446#discussion_r539975584 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/FaultDomainManager.java ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Soft

[GitHub] [samza] PawasChhokra commented on a change in pull request #1446: SAMZA-2605: Make Standby Container Requests Rack Aware

PawasChhokra commented on a change in pull request #1446: URL: https://github.com/apache/samza/pull/1446#discussion_r539951301 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/StandbyContainerManager.java ## @@ -375,18 +403,32 @@ boolean checkStandbyConst

[GitHub] [samza] PawasChhokra commented on a change in pull request #1446: SAMZA-2605: Make Standby Container Requests Rack Aware

PawasChhokra commented on a change in pull request #1446: URL: https://github.com/apache/samza/pull/1446#discussion_r539948685 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/StandbyContainerManager.java ## @@ -375,18 +403,32 @@ boolean checkStandbyConst

[GitHub] [samza] PawasChhokra commented on a change in pull request #1446: SAMZA-2605: Make Standby Container Requests Rack Aware

PawasChhokra commented on a change in pull request #1446: URL: https://github.com/apache/samza/pull/1446#discussion_r539888750 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/SamzaResourceRequest.java ## @@ -109,15 +135,24 @@ public String toString() {

[GitHub] [samza] PawasChhokra commented on a change in pull request #1446: SAMZA-2605: Make Standby Container Requests Rack Aware

PawasChhokra commented on a change in pull request #1446: URL: https://github.com/apache/samza/pull/1446#discussion_r539872461 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/SamzaResourceRequest.java ## @@ -63,7 +69,11 @@ private final Instant reques

[GitHub] [samza] PawasChhokra commented on a change in pull request #1446: SAMZA-2605: Make Standby Container Requests Rack Aware

PawasChhokra commented on a change in pull request #1446: URL: https://github.com/apache/samza/pull/1446#discussion_r539867974 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/FaultDomainManager.java ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Soft

[GitHub] [samza] PawasChhokra commented on a change in pull request #1446: SAMZA-2605: Make Standby Container Requests Rack Aware

PawasChhokra commented on a change in pull request #1446: URL: https://github.com/apache/samza/pull/1446#discussion_r539867459 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/FaultDomainManager.java ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Soft

[GitHub] [samza] PawasChhokra commented on a change in pull request #1446: SAMZA-2605: Make Standby Container Requests Rack Aware

PawasChhokra commented on a change in pull request #1446: URL: https://github.com/apache/samza/pull/1446#discussion_r539866505 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/FaultDomainManager.java ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Soft

[GitHub] [samza] PawasChhokra commented on a change in pull request #1446: SAMZA-2605: Make Standby Container Requests Rack Aware

PawasChhokra commented on a change in pull request #1446: URL: https://github.com/apache/samza/pull/1446#discussion_r539862368 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/FaultDomainManager.java ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Soft

[GitHub] [samza] PawasChhokra commented on a change in pull request #1446: SAMZA-2605: Make Standby Container Requests Rack Aware

PawasChhokra commented on a change in pull request #1446: URL: https://github.com/apache/samza/pull/1446#discussion_r539525379 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/FaultDomainManager.java ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Soft

[GitHub] [samza] PawasChhokra commented on a change in pull request #1446: SAMZA-2605: Make Standby Container Requests Rack Aware

PawasChhokra commented on a change in pull request #1446: URL: https://github.com/apache/samza/pull/1446#discussion_r539518439 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/FaultDomainManager.java ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Soft

[GitHub] [samza] PawasChhokra commented on a change in pull request #1446: SAMZA-2605: Make Standby Container Requests Rack Aware

PawasChhokra commented on a change in pull request #1446: URL: https://github.com/apache/samza/pull/1446#discussion_r539517529 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/FaultDomainManager.java ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Soft

[GitHub] [samza] PawasChhokra commented on a change in pull request #1446: SAMZA-2605: Make Standby Container Requests Rack Aware

PawasChhokra commented on a change in pull request #1446: URL: https://github.com/apache/samza/pull/1446#discussion_r539514875 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/FaultDomainManager.java ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Soft

[GitHub] [samza] PawasChhokra commented on a change in pull request #1446: SAMZA-2605: Make Standby Container Requests Rack Aware

PawasChhokra commented on a change in pull request #1446: URL: https://github.com/apache/samza/pull/1446#discussion_r538854823 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/FaultDomain.java ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Fo