[GitHub] [samza] ajothomas commented on a diff in pull request #1639: SAMZA-2741: [Pipeline Drain] Fix processing of Drain messages for High-Level and Low-level API

2022-11-03 Thread GitBox
ajothomas commented on code in PR #1639: URL: https://github.com/apache/samza/pull/1639#discussion_r1013123821 ## samza-test/src/test/java/org/apache/samza/test/drain/DrainHighLevelApiIntegrationTest.java: ## @@ -74,20 +74,30 @@ public void describe(StreamApplicationDescriptor

[GitHub] [samza] ajothomas commented on a diff in pull request #1639: SAMZA-2741: [Pipeline Drain] Fix processing of Drain messages for High-Level and Low-level API

2022-11-03 Thread GitBox
ajothomas commented on code in PR #1639: URL: https://github.com/apache/samza/pull/1639#discussion_r1013123456 ## samza-core/src/main/java/org/apache/samza/container/RunLoop.java: ## @@ -875,49 +876,40 @@ private boolean shouldDrain() { return false; } - i

[GitHub] [samza] ajothomas commented on a diff in pull request #1639: SAMZA-2741: [Pipeline Drain] Fix processing of Drain messages for High-Level and Low-level API

2022-11-03 Thread GitBox
ajothomas commented on code in PR #1639: URL: https://github.com/apache/samza/pull/1639#discussion_r1013123301 ## samza-core/src/main/java/org/apache/samza/container/RunLoop.java: ## @@ -875,49 +876,40 @@ private boolean shouldDrain() { return false; } - i