[GitHub] [samza] alnzng commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

alnzng commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1015983431 ## samza-core/src/main/java/org/apache/samza/container/host/ProcessCPUStatistics.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [samza] alnzng commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

alnzng commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1015958371 ## samza-core/src/main/java/org/apache/samza/container/host/OshiBasedStatisticsGetter.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [samza] alnzng commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

alnzng commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1015949373 ## samza-core/src/main/java/org/apache/samza/container/host/OshiBasedStatisticsGetter.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [samza] alnzng commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

alnzng commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1015949373 ## samza-core/src/main/java/org/apache/samza/container/host/OshiBasedStatisticsGetter.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [samza] alnzng commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

alnzng commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1015949373 ## samza-core/src/main/java/org/apache/samza/container/host/OshiBasedStatisticsGetter.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [samza] alnzng commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

alnzng commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1015949373 ## samza-core/src/main/java/org/apache/samza/container/host/OshiBasedStatisticsGetter.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [samza] alnzng commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

alnzng commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1015751569 ## samza-core/src/main/java/org/apache/samza/container/host/ProcessCPUStatistics.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [samza] alnzng commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

alnzng commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1015714131 ## samza-core/src/main/java/org/apache/samza/container/host/OshiBasedStatisticsGetter.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [samza] alnzng commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

alnzng commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1015713429 ## samza-core/src/main/java/org/apache/samza/container/host/OshiBasedStatisticsGetter.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [samza] alnzng commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

alnzng commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1014527935 ## samza-core/src/main/java/org/apache/samza/container/host/PosixCommandBasedStatisticsGetter.java: ## @@ -85,4 +86,10 @@ public SystemMemoryStatistics getSystemMemoryStat

[GitHub] [samza] alnzng commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

alnzng commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1014528695 ## samza-core/src/main/scala/org/apache/samza/container/SamzaContainerMetrics.scala: ## @@ -49,6 +49,7 @@ class SamzaContainerMetrics( val executorWorkFactor = newGauge

[GitHub] [samza] alnzng commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

alnzng commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1014528695 ## samza-core/src/main/scala/org/apache/samza/container/SamzaContainerMetrics.scala: ## @@ -49,6 +49,7 @@ class SamzaContainerMetrics( val executorWorkFactor = newGauge

[GitHub] [samza] alnzng commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

alnzng commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1014527935 ## samza-core/src/main/java/org/apache/samza/container/host/PosixCommandBasedStatisticsGetter.java: ## @@ -85,4 +86,10 @@ public SystemMemoryStatistics getSystemMemoryStat

[GitHub] [samza] alnzng commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

alnzng commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1014527343 ## samza-core/src/main/java/org/apache/samza/container/host/OshiBasedStatisticsGetter.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [samza] alnzng commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

alnzng commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1014525707 ## samza-core/src/main/java/org/apache/samza/container/host/SystemStatisticsGetter.java: ## @@ -30,4 +30,11 @@ public interface SystemStatisticsGetter { * @return {@li

[GitHub] [samza] alnzng commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

alnzng commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1014525560 ## samza-core/src/main/java/org/apache/samza/container/host/SystemStatistics.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [samza] alnzng commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

alnzng commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1014525279 ## samza-core/src/main/java/org/apache/samza/container/host/StatisticsMonitorImpl.java: ## @@ -117,23 +118,23 @@ public void run() { } private void sampleStatistic

[GitHub] [samza] alnzng commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

alnzng commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1014524771 ## samza-core/src/main/java/org/apache/samza/container/host/OshiBasedStatisticsGetter.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [samza] alnzng commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

alnzng commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1014523821 ## samza-core/src/main/java/org/apache/samza/container/host/OshiBasedStatisticsGetter.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [samza] alnzng commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

alnzng commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1014523336 ## samza-core/src/main/java/org/apache/samza/container/host/OshiBasedStatisticsGetter.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [samza] alnzng commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

alnzng commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1014522272 ## samza-core/src/main/java/org/apache/samza/container/host/OshiBasedStatisticsGetter.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un