bharathkumarasubramanian commented on a change in pull request #1213: 
SAMZA-2305: Stream processor should ensure previous container is stopped during 
a rebalance
URL: https://github.com/apache/samza/pull/1213#discussion_r356233017
 
 

 ##########
 File path: 
samza-kv/src/main/scala/org/apache/samza/storage/kv/KeyValueStorageEngine.scala
 ##########
 @@ -124,7 +124,7 @@ class KeyValueStorageEngine[K, V](
     val batch = new java.util.ArrayList[Entry[Array[Byte], 
Array[Byte]]](batchSize)
     var lastBatchFlushed = false
 
-    while(iterator.hasNext) {
+    while(iterator.hasNext && !Thread.currentThread().isInterrupted) {
 
 Review comment:
   Absolutely. I added a test to verify it bails out as soon as it receives an 
interrupt.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to