rmatharu commented on a change in pull request #1147: Adding a container.maxheap.mb config to configure max heap size URL: https://github.com/apache/samza/pull/1147#discussion_r320878787
########## File path: samza-core/src/main/java/org/apache/samza/config/ClusterManagerConfig.java ########## @@ -75,6 +76,7 @@ public static final String CONTAINER_MAX_MEMORY_MB = "yarn.container.memory.mb"; public static final String CLUSTER_MANAGER_MEMORY_MB = "cluster-manager.container.memory.mb"; private static final int DEFAULT_CONTAINER_MEM = 1024; + public static final String CLUSTER_MANAGER_MAX_HEAP_MB = "cluster-manager.container.maxheap.mb"; Review comment: It would be, yes. However I realized I dont need this open source change, so am closing out this PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
