[GitHub] [samza] shanthoosh commented on issue #1079: SAMZA-2250: Support large job models in standalone.

2019-06-24 Thread GitBox
shanthoosh commented on issue #1079: SAMZA-2250: Support large job models in standalone. URL: https://github.com/apache/samza/pull/1079#issuecomment-505232922 Travis build for this patch is green, just that it is not getting updated here.

[GitHub] [samza] shanthoosh commented on issue #1079: SAMZA-2250: Support large job models in standalone.

2019-06-18 Thread GitBox
shanthoosh commented on issue #1079: SAMZA-2250: Support large job models in standalone. URL: https://github.com/apache/samza/pull/1079#issuecomment-503360594 @sborya I addressed both of your comments. Can you please take a look.

[GitHub] [samza] shanthoosh commented on issue #1079: SAMZA-2250: Support large job models in standalone.

2019-06-18 Thread GitBox
shanthoosh commented on issue #1079: SAMZA-2250: Support large job models in standalone. URL: https://github.com/apache/samza/pull/1079#issuecomment-503359306 @prateekm Added checksum to the end of metadata-value in `ZkMetadataStore`. It is used for verification during read and

[GitHub] [samza] shanthoosh commented on issue #1079: SAMZA-2250: Support large job models in standalone.

2019-06-18 Thread GitBox
shanthoosh commented on issue #1079: SAMZA-2250: Support large job models in standalone. URL: https://github.com/apache/samza/pull/1079#issuecomment-503309436 @sborya 1. I've moved the chunking logic into the zookeeper metadata store implementation. 2. I've already replied to

[GitHub] [samza] shanthoosh commented on issue #1079: SAMZA-2250: Support large job models in standalone.

2019-06-17 Thread GitBox
shanthoosh commented on issue #1079: SAMZA-2250: Support large job models in standalone. URL: https://github.com/apache/samza/pull/1079#issuecomment-502860180 @dnishimura > Do we know if batch puts would increase performance by an order of magnitude It was not a significant

[GitHub] [samza] shanthoosh commented on issue #1079: SAMZA-2250: Support large job models in standalone.

2019-06-17 Thread GitBox
shanthoosh commented on issue #1079: SAMZA-2250: Support large job models in standalone. URL: https://github.com/apache/samza/pull/1079#issuecomment-502859889 @prateekm > After leader election the job model is always the latest version? Are there special requirements around

[GitHub] [samza] shanthoosh commented on issue #1079: SAMZA-2250: Support large job models in standalone.

2019-06-13 Thread GitBox
shanthoosh commented on issue #1079: SAMZA-2250: Support large job models in standalone. URL: https://github.com/apache/samza/pull/1079#issuecomment-501934727 @prateekm Thanks for the review. 1. Segmenting the `JobModel` and storing it as independent byte array chunks will