[
https://issues.apache.org/jira/browse/SAMZA-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16172694#comment-16172694
]
Jake Maes commented on SAMZA-1420:
----------------------------------
[~xinyu] IIUC, this isn't really a problem with the merge script.
The merge script closes the PR using keywords, but that only works on the
default branch (master):
https://help.github.com/articles/closing-issues-using-keywords/
> merge-pull-request.py doesn't close PR if the commit is on a branch
> -------------------------------------------------------------------
>
> Key: SAMZA-1420
> URL: https://issues.apache.org/jira/browse/SAMZA-1420
> Project: Samza
> Issue Type: Bug
> Affects Versions: 0.14.0
> Reporter: Xinyu Liu
> Priority: Minor
>
> When using merge-pull-request.py to commit changes on 0.14.0 branch, the
> patch is successfully committed but the corresponding pr is not closed.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
