[GitHub] coveralls commented on issue #678: [SCB-506]服务治理相关的需要事件上报

2018-05-16 Thread GitBox
coveralls commented on issue #678: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#issuecomment-384615018 [![Coverage Status](https://coveralls.io/builds/17026195/badge)](https://coveralls.io/builds/17026195) Coverage decreased

[GitHub] wujimin commented on a change in pull request #693: [SCB-548] support gracefully shutdown

2018-05-16 Thread GitBox
wujimin commented on a change in pull request #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#discussion_r188831625 ## File path: core/src/main/java/org/apache/servicecomb/core/SCBStatus.java ## @@

[GitHub] coveralls commented on issue #710: [SCB-588] Set archetypes sourceEncoding to UTF-8

2018-05-16 Thread GitBox
coveralls commented on issue #710: [SCB-588] Set archetypes sourceEncoding to UTF-8 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/710#issuecomment-389735091 [![Coverage Status](https://coveralls.io/builds/17025577/badge)](https://coveralls.io/builds/17025577)

[GitHub] wujimin commented on a change in pull request #693: [SCB-548] support gracefully shutdown

2018-05-16 Thread GitBox
wujimin commented on a change in pull request #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#discussion_r188831121 ## File path: core/src/main/java/org/apache/servicecomb/core/SCBEngine.java ## @@

[GitHub] zhengyangyong commented on a change in pull request #693: [SCB-548] support gracefully shutdown

2018-05-16 Thread GitBox
zhengyangyong commented on a change in pull request #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#discussion_r188829358 ## File path: core/src/main/java/org/apache/servicecomb/core/SCBEngine.java ##

[GitHub] codecov-io commented on issue #352: SCB-393 Retry to request etcd too frequently when fail

2018-05-16 Thread GitBox
codecov-io commented on issue #352: SCB-393 Retry to request etcd too frequently when fail URL: https://github.com/apache/incubator-servicecomb-service-center/pull/352#issuecomment-389732060 #

[GitHub] coveralls commented on issue #352: SCB-393 Retry to request etcd too frequently when fail

2018-05-16 Thread GitBox
coveralls commented on issue #352: SCB-393 Retry to request etcd too frequently when fail URL: https://github.com/apache/incubator-servicecomb-service-center/pull/352#issuecomment-389720468 [![Coverage

[GitHub] zhengyangyong opened a new pull request #710: [SCB-588] Set archetypes sourceEncoding to UTF-8

2018-05-16 Thread GitBox
zhengyangyong opened a new pull request #710: [SCB-588] Set archetypes sourceEncoding to UTF-8 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/710 Signed-off-by: zhengyangyong Follow this checklist to help us incorporate your

[GitHub] wujimin commented on a change in pull request #693: [SCB-548] support gracefully shutdown

2018-05-16 Thread GitBox
wujimin commented on a change in pull request #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#discussion_r188827460 ## File path: core/src/main/java/org/apache/servicecomb/core/SCBEngine.java ## @@

[GitHub] liubao68 commented on a change in pull request #704: [SCB-582]Provide a way to protect instance removal

2018-05-16 Thread GitBox
liubao68 commented on a change in pull request #704: [SCB-582]Provide a way to protect instance removal URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/704#discussion_r188826558 ## File path:

[GitHub] liubao68 commented on a change in pull request #704: [SCB-582]Provide a way to protect instance removal

2018-05-16 Thread GitBox
liubao68 commented on a change in pull request #704: [SCB-582]Provide a way to protect instance removal URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/704#discussion_r188826558 ## File path:

[GitHub] wujimin commented on a change in pull request #702: [SCB-580] fix response of the upload file too large

2018-05-16 Thread GitBox
wujimin commented on a change in pull request #702: [SCB-580] fix response of the upload file too large URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/702#discussion_r188826253 ## File path:

[GitHub] coveralls commented on issue #352: SCB-393 Retry to request etcd too frequently when fail

2018-05-16 Thread GitBox
coveralls commented on issue #352: SCB-393 Retry to request etcd too frequently when fail URL: https://github.com/apache/incubator-servicecomb-service-center/pull/352#issuecomment-389720468 [![Coverage

[GitHub] wujimin commented on a change in pull request #704: [SCB-582]Provide a way to protect instance removal

2018-05-16 Thread GitBox
wujimin commented on a change in pull request #704: [SCB-582]Provide a way to protect instance removal URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/704#discussion_r188819940 ## File path:

[GitHub] little-cui opened a new pull request #352: SCB-393 Retry to request etcd too frequently when fail

2018-05-16 Thread GitBox
little-cui opened a new pull request #352: SCB-393 Retry to request etcd too frequently when fail URL: https://github.com/apache/incubator-servicecomb-service-center/pull/352 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there

[GitHub] wujimin commented on a change in pull request #709: [SCB-587] Fix archetypes readme

2018-05-16 Thread GitBox
wujimin commented on a change in pull request #709: [SCB-587] Fix archetypes readme URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/709#discussion_r188818126 ## File path: archetypes/README.md ## @@ -46,6 +46,7 @@ mvn archetype:generate

[GitHub] zhengyangyong commented on a change in pull request #709: [SCB-587] Fix archetypes readme

2018-05-16 Thread GitBox
zhengyangyong commented on a change in pull request #709: [SCB-587] Fix archetypes readme URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/709#discussion_r188814722 ## File path: archetypes/README.md ## @@ -46,6 +46,7 @@ mvn archetype:generate

[GitHub] little-cui closed pull request #350: SCB-581 static data return instance count by domain

2018-05-16 Thread GitBox
little-cui closed pull request #350: SCB-581 static data return instance count by domain URL: https://github.com/apache/incubator-servicecomb-service-center/pull/350 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] wujimin commented on a change in pull request #709: [SCB-587] Fix archetypes readme

2018-05-16 Thread GitBox
wujimin commented on a change in pull request #709: [SCB-587] Fix archetypes readme URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/709#discussion_r188812151 ## File path: archetypes/README.md ## @@ -46,6 +46,7 @@ mvn archetype:generate

[GitHub] wuzunqian commented on a change in pull request #185: [SCB-245]: add acceptance test for dubbo demo

2018-05-16 Thread GitBox
wuzunqian commented on a change in pull request #185: [SCB-245]: add acceptance test for dubbo demo URL: https://github.com/apache/incubator-servicecomb-saga/pull/185#discussion_r188628445 ## File path:

[GitHub] coveralls commented on issue #709: [SCB-587] Fix archetypes readme

2018-05-16 Thread GitBox
coveralls commented on issue #709: [SCB-587] Fix archetypes readme URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/709#issuecomment-389490999 [![Coverage Status](https://coveralls.io/builds/17010314/badge)](https://coveralls.io/builds/17010314) Coverage

[GitHub] zhengyangyong opened a new pull request #709: SCB-587 Fix archetypes readme

2018-05-16 Thread GitBox
zhengyangyong opened a new pull request #709: SCB-587 Fix archetypes readme URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/709 Signed-off-by: zhengyangyong Follow this checklist to help us incorporate your contribution quickly and

[incubator-servicecomb-java-chassis] branch gh-pages updated: [SCB-585]update README.md

2018-05-16 Thread liubao
This is an automated email from the ASF dual-hosted git repository. liubao pushed a commit to branch gh-pages in repository https://gitbox.apache.org/repos/asf/incubator-servicecomb-java-chassis.git The following commit(s) were added to refs/heads/gh-pages by this push: new 51848b8

[GitHub] liubao68 closed pull request #708: [SCB-585]update README.md

2018-05-16 Thread GitBox
liubao68 closed pull request #708: [SCB-585]update README.md URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/708 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] liubao68 opened a new pull request #708: [SCB-585]update README.md

2018-05-16 Thread GitBox
liubao68 opened a new pull request #708: [SCB-585]update README.md URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/708 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA

[GitHub] coveralls commented on issue #693: [SCB-548] support gracefully shutdown

2018-05-16 Thread GitBox
coveralls commented on issue #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-387664923 [![Coverage Status](https://coveralls.io/builds/17008695/badge)](https://coveralls.io/builds/17008695)

[GitHub] liubao68 opened a new pull request #707: [SCB-585]change folder structure and add compiled pages

2018-05-16 Thread GitBox
liubao68 opened a new pull request #707: [SCB-585]change folder structure and add compiled pages URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/707 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is

[GitHub] liubao68 commented on issue #706: [SCB-585]add ServiceComb-java-chassis reference guide to gh-pages branch

2018-05-16 Thread GitBox
liubao68 commented on issue #706: [SCB-585]add ServiceComb-java-chassis reference guide to gh-pages branch URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/706#issuecomment-389453871 This is a initialization commit, so I merge it without review. We can delete this

[GitHub] zhengyangyong commented on a change in pull request #693: [SCB-548] support gracefully shutdown

2018-05-16 Thread GitBox
zhengyangyong commented on a change in pull request #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#discussion_r188557220 ## File path: core/src/main/java/org/apache/servicecomb/core/SCBEngine.java ##

[GitHub] coveralls commented on issue #705: [SCB-585]add ServiceComb-java-chassis reference guide

2018-05-16 Thread GitBox
coveralls commented on issue #705: [SCB-585]add ServiceComb-java-chassis reference guide URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/705#issuecomment-389453179 [![Coverage

[GitHub] yhs0092 commented on a change in pull request #702: [SCB-580] fix response of the upload file too large

2018-05-16 Thread GitBox
yhs0092 commented on a change in pull request #702: [SCB-580] fix response of the upload file too large URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/702#discussion_r188556614 ## File path:

[GitHub] liubao68 opened a new pull request #706: [SCB-585]add ServiceComb-java-chassis reference guide to gh-pages branch

2018-05-16 Thread GitBox
liubao68 opened a new pull request #706: [SCB-585]add ServiceComb-java-chassis reference guide to gh-pages branch URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/706 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ]

[GitHub] coveralls commented on issue #351: SCB-586 Query providers api will return null when provider is removed

2018-05-16 Thread GitBox
coveralls commented on issue #351: SCB-586 Query providers api will return null when provider is removed URL: https://github.com/apache/incubator-servicecomb-service-center/pull/351#issuecomment-389440283 [![Coverage

[GitHub] wujimin commented on a change in pull request #702: [SCB-580] fix response of the upload file too large

2018-05-16 Thread GitBox
wujimin commented on a change in pull request #702: [SCB-580] fix response of the upload file too large URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/702#discussion_r188543532 ## File path:

[GitHub] codecov-io commented on issue #351: SCB-586 Query providers api will return null when provider is removed

2018-05-16 Thread GitBox
codecov-io commented on issue #351: SCB-586 Query providers api will return null when provider is removed URL: https://github.com/apache/incubator-servicecomb-service-center/pull/351#issuecomment-389440227 #

[GitHub] little-cui opened a new pull request #351: SCB-586 Query providers api will return null when provider is removed

2018-05-16 Thread GitBox
little-cui opened a new pull request #351: SCB-586 Query providers api will return null when provider is removed URL: https://github.com/apache/incubator-servicecomb-service-center/pull/351 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ]

[GitHub] coveralls commented on issue #702: [SCB-580] fix response of the upload file too large

2018-05-16 Thread GitBox
coveralls commented on issue #702: [SCB-580] fix response of the upload file too large URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/702#issuecomment-36098 [![Coverage

[GitHub] wujimin commented on a change in pull request #627: [SCB-292] chassis support standard parameter validation

2018-05-16 Thread GitBox
wujimin commented on a change in pull request #627: [SCB-292] chassis support standard parameter validation URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/627#discussion_r188527793 ## File path:

[GitHub] liubao68 opened a new pull request #705: [SCB-585]add ServiceComb-java-chassis reference guide

2018-05-16 Thread GitBox
liubao68 opened a new pull request #705: [SCB-585]add ServiceComb-java-chassis reference guide URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/705 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a

[GitHub] yhs0092 commented on a change in pull request #702: [SCB-580] fix response of the upload file too large

2018-05-16 Thread GitBox
yhs0092 commented on a change in pull request #702: [SCB-580] fix response of the upload file too large URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/702#discussion_r188522352 ## File path:

[GitHub] coveralls commented on issue #704: [SCB-582]Provide a way to protect instance removal

2018-05-16 Thread GitBox
coveralls commented on issue #704: [SCB-582]Provide a way to protect instance removal URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/704#issuecomment-389173534 [![Coverage

[GitHub] liubao68 commented on issue #704: [SCB-582]Provide a way to protect instance removal

2018-05-16 Thread GitBox
liubao68 commented on issue #704: [SCB-582]Provide a way to protect instance removal URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/704#issuecomment-389408719 Change the behavior to only protect empty instances and make this behavior on default.