[GitHub] [servicecomb-service-center] fuziye01 commented on a change in pull request #773: Syncer optimization: replace slice with channel in the implemention of queue

2020-12-04 Thread GitBox
fuziye01 commented on a change in pull request #773: URL: https://github.com/apache/servicecomb-service-center/pull/773#discussion_r535905431 ## File path: syncer/server/server.go ## @@ -313,96 +305,51 @@ func (s *Server) addToQueue(event *dump.WatchInstanceChangedEvent) {

[GitHub] [servicecomb-service-center] fuziye01 commented on a change in pull request #773: Syncer optimization: replace slice with channel in the implemention of queue

2020-12-04 Thread GitBox
fuziye01 commented on a change in pull request #773: URL: https://github.com/apache/servicecomb-service-center/pull/773#discussion_r535905431 ## File path: syncer/server/server.go ## @@ -313,96 +305,51 @@ func (s *Server) addToQueue(event *dump.WatchInstanceChangedEvent) {

[GitHub] [servicecomb-service-center] fuziye01 commented on a change in pull request #773: Syncer optimization: replace slice with channel in the implemention of queue

2020-12-03 Thread GitBox
fuziye01 commented on a change in pull request #773: URL: https://github.com/apache/servicecomb-service-center/pull/773#discussion_r535901648 ## File path: syncer/server/handler.go ## @@ -37,6 +37,7 @@ const ( EventDiscovered = "discovered" EventIncrement