[ https://issues.apache.org/jira/browse/SIS-421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Desruisseaux updated SIS-421: ------------------------------------ Description: {{DataStore}} in SIS 1.0-SNAPSHOT (June 2018) have two kind of listeners: * The {{org.apache.sis.util.logging}} package defines a {{WarningListener}} interface, together with a {{WarningListeners}} helper class. * The {{org.apache.sis.storage.event}} package defines a {{ChangeListener}} interface, together with {{ChangeEvent}} class. The intent is to have different {{ChangeEvent}} subtypes for e.g. structural changes, content changes, _etc._ We should consider renaming the later as {{StoreListener}} and {{StoreEvent}}, and define a {{WarningEvent}} class. The old {{WarningListener}} could be replaced by this new mechanism. The intent is to avoid having two listener mechanism in parallel in data stores. It seems that {{WarningListener}} are currently used only in {{DataStore}}, with the exception of {{org.apache.sis.metadata.sql}} package. So even if {{WarningEvent}} become storage-specific, it may not be a big issue. was: {{DataStore}} in SIS 1.0-SNAPSHOT (June 2018) have two kind of listeners: * The {{org.apache.sis.util.logging}} package defines a {{WarningListener}} interface, together with a {{WarningListeners}} helper class. * The {{org.apache.sis.storage.event}} package defines a {{ChangeListener}} interface, together with {{ChangeEvent}} class. The intent is to have different {{ChangeEvent}} subtypes for e.g. structural changes, content changes, _etc._ We should consider renaming the later is {{StoreListener}} and {{StoreEvent}}, and define a {{WarningEvent}} class. The old {{WarningListener}} could be replaced by this new mechanism. The intent is to avoid having two listener mechanism in parallel in data stores. It seems that {{WarningListener}} are currently used only in {{DataStore}}, with the exception of {{org.apache.sis.metadata.sql}} package. So even if {{WarningEvent}} become storage-specific, it may not be a big issue. > Retrofit WarningListener in a more generic EventListener > -------------------------------------------------------- > > Key: SIS-421 > URL: https://issues.apache.org/jira/browse/SIS-421 > Project: Spatial Information Systems > Issue Type: Improvement > Components: Storage, Utilities > Affects Versions: 0.8 > Reporter: Martin Desruisseaux > Assignee: Martin Desruisseaux > Priority: Major > Fix For: 1.0 > > > {{DataStore}} in SIS 1.0-SNAPSHOT (June 2018) have two kind of listeners: > * The {{org.apache.sis.util.logging}} package defines a {{WarningListener}} > interface, together with a {{WarningListeners}} helper class. > * The {{org.apache.sis.storage.event}} package defines a {{ChangeListener}} > interface, together with {{ChangeEvent}} class. The intent is to have > different {{ChangeEvent}} subtypes for e.g. structural changes, content > changes, _etc._ > We should consider renaming the later as {{StoreListener}} and > {{StoreEvent}}, and define a {{WarningEvent}} class. The old > {{WarningListener}} could be replaced by this new mechanism. The intent is to > avoid having two listener mechanism in parallel in data stores. > It seems that {{WarningListener}} are currently used only in {{DataStore}}, > with the exception of {{org.apache.sis.metadata.sql}} package. So even if > {{WarningEvent}} become storage-specific, it may not be a big issue. -- This message was sent by Atlassian Jira (v8.3.2#803003)