SLIDER-390 interpret short lived threshold as seconds instead of milliseconds
Project: http://git-wip-us.apache.org/repos/asf/incubator-slider/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-slider/commit/b0b7bd38 Tree: http://git-wip-us.apache.org/repos/asf/incubator-slider/tree/b0b7bd38 Diff: http://git-wip-us.apache.org/repos/asf/incubator-slider/diff/b0b7bd38 Branch: refs/heads/feature/SLIDER-149_Support_a_YARN_service_registry Commit: b0b7bd38542ed287415066d0215c6fda8786336e Parents: 201686e Author: Billie Rinaldi <billie.rina...@gmail.com> Authored: Wed Sep 3 08:38:52 2014 -0700 Committer: Billie Rinaldi <billie.rina...@gmail.com> Committed: Wed Sep 3 08:38:52 2014 -0700 ---------------------------------------------------------------------- .../java/org/apache/slider/server/appmaster/state/AppState.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-slider/blob/b0b7bd38/slider-core/src/main/java/org/apache/slider/server/appmaster/state/AppState.java ---------------------------------------------------------------------- diff --git a/slider-core/src/main/java/org/apache/slider/server/appmaster/state/AppState.java b/slider-core/src/main/java/org/apache/slider/server/appmaster/state/AppState.java index 8b70185..dce48d1 100644 --- a/slider-core/src/main/java/org/apache/slider/server/appmaster/state/AppState.java +++ b/slider-core/src/main/java/org/apache/slider/server/appmaster/state/AppState.java @@ -1227,7 +1227,7 @@ public class AppState { /** * Is a role short lived by the threshold set for this application * @param instance instance - * @return true if the instance is considered short live + * @return true if the instance is considered short lived */ @VisibleForTesting public boolean isShortLived(RoleInstance instance) { @@ -1236,7 +1236,7 @@ public class AppState { boolean shortlived; if (started > 0) { long duration = time - started; - shortlived = duration < startTimeThreshold; + shortlived = duration < (startTimeThreshold * 1000); } else { // never even saw a start event shortlived = true;
