Author: stevel
Date: Wed Jan  6 15:58:21 2016
New Revision: 1723354

URL: http://svn.apache.org/viewvc?rev=1723354&view=rev
Log:
SLIDER-1014 vote result messages now add a comment property —with example

Modified:
    incubator/slider/site/trunk/content/developing/releasing.md
    
incubator/slider/site/trunk/content/docs/slider_specs/application_pkg_upgrade.md

Modified: incubator/slider/site/trunk/content/developing/releasing.md
URL: 
http://svn.apache.org/viewvc/incubator/slider/site/trunk/content/developing/releasing.md?rev=1723354&r1=1723353&r2=1723354&view=diff
==============================================================================
--- incubator/slider/site/trunk/content/developing/releasing.md (original)
+++ incubator/slider/site/trunk/content/developing/releasing.md Wed Jan  6 
15:58:21 2016
@@ -419,6 +419,14 @@ Add all the results as release propertie
     vote.result.negative=0
     vote.result.positive=0
     vote.result.zero=0
+    vote.result.comment=(any other commentary, half votes, etc)
+
+If there aren't any non-binding votes, you can skip listing the totals; the
+binding values will propagate over. Once non-binding results come in, you
+need to increment both of the fields with every binding vote.
+
+The `vote.result.comment` property is for any optional text to be
+included in the results.
 
 ### Generate the result message
 
@@ -475,8 +483,19 @@ Record the vote into `vote.incubator.res
     vote.incubator.result.positive.binding=0
     vote.incubator.result.zero.binding=0
     vote.incubator.result.negative.binding=0
+    vote.incubator.result.positive=0
+    vote.incubator.result.zero=0
+    vote.incubator.result.negative=0
+    vote.incubator.result.comment=(any other commentary, half votes, etc)
+
+If there aren't any non-binding votes, you can skip listing the totals; the
+binding values will propagate over. Once non-binding results come in, you
+need to increment both of the fields with every binding vote.
+
+The `vote.incubator.result.comment` property is for any optional text to be
+included in the results.
 
-Then create the release message
+Then: create the release message
 
     ant -f bin/release.xml generate-incubator-result-message
 
@@ -491,6 +510,7 @@ If the vote failed,
 1. repeat the entire release process from *Build and Release to Nexus and SVN*.
 
 ### Commit the final svn release
+
 Assuming the vote succeeded, you can now commit the artifacts
 
     ant -f bin/release.xml svn-release-final-artifacts
@@ -553,14 +573,23 @@ Here is the final `release.properties` f
     release.jira.version=12334370
     release.rc.suffix=-RC1
     svn.publish.dir=/Users/stevel/Projects/Apache/slider-dist
-    nexus.staging.repository=orgapacheslider-1013
     git.release.branch=branches/branch-0.90
+    git.version=9bb379f83c78b61aeb4110b93796bc02c08c4226
+    nexus.staging.repository=orgapacheslider-1013
+
     vote.result.positive.binding=3
     vote.result.zero.binding=0
     vote.result.negative.binding=0
+    vote.result.comment=
+
     
mail.vote.thread=http://mail-archives.apache.org/mod_mbox/incubator-slider-dev/201512.mbox/%3C7EBD312A-E115-4A99-AAE7-1BF553E3B28D%40hortonworks.com%3E
     
mail.vote.result.thread=http://mail-archives.apache.org/mod_mbox/incubator-slider-dev/201601.mbox/%3CC28233B7-9016-44F4-9A6B-1EBC8BFCDF08%40hortonworks.com%3E
 
+    vote.incubator.result.positive.binding=4
+    vote.incubator.result.zero.binding=0
+    vote.incubator.result.negative.binding=0
+    vote.incubator.result.comment=(and a +0.5 vote from Daniel Gruno)
+
 ### How to clean up after a failed/cancelled vote
 
 If a vote fails you must:
@@ -578,14 +607,14 @@ If a vote fails you must:
 1. The maven `package` and `deploy` operations both rebuild their artifacts;
 if you re-run them between stages they may produce different artifacts.
 
-1. (you can set the property `git.version` if you wish to build a vote message
+1. You can set the property `git.version` if you wish to build a vote message
 from a different git version from the current build, but as you must
 be calling for a vote on the version released, only do this if you are 
modifying
-the `release.xml` release file)`
+the `release.xml` release file)
 
 1. You can create the `release.properties` file elsewhere and point to it via 
the
 ant `release.properties` property option. 
-This would need to be set in `build.properties` or on the command line
+This would need to be set in `build.properties` or on the command line.
 
         ant -f bin/release.xml -Drelease.properties=~/release.properties
 
@@ -618,7 +647,7 @@ Slider release.
 * [ASF release guidelines](http://www.apache.org/dev/release.html)
 * [Publishing Releases](http://www.apache.org/dev/release-publishing.html)
 * [ASF guide to publishing maven 
artifacts](http://www.apache.org/dev/publishing-maven-artifacts.html)
-* 
[https://wiki.apache.org/commons/UsingNexus](https://wiki.apache.org/commons/UsingNexus)
-* [git flow](http://danielkummer.github.io/git-flow-cheatsheet/)
+* [UsingNexus](https://wiki.apache.org/commons/UsingNexus)
+* [ASF signing guidelines](http://www.apache.org/dev/release-signing.html)
 
 

Modified: 
incubator/slider/site/trunk/content/docs/slider_specs/application_pkg_upgrade.md
URL: 
http://svn.apache.org/viewvc/incubator/slider/site/trunk/content/docs/slider_specs/application_pkg_upgrade.md?rev=1723354&r1=1723353&r2=1723354&view=diff
==============================================================================
--- 
incubator/slider/site/trunk/content/docs/slider_specs/application_pkg_upgrade.md
 (original)
+++ 
incubator/slider/site/trunk/content/docs/slider_specs/application_pkg_upgrade.md
 Wed Jan  6 15:58:21 2016
@@ -38,19 +38,23 @@ Automated application package upgrade wi
 ## Phases of Upgrade/Downgrade
 
 #### YARN core (libraries and configurations) upgrade/downgrade
-    Running Slider apps will continue to run, with no 
downtime
+
+Running Slider apps will continue to run, with no downtime
 
 #### Slider client upgrade/downgrade
-    Does not affect running Slider apps at all. New 
version of client can co-exist with older versions of client.
+    
+Does not affect running Slider apps at all. New version of client can co-exist 
with older versions of client.
 
 #### Slider Application Master upgrade/downgrade of running applications
-    Applications started prior to the start of YARN core 
upgrade/downgrade, will continue to run with the 
+
+Applications started prior to the start of YARN core upgrade/downgrade, will 
continue to run with the 
 older versions of Slider core and Hadoop libraries. There is no support for 
rolling upgrade of Slider AM.
 To upgrade running Slider AMs, the application needs to be stopped and 
restarted with the new version
 of the client.
 
 #### Applications deployed by Slider (binaries and configurations) 
upgrade/downgrade
-    This is what this document is primarily about.
+
+This is what this document is primarily about.
 
 ## Rolling Upgrade of Applications Deployed by Slider
 
@@ -181,7 +185,7 @@ Downgrade is done when the following com
 ## Pre and post upgrade hooks
 
 ### Pre-upgrade hook (optional)
-    The pre-upgrade steps, if provided, will allow 
applications to execute simple housekeeping tasks 
+    The pre-upgrade steps, if provided, will allow applications to execute 
simple housekeeping tasks 
 before Slider actually calls stop operation in an upgrade scenario 
(specifically if they need to 
 be performed in every single container and 1000s of them are running). An 
example could be to 
 send a message to a queue that the current instance of memcached is going down 
so that the load 
@@ -192,13 +196,13 @@ pre-upgrade hook is not a good candidate
 to be exposed, like timeout, which can be used to wait at most n seconds (say) 
after which Slider 
 will call the application stop hook even if the pre-upgrade operation is not 
completed.
 
-    Use 
`app-packages/hbase/package/scripts/hbase_master.py` as a sample for defining 
the 
+    Use `app-packages/hbase/package/scripts/hbase_master.py` as a sample for 
defining the 
 pre-upgrade hook. Note, the pre-upgrade hook will be triggered only if the 
currently running
 application has been created using Slider verion `0.80.0-incubating` or later 
and the scripts
 in the package has the pre-upgrade hook defined.
 
 ### Post-upgrade hook (optional) - `not yet supported`
-    This allows applications to perform simple 
housekeeping tasks prior to calling start on the new 
+    This allows applications to perform simple housekeeping tasks prior to 
calling start on the new 
 version of the application component. This is helpful only if such tasks are 
required to be 
 performed in every single container and 1000s of them are running. This hook 
will be triggered only in the 
 upgrade scenario. It will not be called on new containers created using flex 
up, in non-upgrade 


Reply via email to