This is an automated email from the ASF dual-hosted git repository.
gurwls223 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 7b5dd157197 [MINOR][BUILD] Remove scala-2.13 profile for Scalafmt in
lint-scala script
7b5dd157197 is described below
commit 7b5dd1571977f54557020456769aeec9f9ae7f66
Author: Hyukjin Kwon <gurwls...@apache.org>
AuthorDate: Thu Nov 23 14:34:41 2023 +0900
[MINOR][BUILD] Remove scala-2.13 profile for Scalafmt in lint-scala script
### What changes were proposed in this pull request?
Running:
```
./build/mvn -Pscala-2.13 scalafmt:format -Dscalafmt.skip=false
-Dscalafmt.validateOnly=false -Dscalafmt.changedOnly=false -pl
connector/connect/common -pl connector/connect/server -pl
connector/connect/client/jvm
```
shows a warning:
```
[WARNING] The requested profile "scala-2.13" could not be activated because
it does not exist.
```
This PR proposes to remove Scala flag in the output message at
`dev/lint-scala` script abotu scalafmt.
### Why are the changes needed?
To remove the warning.
### Does this PR introduce _any_ user-facing change?
No, dev-only.
### How was this patch tested?
Manually tested the generated command:
```bash
./build/mvn scalafmt:format -Dscalafmt.skip=false
-Dscalafmt.validateOnly=false -Dscalafmt.changedOnly=false -pl
connector/connect/common -pl connector/connect/server -pl
connector/connect/client/jvm
```
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes #43969 from HyukjinKwon/minor-error-scalafmt.
Authored-by: Hyukjin Kwon <gurwls...@apache.org>
Signed-off-by: Hyukjin Kwon <gurwls...@apache.org>
---
dev/lint-scala | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dev/lint-scala b/dev/lint-scala
index 7937aa68f2e..6b3178312c1 100755
--- a/dev/lint-scala
+++ b/dev/lint-scala
@@ -38,7 +38,7 @@ ERRORS=$(./build/mvn \
if test ! -z "$ERRORS"; then
echo -e "The scalafmt check failed on connector/connect at following
occurrences:\n\n$ERRORS\n"
echo "Before submitting your change, please make sure to format your code
using the following command:"
- echo "./build/mvn -Pscala-2.13 scalafmt:format -Dscalafmt.skip=false
-Dscalafmt.validateOnly=false -Dscalafmt.changedOnly=false -pl
connector/connect/common -pl connector/connect/server -pl
connector/connect/client/jvm"
+ echo "./build/mvn scalafmt:format -Dscalafmt.skip=false
-Dscalafmt.validateOnly=false -Dscalafmt.changedOnly=false -pl
connector/connect/common -pl connector/connect/server -pl
connector/connect/client/jvm"
exit 1
else
echo -e "Scalafmt checks passed."
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org
