This is an automated email from the ASF dual-hosted git repository.
ruifengz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new cae2248bc13d [MINOR][PYTHON][TESTS] Move test
`test_named_arguments_negative` to `test_arrow_python_udf`
cae2248bc13d is described below
commit cae2248bc13d8bde7c48a1d7479df68bcd31fbf1
Author: Ruifeng Zheng <ruife...@apache.org>
AuthorDate: Mon May 13 11:09:44 2024 +0800
[MINOR][PYTHON][TESTS] Move test `test_named_arguments_negative` to
`test_arrow_python_udf`
### What changes were proposed in this pull request?
Move test `test_named_arguments_negative` to `test_arrow_python_udf`
### Why are the changes needed?
it seems was added in a wrong place, it only runs in Spark Connect, not
Spark Classic.
After this PR, it will also be run in Spark Classic
### Does this PR introduce _any_ user-facing change?
no, test only
### How was this patch tested?
ci
### Was this patch authored or co-authored using generative AI tooling?
no
Closes #46544 from zhengruifeng/move_test_named_arguments_negative.
Authored-by: Ruifeng Zheng <ruife...@apache.org>
Signed-off-by: Ruifeng Zheng <ruife...@apache.org>
---
.../tests/connect/test_parity_arrow_python_udf.py | 26 ----------------------
python/pyspark/sql/tests/test_arrow_python_udf.py | 24 +++++++++++++++++++-
2 files changed, 23 insertions(+), 27 deletions(-)
diff --git a/python/pyspark/sql/tests/connect/test_parity_arrow_python_udf.py
b/python/pyspark/sql/tests/connect/test_parity_arrow_python_udf.py
index fa329b598d98..732008eb05a3 100644
--- a/python/pyspark/sql/tests/connect/test_parity_arrow_python_udf.py
+++ b/python/pyspark/sql/tests/connect/test_parity_arrow_python_udf.py
@@ -15,10 +15,6 @@
# limitations under the License.
#
-import unittest
-
-from pyspark.errors import AnalysisException, PythonException
-from pyspark.sql.functions import udf
from pyspark.sql.tests.connect.test_parity_udf import UDFParityTests
from pyspark.sql.tests.test_arrow_python_udf import PythonUDFArrowTestsMixin
@@ -36,28 +32,6 @@ class ArrowPythonUDFParityTests(UDFParityTests,
PythonUDFArrowTestsMixin):
finally:
super(ArrowPythonUDFParityTests, cls).tearDownClass()
- def test_named_arguments_negative(self):
- @udf("int")
- def test_udf(a, b):
- return a + b
-
- self.spark.udf.register("test_udf", test_udf)
-
- with self.assertRaisesRegex(
- AnalysisException,
-
"DUPLICATE_ROUTINE_PARAMETER_ASSIGNMENT.DOUBLE_NAMED_ARGUMENT_REFERENCE",
- ):
- self.spark.sql("SELECT test_udf(a => id, a => id * 10) FROM
range(2)").show()
-
- with self.assertRaisesRegex(AnalysisException,
"UNEXPECTED_POSITIONAL_ARGUMENT"):
- self.spark.sql("SELECT test_udf(a => id, id * 10) FROM
range(2)").show()
-
- with self.assertRaises(PythonException):
- self.spark.sql("SELECT test_udf(c => 'x') FROM range(2)").show()
-
- with self.assertRaises(PythonException):
- self.spark.sql("SELECT test_udf(id, a => id * 10) FROM
range(2)").show()
-
if __name__ == "__main__":
import unittest
diff --git a/python/pyspark/sql/tests/test_arrow_python_udf.py
b/python/pyspark/sql/tests/test_arrow_python_udf.py
index 23f302ec3c8d..5a66d61cb66a 100644
--- a/python/pyspark/sql/tests/test_arrow_python_udf.py
+++ b/python/pyspark/sql/tests/test_arrow_python_udf.py
@@ -17,7 +17,7 @@
import unittest
-from pyspark.errors import PythonException, PySparkNotImplementedError
+from pyspark.errors import AnalysisException, PythonException,
PySparkNotImplementedError
from pyspark.sql import Row
from pyspark.sql.functions import udf
from pyspark.sql.tests.test_udf import BaseUDFTestsMixin
@@ -197,6 +197,28 @@ class PythonUDFArrowTestsMixin(BaseUDFTestsMixin):
" without arguments.",
)
+ def test_named_arguments_negative(self):
+ @udf("int")
+ def test_udf(a, b):
+ return a + b
+
+ self.spark.udf.register("test_udf", test_udf)
+
+ with self.assertRaisesRegex(
+ AnalysisException,
+
"DUPLICATE_ROUTINE_PARAMETER_ASSIGNMENT.DOUBLE_NAMED_ARGUMENT_REFERENCE",
+ ):
+ self.spark.sql("SELECT test_udf(a => id, a => id * 10) FROM
range(2)").show()
+
+ with self.assertRaisesRegex(AnalysisException,
"UNEXPECTED_POSITIONAL_ARGUMENT"):
+ self.spark.sql("SELECT test_udf(a => id, id * 10) FROM
range(2)").show()
+
+ with self.assertRaises(PythonException):
+ self.spark.sql("SELECT test_udf(c => 'x') FROM range(2)").show()
+
+ with self.assertRaises(PythonException):
+ self.spark.sql("SELECT test_udf(id, a => id * 10) FROM
range(2)").show()
+
class PythonUDFArrowTests(PythonUDFArrowTestsMixin, ReusedSQLTestCase):
@classmethod
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org
