This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 24d17e04d984 [SPARK-37434][TESTS] Disable unsupported
`ExtendedLevelDBTest` on `MacOS/aarch64`
24d17e04d984 is described below
commit 24d17e04d9844fd1611e48b34dbebd4ceffc7de4
Author: yangjie01 <yangji...@baidu.com>
AuthorDate: Mon Feb 19 16:09:42 2024 -0800
[SPARK-37434][TESTS] Disable unsupported `ExtendedLevelDBTest` on
`MacOS/aarch64`
### What changes were proposed in this pull request?
This supercedes #34676 with the original authorship, LuciferYang .
```
$ git log -n1
commit 561fb2968c188e002d5333469a9a5c02c08b8ab2 (HEAD -> SPARK-37434,
dongjoon/SPARK-37434)
Author: yangjie01 <yangjie01baidu.com>
Date: Mon Feb 19 13:38:18 2024 -0800
[SPARK-37434][TESTS] Disable unsupported `ExtendedLevelDBTest` on
`MacOS/aarch64`
```
### Why are the changes needed?
#34676 initially proposed to disable both `LevelDB` and `RocksDB` related
tests.
Now, we have `RocksDB` by default which supports all environments.
`LevelDB` code will be tested in the same way like before.
In short, there is no test coverage loss.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass the CIs and manual tests.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes #45170 from dongjoon-hyun/SPARK-37434.
Authored-by: yangjie01 <yangji...@baidu.com>
Signed-off-by: Dongjoon Hyun <dh...@apple.com>
---
pom.xml | 14 +++++++++++++-
project/SparkBuild.scala | 6 +++++-
2 files changed, 18 insertions(+), 2 deletions(-)
diff --git a/pom.xml b/pom.xml
index 427a68f29e14..9142fdbd3a98 100644
--- a/pom.xml
+++ b/pom.xml
@@ -3771,7 +3771,7 @@
<profile>
<id>sparkr</id>
</profile>
- <!-- use org.openlabtesting.leveldbjni on aarch64 platform -->
+ <!-- use org.openlabtesting.leveldbjni on aarch64 platform except MacOS -->
<profile>
<id>aarch64</id>
<properties>
@@ -3784,6 +3784,18 @@
</os>
</activation>
</profile>
+ <profile>
+ <id>applesilicon</id>
+ <properties>
+
<test.default.exclude.tags>org.apache.spark.tags.ChromeUITest,org.apache.spark.tags.ExtendedLevelDBTest</test.default.exclude.tags>
+ </properties>
+ <activation>
+ <os>
+ <family>mac</family>
+ <arch>aarch64</arch>
+ </os>
+ </activation>
+ </profile>
<profile>
<id>jdwp-test-debug</id>
<properties>
diff --git a/project/SparkBuild.scala b/project/SparkBuild.scala
index 24e2c814f99f..3304735dfa79 100644
--- a/project/SparkBuild.scala
+++ b/project/SparkBuild.scala
@@ -1515,7 +1515,11 @@ object TestSettings {
import BuildCommons._
private val defaultExcludedTags = Seq("org.apache.spark.tags.ChromeUITest",
"org.apache.spark.deploy.k8s.integrationtest.YuniKornTag",
- "org.apache.spark.internal.io.cloud.IntegrationTestSuite")
+ "org.apache.spark.internal.io.cloud.IntegrationTestSuite") ++
+ (if (System.getProperty("os.name").startsWith("Mac OS X") &&
+ System.getProperty("os.arch").equals("aarch64")) {
+ Seq("org.apache.spark.tags.ExtendedLevelDBTest")
+ } else Seq.empty)
lazy val settings = Seq (
// Fork new JVMs for tests and set Java options for those
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org
