Re: [PR] Add Spark Connect page [spark-website]

2024-04-03 Thread via GitHub
srowen commented on code in PR #511: URL: https://github.com/apache/spark-website/pull/511#discussion_r1549627462 ## spark-connect/index.md: ## @@ -0,0 +1,151 @@ +--- +layout: global +type: "page singular" +title: Spark Connect +description: Spark Connect makes remote Spark deve

Re: [PR] Add Spark Connect page [spark-website]

2024-04-03 Thread via GitHub
srowen commented on code in PR #511: URL: https://github.com/apache/spark-website/pull/511#discussion_r1549628247 ## spark-connect/index.md: ## @@ -0,0 +1,151 @@ +--- +layout: global +type: "page singular" +title: Spark Connect +description: Spark Connect makes remote Spark deve

Re: [PR] Add Spark Connect page [spark-website]

2024-04-02 Thread via GitHub
dongjoon-hyun commented on code in PR #511: URL: https://github.com/apache/spark-website/pull/511#discussion_r1548892591 ## spark-connect/index.md: ## @@ -0,0 +1,151 @@ +--- +layout: global +type: "page singular" +title: Spark Connect +description: Spark Connect makes remote Spa

Re: [PR] Add Spark Connect page [spark-website]

2024-04-02 Thread via GitHub
dongjoon-hyun commented on code in PR #511: URL: https://github.com/apache/spark-website/pull/511#discussion_r1548892050 ## spark-connect/index.md: ## @@ -0,0 +1,151 @@ +--- +layout: global +type: "page singular" +title: Spark Connect +description: Spark Connect makes remote Spa

Re: [PR] Add Spark Connect page [spark-website]

2024-04-02 Thread via GitHub
MrPowers commented on PR #511: URL: https://github.com/apache/spark-website/pull/511#issuecomment-2033318574 Thank you for the review @dongjoon-hyun. This pull request was merged, so I will address your comments in another PR. I really appreciate your feedback. -- This is an automated m

Re: [PR] Add Spark Connect page [spark-website]

2024-04-02 Thread via GitHub
MrPowers commented on code in PR #511: URL: https://github.com/apache/spark-website/pull/511#discussion_r1548753924 ## spark-connect/index.md: ## @@ -0,0 +1,151 @@ +--- +layout: global +type: "page singular" +title: Spark Connect +description: Spark Connect makes remote Spark de

Re: [PR] Add Spark Connect page [spark-website]

2024-04-02 Thread via GitHub
dongjoon-hyun commented on code in PR #511: URL: https://github.com/apache/spark-website/pull/511#discussion_r1548741671 ## spark-connect/index.md: ## @@ -0,0 +1,151 @@ +--- +layout: global +type: "page singular" +title: Spark Connect +description: Spark Connect makes remote Spa

Re: [PR] Add Spark Connect page [spark-website]

2024-04-02 Thread via GitHub
srowen commented on PR #511: URL: https://github.com/apache/spark-website/pull/511#issuecomment-2033256929 Merged to asf-site -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Add Spark Connect page [spark-website]

2024-04-02 Thread via GitHub
srowen closed pull request #511: Add Spark Connect page URL: https://github.com/apache/spark-website/pull/511 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [PR] Add Spark Connect page [spark-website]

2024-04-02 Thread via GitHub
MrPowers commented on PR #511: URL: https://github.com/apache/spark-website/pull/511#issuecomment-2033168687 @srowen - I rebased, good call. I could also break this up into two separate commits if that would help. Sorry for sending the massive PR. -- This is an automated message f

Re: [PR] Add Spark Connect page [spark-website]

2024-04-02 Thread via GitHub
srowen commented on PR #511: URL: https://github.com/apache/spark-website/pull/511#issuecomment-2033120138 For good measure, rebase this? I think this also include your change that was merged months ago at https://github.com/apache/spark-website/commit/a6ce63fb9c82dc8f25f42f377b487c0de2aff8

Re: [PR] Add Spark Connect page [spark-website]

2024-04-02 Thread via GitHub
MrPowers commented on PR #511: URL: https://github.com/apache/spark-website/pull/511#issuecomment-2033080398 Here's the main file that should be reviewed: https://github.com/apache/spark-website/pull/511/files#diff-65090e623c6aabb88b162b7e17e2a81dc359e84234e9fac9561340f7acd05431 -- This i

[PR] Add Spark Connect page [spark-website]

2024-04-02 Thread via GitHub
MrPowers opened a new pull request, #511: URL: https://github.com/apache/spark-website/pull/511 This PR adds a Spark Connect page. Sorry for the huge PR. This PR adds Spark Connect to the dropdown which apparently modifies a bunch of HTML files. Let me know if this is OK! htt