This is an automated email from the ASF dual-hosted git repository.

srowen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new e64c110  [MINOR][BUILD] Remove useless add-source
e64c110 is described below

commit e64c110d213a089d3f97d0aec942f7a237d861a6
Author: Yuming Wang <yumw...@ebay.com>
AuthorDate: Mon Mar 4 08:43:17 2019 -0600

    [MINOR][BUILD] Remove useless add-source
    
    ## What changes were proposed in this pull request?
    
    The source 
directory(`sql/hive-thriftserver/v${hive.version.short}/src/main/scala`) 
removed from  [SPARK-6909](https://issues.apache.org/jira/browse/SPARK-6909) 
and [SPARK-7850](https://issues.apache.org/jira/browse/SPARK-7850). We should 
also remove the `add-source`.
    It seems that removed this `add-source` makes it easier to import `src/gen` 
source code in IDEA:
    
![image](https://user-images.githubusercontent.com/5399861/53715396-a967b380-3e8c-11e9-8aa1-c59d819b4c06.png)
    
![image](https://user-images.githubusercontent.com/5399861/53715402-acfb3a80-3e8c-11e9-8aa9-a716931160c6.png)
    
    ## How was this patch tested?
    
    manual tests
    
    Closes #23949 from wangyum/SPARK-7850.
    
    Authored-by: Yuming Wang <yumw...@ebay.com>
    Signed-off-by: Sean Owen <sean.o...@databricks.com>
---
 sql/hive-thriftserver/pom.xml | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/sql/hive-thriftserver/pom.xml b/sql/hive-thriftserver/pom.xml
index 4a4629f..8aff383 100644
--- a/sql/hive-thriftserver/pom.xml
+++ b/sql/hive-thriftserver/pom.xml
@@ -121,18 +121,6 @@
         <artifactId>build-helper-maven-plugin</artifactId>
         <executions>
           <execution>
-            <id>add-default-sources</id>
-            <phase>generate-sources</phase>
-            <goals>
-              <goal>add-source</goal>
-            </goals>
-            <configuration>
-              <sources>
-                <source>v${hive.version.short}/src/main/scala</source>
-              </sources>
-            </configuration>
-          </execution>
-          <execution>
             <id>add-source</id>
             <phase>generate-sources</phase>
             <goals>


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org

Reply via email to