This is an automated email from the ASF dual-hosted git repository.
gengliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 38cdd17bc2b [SPARK-41754][UI] Add simple developer guides for UI
Protobuf serializer
38cdd17bc2b is described below
commit 38cdd17bc2bf5358d7755d1aec1788a0bba6c619
Author: Gengliang Wang <gengli...@apache.org>
AuthorDate: Fri Dec 30 13:46:00 2022 -0800
[SPARK-41754][UI] Add simple developer guides for UI Protobuf serializer
### What changes were proposed in this pull request?
* Add simple developer guides for UI Protobuf serializer.
* Rename `UNSPECIFIED` in the enum JobExecutionStatus as
`JOB_EXECUTION_STATUS_UNSPECIFIED`
### Why are the changes needed?
1. Provide a simple guide for common issues found during PR review
2. Avoid naming conflicts in enum definitions.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Existing UT
Closes #39270 from gengliangwang/addGuideline.
Authored-by: Gengliang Wang <gengli...@apache.org>
Signed-off-by: Gengliang Wang <gengli...@apache.org>
---
.../protobuf/org/apache/spark/status/protobuf/store_types.proto | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git
a/core/src/main/protobuf/org/apache/spark/status/protobuf/store_types.proto
b/core/src/main/protobuf/org/apache/spark/status/protobuf/store_types.proto
index e9150490746..bba3a494083 100644
--- a/core/src/main/protobuf/org/apache/spark/status/protobuf/store_types.proto
+++ b/core/src/main/protobuf/org/apache/spark/status/protobuf/store_types.proto
@@ -18,8 +18,15 @@
syntax = "proto3";
package org.apache.spark.status.protobuf;
+/**
+ * Developer guides:
+ * - Coding style: https://developers.google.com/protocol-buffers/docs/style
+ * - Use int64 for job/stage IDs, in case of future extension in Spark core.
+ * - Use `weakIntern` on string values in create new objects during
deserialization.
+ */
+
enum JobExecutionStatus {
- UNSPECIFIED = 0;
+ JOB_EXECUTION_STATUS_UNSPECIFIED = 0;
RUNNING = 1;
SUCCEEDED = 2;
FAILED = 3;
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org
