This is an automated email from the ASF dual-hosted git repository. dongjoon pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push: new bfad72b0a86 [SPARK-44104][BUILD] Enabled `protobuf` module mima check for Spark 3.5.0 bfad72b0a86 is described below commit bfad72b0a8689f7a3361785cc5004030bc94da3d Author: yangjie01 <yangji...@baidu.com> AuthorDate: Tue Jun 20 07:45:49 2023 -0700 [SPARK-44104][BUILD] Enabled `protobuf` module mima check for Spark 3.5.0 ### What changes were proposed in this pull request? This pr adds a mima check for the `protobuf` module for Apache Spark 3.5.0 ### Why are the changes needed? The `protobuf` module is a new module introduced in Spark 3.4.0, which includes some client APIs, so it should be added to Spark 3.5.0's mima check ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? - Pass GitHub Actions - Manual checked: ``` dev/mima ``` and ``` dev/change-scala-version.sh 2.13 dev/mima -Pscala-2.13 ``` Closes #41671 from LuciferYang/SPARK-44104. Authored-by: yangjie01 <yangji...@baidu.com> Signed-off-by: Dongjoon Hyun <dongj...@apache.org> --- project/MimaExcludes.scala | 4 ++++ project/SparkBuild.scala | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/project/MimaExcludes.scala b/project/MimaExcludes.scala index bba20534f44..7cac416838d 100644 --- a/project/MimaExcludes.scala +++ b/project/MimaExcludes.scala @@ -93,6 +93,10 @@ object MimaExcludes { ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.ErrorInfo$"), ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.ErrorSubInfo$"), + // SPARK-44104: shaded protobuf code and Apis with parameters relocated + ProblemFilters.exclude[Problem]("org.sparkproject.spark_protobuf.protobuf.*"), + ProblemFilters.exclude[Problem]("org.apache.spark.sql.protobuf.utils.SchemaConverters.*"), + (problem: Problem) => problem match { case MissingClassProblem(cls) => !cls.fullName.startsWith("org.sparkproject.jpmml") && !cls.fullName.startsWith("org.sparkproject.dmg.pmml") diff --git a/project/SparkBuild.scala b/project/SparkBuild.scala index 607daa67138..761b8f905f5 100644 --- a/project/SparkBuild.scala +++ b/project/SparkBuild.scala @@ -415,7 +415,7 @@ object SparkBuild extends PomBuild { val mimaProjects = allProjects.filterNot { x => Seq( spark, hive, hiveThriftServer, repl, networkCommon, networkShuffle, networkYarn, - unsafe, tags, tokenProviderKafka010, sqlKafka010, connectCommon, connect, connectClient, protobuf, + unsafe, tags, tokenProviderKafka010, sqlKafka010, connectCommon, connect, connectClient, commonUtils, sqlApi ).contains(x) } --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org