This is an automated email from the ASF dual-hosted git repository. dongjoon pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push: new 8e779d1af75 [SPARK-44989][INFRA] Add a directional message to promote JIRA_ACCESS_TOKEN 8e779d1af75 is described below commit 8e779d1af75ce553a6ef2fe99c6a0c45954f377d Author: Dongjoon Hyun <dh...@apple.com> AuthorDate: Mon Aug 28 11:48:10 2023 -0700 [SPARK-44989][INFRA] Add a directional message to promote JIRA_ACCESS_TOKEN ### What changes were proposed in this pull request? This PR aims to add a directional message to promote `JIRA_ACCESS_TOKEN` when `JIRA_USERNAME` and `JIRA_PASSWORD` are used. Also, this PR set the minimum JIRA library version to make it sure that `token_auths` features exist in the installed `jira` library. ``` -jira +jira>=3.5.2 ``` ### Why are the changes needed? Since SPARK-44802, `Token` feature seems to be stable and provides much secure environments to Apache Spark committers by hiding not only `JIRA_PASSWORD`, but also the static `JIRA_USERNAME`. ``` SPARK-44802 Token based ASF JIRA authentication SPARK-44802 Fix to consider JIRA_ACCESS_TOKEN in precheck conditions SPARK-44972 Eagerly check if the token is valid to align with the behavior of username/password auth ``` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manual review. ### Was this patch authored or co-authored using generative AI tooling? No, Closes #42704 from dongjoon-hyun/SPARK-44989. Authored-by: Dongjoon Hyun <dh...@apple.com> Signed-off-by: Dongjoon Hyun <dh...@apple.com> --- dev/merge_spark_pr.py | 3 +++ dev/requirements.txt | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/dev/merge_spark_pr.py b/dev/merge_spark_pr.py index 2e4b7d3a6fa..fa66d2b2021 100755 --- a/dev/merge_spark_pr.py +++ b/dev/merge_spark_pr.py @@ -538,6 +538,9 @@ def initialize_jira(): else: raise e elif JIRA_USERNAME and JIRA_PASSWORD: + print("You can use JIRA_ACCESS_TOKEN instead of JIRA_USERNAME/JIRA_PASSWORD.") + print("Visit https://issues.apache.org/jira/secure/ViewProfile.jspa ") + print("and click 'Personal Access Tokens' menu to manage your own tokens.") asf_jira = jira.client.JIRA(jira_server, basic_auth=(JIRA_USERNAME, JIRA_PASSWORD)) else: print("Neither JIRA_ACCESS_TOKEN nor JIRA_USERNAME/JIRA_PASSWORD are set.") diff --git a/dev/requirements.txt b/dev/requirements.txt index 7011b85de47..51fcb719e99 100644 --- a/dev/requirements.txt +++ b/dev/requirements.txt @@ -42,7 +42,7 @@ docutils<0.18.0 markupsafe==2.0.1 # Development scripts -jira +jira>=3.5.2 PyGithub # pandas API on Spark Code formatter. --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org