Repository: spark
Updated Branches:
  refs/heads/master 59d52631e -> 0abaf31be


[SPARK-22852][BUILD] Exclude -Xlint:unchecked from sbt javadoc flags

## What changes were proposed in this pull request?

Moves the -Xlint:unchecked flag in the sbt build configuration from Compile to 
(Compile, compile) scope, allowing publish and publishLocal commands to work.

## How was this patch tested?

Successfully published the spark-launcher subproject from within sbt 
successfully, where it fails without this patch.

Author: Erik LaBianca <erik.labia...@gmail.com>

Closes #20040 from easel/javadoc-xlint.


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/0abaf31b
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/0abaf31b
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/0abaf31b

Branch: refs/heads/master
Commit: 0abaf31be7ab9e030ea9433938b9123596954814
Parents: 59d5263
Author: Erik LaBianca <erik.labia...@gmail.com>
Authored: Thu Dec 21 09:38:21 2017 -0600
Committer: Sean Owen <so...@cloudera.com>
Committed: Thu Dec 21 09:38:21 2017 -0600

----------------------------------------------------------------------
 project/SparkBuild.scala | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/0abaf31b/project/SparkBuild.scala
----------------------------------------------------------------------
diff --git a/project/SparkBuild.scala b/project/SparkBuild.scala
index 7570338..8305494 100644
--- a/project/SparkBuild.scala
+++ b/project/SparkBuild.scala
@@ -239,14 +239,14 @@ object SparkBuild extends PomBuild {
 
     javacOptions in Compile ++= Seq(
       "-encoding", "UTF-8",
-      "-source", javacJVMVersion.value,
-      "-Xlint:unchecked"
+      "-source", javacJVMVersion.value
     ),
-    // This -target option cannot be set in the Compile configuration scope 
since `javadoc` doesn't
-    // play nicely with it; see 
https://github.com/sbt/sbt/issues/355#issuecomment-3817629 for
-    // additional discussion and explanation.
+    // This -target and Xlint:unchecked options cannot be set in the Compile 
configuration scope since
+    // `javadoc` doesn't play nicely with them; see 
https://github.com/sbt/sbt/issues/355#issuecomment-3817629
+    // for additional discussion and explanation.
     javacOptions in (Compile, compile) ++= Seq(
-      "-target", javacJVMVersion.value
+      "-target", javacJVMVersion.value,
+      "-Xlint:unchecked"
     ),
 
     scalacOptions in Compile ++= Seq(


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org

Reply via email to