This is an automated email from the ASF dual-hosted git repository. srdo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/storm.git
The following commit(s) were added to refs/heads/master by this push: new 7d45bc3 STORM-2749 Remove unimplemented setStateSpout function new 4fffbd9 Merge pull request #3143 from daisyxchen/STORM-2749 7d45bc3 is described below commit 7d45bc381c9e2b31cedd7aa113aa2829b88e8a97 Author: daisyxchen <cherrydream....@gmail.com> AuthorDate: Mon Oct 14 14:10:12 2019 -0500 STORM-2749 Remove unimplemented setStateSpout function --- .../src/jvm/org/apache/storm/topology/TopologyBuilder.java | 9 --------- .../test/jvm/org/apache/storm/topology/TopologyBuilderTest.java | 6 ------ 2 files changed, 15 deletions(-) diff --git a/storm-client/src/jvm/org/apache/storm/topology/TopologyBuilder.java b/storm-client/src/jvm/org/apache/storm/topology/TopologyBuilder.java index 63384df..c14d6fb 100644 --- a/storm-client/src/jvm/org/apache/storm/topology/TopologyBuilder.java +++ b/storm-client/src/jvm/org/apache/storm/topology/TopologyBuilder.java @@ -473,15 +473,6 @@ public class TopologyBuilder { return setSpout(id, new LambdaSpout(supplier), parallelismHint); } - public void setStateSpout(String id, IRichStateSpout stateSpout) throws IllegalArgumentException { - setStateSpout(id, stateSpout, null); - } - - public void setStateSpout(String id, IRichStateSpout stateSpout, Number parallelismHint) throws IllegalArgumentException { - validateUnusedId(id); - // TODO: finish - } - /** * Add a new worker lifecycle hook. * diff --git a/storm-client/test/jvm/org/apache/storm/topology/TopologyBuilderTest.java b/storm-client/test/jvm/org/apache/storm/topology/TopologyBuilderTest.java index 3e8a86d..47fe12f 100644 --- a/storm-client/test/jvm/org/apache/storm/topology/TopologyBuilderTest.java +++ b/storm-client/test/jvm/org/apache/storm/topology/TopologyBuilderTest.java @@ -51,12 +51,6 @@ public class TopologyBuilderTest { builder.addWorkerHook(null); } - // TODO enable if setStateSpout gets implemented - // @Test(expected = IllegalArgumentException.class) - // public void testSetStateSpout() { - // builder.setStateSpout("stateSpout", mock(IRichStateSpout.class), 0); - // } - @Test public void testStatefulTopology() { builder.setSpout("spout1", makeDummySpout());