This is an automated email from the ASF dual-hosted git repository. srdo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/storm.git
The following commit(s) were added to refs/heads/master by this push: new 4815bdc STORM-3401 Scan code quality at build time new f4e18ab Merge pull request #3019 from krichter722/checkstyle 4815bdc is described below commit 4815bdc5ca5a2f9e8f94a4e62e439b9dd8003197 Author: Karl-Philipp Richter <krich...@posteo.de> AuthorDate: Sat Jun 1 19:58:15 2019 +0200 STORM-3401 Scan code quality at build time Use Maven checkstyle and PMD plugins during build rather than reporting phase in order to make validation obligatory --- examples/storm-elasticsearch-examples/pom.xml | 4 ++++ examples/storm-hbase-examples/pom.xml | 4 ++++ examples/storm-hdfs-examples/pom.xml | 4 ++++ examples/storm-hive-examples/pom.xml | 4 ++++ examples/storm-jdbc-examples/pom.xml | 4 ++++ examples/storm-jms-examples/pom.xml | 4 ++++ examples/storm-kafka-client-examples/pom.xml | 4 ++++ examples/storm-loadgen/pom.xml | 4 ++++ examples/storm-mongodb-examples/pom.xml | 4 ++++ examples/storm-mqtt-examples/pom.xml | 4 ++++ examples/storm-opentsdb-examples/pom.xml | 4 ++++ examples/storm-perf/pom.xml | 4 ++++ examples/storm-pmml-examples/pom.xml | 4 ++++ examples/storm-redis-examples/pom.xml | 4 ++++ examples/storm-rocketmq-examples/pom.xml | 4 ++++ examples/storm-solr-examples/pom.xml | 4 ++++ examples/storm-starter/pom.xml | 4 ++++ external/storm-autocreds/pom.xml | 16 ++++++++++++++++ external/storm-blobstore-migration/pom.xml | 12 ++++++++++++ external/storm-cassandra/pom.xml | 4 ++++ external/storm-elasticsearch/pom.xml | 4 ++++ external/storm-eventhubs/pom.xml | 4 ++++ external/storm-hbase/pom.xml | 4 ++++ external/storm-hdfs-blobstore/pom.xml | 4 ++++ external/storm-hdfs/pom.xml | 4 ++++ external/storm-hive/pom.xml | 4 ++++ external/storm-jdbc/pom.xml | 4 ++++ external/storm-jms/pom.xml | 4 ++++ external/storm-kafka-client/pom.xml | 4 ++++ external/storm-kafka-migration/pom.xml | 4 ++++ external/storm-kafka-monitor/pom.xml | 4 ++++ external/storm-kinesis/pom.xml | 4 ++++ external/storm-metrics/pom.xml | 4 ++++ external/storm-mongodb/pom.xml | 4 ++++ external/storm-mqtt/pom.xml | 4 ++++ external/storm-opentsdb/pom.xml | 4 ++++ external/storm-pmml/pom.xml | 4 ++++ external/storm-redis/pom.xml | 4 ++++ external/storm-rocketmq/pom.xml | 4 ++++ external/storm-solr/pom.xml | 4 ++++ flux/flux-core/pom.xml | 4 ++++ flux/flux-examples/pom.xml | 4 ++++ flux/flux-wrappers/pom.xml | 4 ++++ flux/pom.xml | 13 +++++++++++++ integration-test/pom.xml | 12 ++++++++++++ pom.xml | 22 +++++----------------- sql/pom.xml | 13 +++++++++++++ sql/storm-sql-core/pom.xml | 4 ++++ sql/storm-sql-external/storm-sql-hdfs/pom.xml | 4 ++++ sql/storm-sql-external/storm-sql-kafka/pom.xml | 4 ++++ sql/storm-sql-external/storm-sql-mongodb/pom.xml | 4 ++++ sql/storm-sql-external/storm-sql-redis/pom.xml | 4 ++++ sql/storm-sql-runtime/pom.xml | 4 ++++ .../maven-shade-clojure-transformer/pom.xml | 4 ++++ storm-buildtools/storm-maven-plugins/pom.xml | 4 ++++ storm-client/pom.xml | 8 ++++++++ storm-clojure-test/pom.xml | 8 ++++++++ storm-clojure/pom.xml | 4 ++++ storm-core/pom.xml | 4 ++++ storm-multilang/javascript/pom.xml | 13 +++++++++++++ storm-multilang/python/pom.xml | 13 +++++++++++++ storm-multilang/ruby/pom.xml | 13 +++++++++++++ storm-server/pom.xml | 4 ++++ storm-shaded-deps/pom.xml | 8 ++++++++ storm-submit-tools/pom.xml | 4 ++++ storm-webapp/pom.xml | 4 ++++ 66 files changed, 350 insertions(+), 17 deletions(-) diff --git a/examples/storm-elasticsearch-examples/pom.xml b/examples/storm-elasticsearch-examples/pom.xml index 001c16a..d25a747 100644 --- a/examples/storm-elasticsearch-examples/pom.xml +++ b/examples/storm-elasticsearch-examples/pom.xml @@ -98,6 +98,10 @@ <maxAllowedViolations>0</maxAllowedViolations> </configuration> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> </project> diff --git a/examples/storm-hbase-examples/pom.xml b/examples/storm-hbase-examples/pom.xml index be870e0..dd733dc 100644 --- a/examples/storm-hbase-examples/pom.xml +++ b/examples/storm-hbase-examples/pom.xml @@ -90,6 +90,10 @@ <maxAllowedViolations>16</maxAllowedViolations> </configuration> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> </project> diff --git a/examples/storm-hdfs-examples/pom.xml b/examples/storm-hdfs-examples/pom.xml index 6a2161b..f1e11da 100644 --- a/examples/storm-hdfs-examples/pom.xml +++ b/examples/storm-hdfs-examples/pom.xml @@ -100,6 +100,10 @@ <maxAllowedViolations>29</maxAllowedViolations> </configuration> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> </project> diff --git a/examples/storm-hive-examples/pom.xml b/examples/storm-hive-examples/pom.xml index 1a2b81a..7fe757d 100644 --- a/examples/storm-hive-examples/pom.xml +++ b/examples/storm-hive-examples/pom.xml @@ -100,6 +100,10 @@ <maxAllowedViolations>67</maxAllowedViolations> </configuration> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> </project> diff --git a/examples/storm-jdbc-examples/pom.xml b/examples/storm-jdbc-examples/pom.xml index 6bc8bba..e3278ee 100644 --- a/examples/storm-jdbc-examples/pom.xml +++ b/examples/storm-jdbc-examples/pom.xml @@ -90,6 +90,10 @@ <maxAllowedViolations>36</maxAllowedViolations> </configuration> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> </project> diff --git a/examples/storm-jms-examples/pom.xml b/examples/storm-jms-examples/pom.xml index 886066c..1e0511b 100644 --- a/examples/storm-jms-examples/pom.xml +++ b/examples/storm-jms-examples/pom.xml @@ -108,6 +108,10 @@ <maxAllowedViolations>78</maxAllowedViolations> </configuration> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> </project> diff --git a/examples/storm-kafka-client-examples/pom.xml b/examples/storm-kafka-client-examples/pom.xml index 4e70c63..531a082 100644 --- a/examples/storm-kafka-client-examples/pom.xml +++ b/examples/storm-kafka-client-examples/pom.xml @@ -106,6 +106,10 @@ <maxAllowedViolations>0</maxAllowedViolations> </configuration> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> diff --git a/examples/storm-loadgen/pom.xml b/examples/storm-loadgen/pom.xml index b3ba537..e634acc 100644 --- a/examples/storm-loadgen/pom.xml +++ b/examples/storm-loadgen/pom.xml @@ -127,6 +127,10 @@ <maxAllowedViolations>0</maxAllowedViolations> </configuration> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> </project> diff --git a/examples/storm-mongodb-examples/pom.xml b/examples/storm-mongodb-examples/pom.xml index 0b9081c..faecbed 100644 --- a/examples/storm-mongodb-examples/pom.xml +++ b/examples/storm-mongodb-examples/pom.xml @@ -90,6 +90,10 @@ <maxAllowedViolations>38</maxAllowedViolations> </configuration> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> </project> diff --git a/examples/storm-mqtt-examples/pom.xml b/examples/storm-mqtt-examples/pom.xml index 27237dc..3de7620 100644 --- a/examples/storm-mqtt-examples/pom.xml +++ b/examples/storm-mqtt-examples/pom.xml @@ -126,6 +126,10 @@ <maxAllowedViolations>0</maxAllowedViolations> </configuration> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> diff --git a/examples/storm-opentsdb-examples/pom.xml b/examples/storm-opentsdb-examples/pom.xml index 9a882f0..fba4737 100644 --- a/examples/storm-opentsdb-examples/pom.xml +++ b/examples/storm-opentsdb-examples/pom.xml @@ -90,6 +90,10 @@ <maxAllowedViolations>18</maxAllowedViolations> </configuration> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> </project> diff --git a/examples/storm-perf/pom.xml b/examples/storm-perf/pom.xml index 3e1d4a0..527ef49 100644 --- a/examples/storm-perf/pom.xml +++ b/examples/storm-perf/pom.xml @@ -95,6 +95,10 @@ <maxAllowedViolations>65</maxAllowedViolations> </configuration> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> diff --git a/examples/storm-pmml-examples/pom.xml b/examples/storm-pmml-examples/pom.xml index 9cdc7ef..174fef4 100644 --- a/examples/storm-pmml-examples/pom.xml +++ b/examples/storm-pmml-examples/pom.xml @@ -90,6 +90,10 @@ <maxAllowedViolations>17</maxAllowedViolations> </configuration> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> </project> diff --git a/examples/storm-redis-examples/pom.xml b/examples/storm-redis-examples/pom.xml index 824609e..1a8914f 100644 --- a/examples/storm-redis-examples/pom.xml +++ b/examples/storm-redis-examples/pom.xml @@ -94,6 +94,10 @@ <maxAllowedViolations>54</maxAllowedViolations> </configuration> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> </project> diff --git a/examples/storm-rocketmq-examples/pom.xml b/examples/storm-rocketmq-examples/pom.xml index d3f389d..de57c51 100644 --- a/examples/storm-rocketmq-examples/pom.xml +++ b/examples/storm-rocketmq-examples/pom.xml @@ -90,6 +90,10 @@ <maxAllowedViolations>23</maxAllowedViolations> </configuration> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> </project> diff --git a/examples/storm-solr-examples/pom.xml b/examples/storm-solr-examples/pom.xml index d2ae1dc..ea89a03 100644 --- a/examples/storm-solr-examples/pom.xml +++ b/examples/storm-solr-examples/pom.xml @@ -121,6 +121,10 @@ <maxAllowedViolations>47</maxAllowedViolations> </configuration> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> </project> diff --git a/examples/storm-starter/pom.xml b/examples/storm-starter/pom.xml index 4df920c..97a6610 100644 --- a/examples/storm-starter/pom.xml +++ b/examples/storm-starter/pom.xml @@ -232,6 +232,10 @@ <maxAllowedViolations>263</maxAllowedViolations> </configuration> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> </project> diff --git a/external/storm-autocreds/pom.xml b/external/storm-autocreds/pom.xml index f3946eb..a8ac75e 100644 --- a/external/storm-autocreds/pom.xml +++ b/external/storm-autocreds/pom.xml @@ -200,4 +200,20 @@ <artifactId>jaxb-api</artifactId> </dependency> </dependencies> + <build> + <plugins> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-checkstyle-plugin</artifactId> + <!--Note - the version would be inherited--> + <configuration> + <maxAllowedViolations>249</maxAllowedViolations> + </configuration> + </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> + </plugins> + </build> </project> diff --git a/external/storm-blobstore-migration/pom.xml b/external/storm-blobstore-migration/pom.xml index 3c39a92..69d4c5e 100644 --- a/external/storm-blobstore-migration/pom.xml +++ b/external/storm-blobstore-migration/pom.xml @@ -124,6 +124,18 @@ limitations under the License. </execution> </executions> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-checkstyle-plugin</artifactId> + <!--Note - the version would be inherited--> + <configuration> + <maxAllowedViolations>56</maxAllowedViolations> + </configuration> + </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> </project> diff --git a/external/storm-cassandra/pom.xml b/external/storm-cassandra/pom.xml index 1588404..f670a6e 100644 --- a/external/storm-cassandra/pom.xml +++ b/external/storm-cassandra/pom.xml @@ -135,6 +135,10 @@ <maxAllowedViolations>159</maxAllowedViolations> </configuration> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> </project> diff --git a/external/storm-elasticsearch/pom.xml b/external/storm-elasticsearch/pom.xml index eae9177..9785772 100644 --- a/external/storm-elasticsearch/pom.xml +++ b/external/storm-elasticsearch/pom.xml @@ -151,6 +151,10 @@ <maxAllowedViolations>0</maxAllowedViolations> </configuration> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> diff --git a/external/storm-eventhubs/pom.xml b/external/storm-eventhubs/pom.xml index eaaa36e..a6a1cef 100755 --- a/external/storm-eventhubs/pom.xml +++ b/external/storm-eventhubs/pom.xml @@ -56,6 +56,10 @@ <maxAllowedViolations>45</maxAllowedViolations> </configuration> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> <dependencies> diff --git a/external/storm-hbase/pom.xml b/external/storm-hbase/pom.xml index cc13c00..4a9f78f 100644 --- a/external/storm-hbase/pom.xml +++ b/external/storm-hbase/pom.xml @@ -120,6 +120,10 @@ <maxAllowedViolations>100</maxAllowedViolations> </configuration> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> </project> diff --git a/external/storm-hdfs-blobstore/pom.xml b/external/storm-hdfs-blobstore/pom.xml index f234087..a369ebe 100644 --- a/external/storm-hdfs-blobstore/pom.xml +++ b/external/storm-hdfs-blobstore/pom.xml @@ -258,6 +258,10 @@ <maxAllowedViolations>80</maxAllowedViolations> </configuration> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> </project> diff --git a/external/storm-hdfs/pom.xml b/external/storm-hdfs/pom.xml index 7b52ba1..60c74a9 100644 --- a/external/storm-hdfs/pom.xml +++ b/external/storm-hdfs/pom.xml @@ -278,6 +278,10 @@ <maxAllowedViolations>189</maxAllowedViolations> </configuration> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> </project> diff --git a/external/storm-hive/pom.xml b/external/storm-hive/pom.xml index 60a5f40..94b73db 100644 --- a/external/storm-hive/pom.xml +++ b/external/storm-hive/pom.xml @@ -249,6 +249,10 @@ <maxAllowedViolations>58</maxAllowedViolations> </configuration> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> diff --git a/external/storm-jdbc/pom.xml b/external/storm-jdbc/pom.xml index e950c057..f868739 100644 --- a/external/storm-jdbc/pom.xml +++ b/external/storm-jdbc/pom.xml @@ -93,6 +93,10 @@ <maxAllowedViolations>36</maxAllowedViolations> </configuration> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> </project> diff --git a/external/storm-jms/pom.xml b/external/storm-jms/pom.xml index 7d4d2ba..984d8cf 100644 --- a/external/storm-jms/pom.xml +++ b/external/storm-jms/pom.xml @@ -84,6 +84,10 @@ <maxAllowedViolations>63</maxAllowedViolations> </configuration> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> </project> diff --git a/external/storm-kafka-client/pom.xml b/external/storm-kafka-client/pom.xml index 216b629..f5d024d 100644 --- a/external/storm-kafka-client/pom.xml +++ b/external/storm-kafka-client/pom.xml @@ -179,6 +179,10 @@ <maxAllowedViolations>0</maxAllowedViolations> </configuration> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> </project> diff --git a/external/storm-kafka-migration/pom.xml b/external/storm-kafka-migration/pom.xml index 3463708..71b7e0b 100644 --- a/external/storm-kafka-migration/pom.xml +++ b/external/storm-kafka-migration/pom.xml @@ -87,6 +87,10 @@ </plugin> <plugin> <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-shade-plugin</artifactId> <configuration> <createDependencyReducedPom>true</createDependencyReducedPom> diff --git a/external/storm-kafka-monitor/pom.xml b/external/storm-kafka-monitor/pom.xml index 2c8f6da..99d2e62 100644 --- a/external/storm-kafka-monitor/pom.xml +++ b/external/storm-kafka-monitor/pom.xml @@ -78,6 +78,10 @@ <maxAllowedViolations>87</maxAllowedViolations> </configuration> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> </project> diff --git a/external/storm-kinesis/pom.xml b/external/storm-kinesis/pom.xml index b513090..6f04950 100644 --- a/external/storm-kinesis/pom.xml +++ b/external/storm-kinesis/pom.xml @@ -65,6 +65,10 @@ <maxAllowedViolations>185</maxAllowedViolations> </configuration> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> diff --git a/external/storm-metrics/pom.xml b/external/storm-metrics/pom.xml index 9aafade..bc7c4d0 100644 --- a/external/storm-metrics/pom.xml +++ b/external/storm-metrics/pom.xml @@ -105,6 +105,10 @@ <maxAllowedViolations>32</maxAllowedViolations> </configuration> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> </project> diff --git a/external/storm-mongodb/pom.xml b/external/storm-mongodb/pom.xml index a4e5ecc..e8ef9c7 100644 --- a/external/storm-mongodb/pom.xml +++ b/external/storm-mongodb/pom.xml @@ -73,6 +73,10 @@ <artifactId>maven-checkstyle-plugin</artifactId> <!--Note - the version would be inherited--> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> </project> diff --git a/external/storm-mqtt/pom.xml b/external/storm-mqtt/pom.xml index 1ff7832..35a237a 100644 --- a/external/storm-mqtt/pom.xml +++ b/external/storm-mqtt/pom.xml @@ -141,6 +141,10 @@ <maxAllowedViolations>39</maxAllowedViolations> </configuration> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> diff --git a/external/storm-opentsdb/pom.xml b/external/storm-opentsdb/pom.xml index 7ec697d..c2b311c 100644 --- a/external/storm-opentsdb/pom.xml +++ b/external/storm-opentsdb/pom.xml @@ -109,6 +109,10 @@ <maxAllowedViolations>99</maxAllowedViolations> </configuration> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> </project> diff --git a/external/storm-pmml/pom.xml b/external/storm-pmml/pom.xml index 4d1e091..1c9278b 100644 --- a/external/storm-pmml/pom.xml +++ b/external/storm-pmml/pom.xml @@ -97,6 +97,10 @@ <maxAllowedViolations>67</maxAllowedViolations> </configuration> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> diff --git a/external/storm-redis/pom.xml b/external/storm-redis/pom.xml index c8f27a7..5c90279 100644 --- a/external/storm-redis/pom.xml +++ b/external/storm-redis/pom.xml @@ -89,6 +89,10 @@ <maxAllowedViolations>64</maxAllowedViolations> </configuration> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> </project> diff --git a/external/storm-rocketmq/pom.xml b/external/storm-rocketmq/pom.xml index 7507827..c981c7a 100644 --- a/external/storm-rocketmq/pom.xml +++ b/external/storm-rocketmq/pom.xml @@ -80,6 +80,10 @@ <artifactId>maven-checkstyle-plugin</artifactId> <!--Note - the version would be inherited--> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> diff --git a/external/storm-solr/pom.xml b/external/storm-solr/pom.xml index 01a79bd..14af06e 100644 --- a/external/storm-solr/pom.xml +++ b/external/storm-solr/pom.xml @@ -127,6 +127,10 @@ <maxAllowedViolations>47</maxAllowedViolations> </configuration> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> </project> diff --git a/flux/flux-core/pom.xml b/flux/flux-core/pom.xml index 43ad9ec..33b61c8 100644 --- a/flux/flux-core/pom.xml +++ b/flux/flux-core/pom.xml @@ -120,6 +120,10 @@ <maxAllowedViolations>0</maxAllowedViolations> </configuration> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> </project> diff --git a/flux/flux-examples/pom.xml b/flux/flux-examples/pom.xml index 217bef5..2b7741a 100644 --- a/flux/flux-examples/pom.xml +++ b/flux/flux-examples/pom.xml @@ -153,6 +153,10 @@ <maxAllowedViolations>0</maxAllowedViolations> </configuration> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> </project> diff --git a/flux/flux-wrappers/pom.xml b/flux/flux-wrappers/pom.xml index 3978a8e..6eb587b 100644 --- a/flux/flux-wrappers/pom.xml +++ b/flux/flux-wrappers/pom.xml @@ -58,6 +58,10 @@ <maxAllowedViolations>38</maxAllowedViolations> </configuration> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> diff --git a/flux/pom.xml b/flux/pom.xml index 3124e2a..99f1ce1 100644 --- a/flux/pom.xml +++ b/flux/pom.xml @@ -57,4 +57,17 @@ <version>1.2</version> </dependency> </dependencies> + + <build> + <plugins> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-checkstyle-plugin</artifactId> + </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> + </plugins> + </build> </project> diff --git a/integration-test/pom.xml b/integration-test/pom.xml index 6d6de9d..65f0453 100755 --- a/integration-test/pom.xml +++ b/integration-test/pom.xml @@ -170,6 +170,18 @@ </execution> </executions> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-checkstyle-plugin</artifactId> + <!--Note - the version would be inherited--> + <configuration> + <maxAllowedViolations>129</maxAllowedViolations> + </configuration> + </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> <resources> <resource> diff --git a/pom.xml b/pom.xml index 0330bc0..91a3293d 100644 --- a/pom.xml +++ b/pom.xml @@ -1251,6 +1251,11 @@ </executions> </plugin> <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + <version>3.12.0</version> + </plugin> + <plugin> <artifactId>maven-clean-plugin</artifactId> <version>2.5</version> <executions> @@ -1472,23 +1477,6 @@ <plugins> <plugin> <groupId>org.apache.maven.plugins</groupId> - <artifactId>maven-checkstyle-plugin</artifactId> - <version>2.17</version> - <reportSets> - <reportSet> - <reports> - <report>checkstyle</report> - </reports> - </reportSet> - </reportSets> - </plugin> - <plugin> - <groupId>org.apache.maven.plugins</groupId> - <artifactId>maven-pmd-plugin</artifactId> - <version>3.0.1</version> - </plugin> - <plugin> - <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-javadoc-plugin</artifactId> <version>2.10.4</version> </plugin> diff --git a/sql/pom.xml b/sql/pom.xml index 8a2aaa2..a3f6178 100644 --- a/sql/pom.xml +++ b/sql/pom.xml @@ -44,4 +44,17 @@ <module>storm-sql-external/storm-sql-mongodb</module> <module>storm-sql-external/storm-sql-hdfs</module> </modules> + + <build> + <plugins> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-checkstyle-plugin</artifactId> + </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> + </plugins> + </build> </project> diff --git a/sql/storm-sql-core/pom.xml b/sql/storm-sql-core/pom.xml index 4c01703..b2b3777 100644 --- a/sql/storm-sql-core/pom.xml +++ b/sql/storm-sql-core/pom.xml @@ -211,6 +211,10 @@ </configuration> </plugin> <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> + <plugin> <!-- Extract parser grammar template from calcite-core.jar and put it under ${project.build.directory} where all freemarker templates are. --> <groupId>org.apache.maven.plugins</groupId> diff --git a/sql/storm-sql-external/storm-sql-hdfs/pom.xml b/sql/storm-sql-external/storm-sql-hdfs/pom.xml index 9233e43..83d45af 100644 --- a/sql/storm-sql-external/storm-sql-hdfs/pom.xml +++ b/sql/storm-sql-external/storm-sql-hdfs/pom.xml @@ -114,6 +114,10 @@ <artifactId>maven-checkstyle-plugin</artifactId> <!--Note - the version would be inherited--> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> </project> diff --git a/sql/storm-sql-external/storm-sql-kafka/pom.xml b/sql/storm-sql-external/storm-sql-kafka/pom.xml index 29d7b07..10244d7 100644 --- a/sql/storm-sql-external/storm-sql-kafka/pom.xml +++ b/sql/storm-sql-external/storm-sql-kafka/pom.xml @@ -98,6 +98,10 @@ <artifactId>maven-checkstyle-plugin</artifactId> <!--Note - the version would be inherited--> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> </project> diff --git a/sql/storm-sql-external/storm-sql-mongodb/pom.xml b/sql/storm-sql-external/storm-sql-mongodb/pom.xml index b0c1df5..69e5196 100644 --- a/sql/storm-sql-external/storm-sql-mongodb/pom.xml +++ b/sql/storm-sql-external/storm-sql-mongodb/pom.xml @@ -84,6 +84,10 @@ <artifactId>maven-checkstyle-plugin</artifactId> <!--Note - the version would be inherited--> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> </project> diff --git a/sql/storm-sql-external/storm-sql-redis/pom.xml b/sql/storm-sql-external/storm-sql-redis/pom.xml index 9335cf4..fd051cb 100644 --- a/sql/storm-sql-external/storm-sql-redis/pom.xml +++ b/sql/storm-sql-external/storm-sql-redis/pom.xml @@ -76,6 +76,10 @@ <artifactId>maven-checkstyle-plugin</artifactId> <!--Note - the version would be inherited--> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> </project> diff --git a/sql/storm-sql-runtime/pom.xml b/sql/storm-sql-runtime/pom.xml index f1cd87c..5d709ba 100644 --- a/sql/storm-sql-runtime/pom.xml +++ b/sql/storm-sql-runtime/pom.xml @@ -151,6 +151,10 @@ <artifactId>maven-checkstyle-plugin</artifactId> <!--Note - the version would be inherited--> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> </project> diff --git a/storm-buildtools/maven-shade-clojure-transformer/pom.xml b/storm-buildtools/maven-shade-clojure-transformer/pom.xml index b3fc7da..650ad8f 100644 --- a/storm-buildtools/maven-shade-clojure-transformer/pom.xml +++ b/storm-buildtools/maven-shade-clojure-transformer/pom.xml @@ -45,6 +45,10 @@ <maxAllowedViolations>0</maxAllowedViolations> </configuration> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> </project> diff --git a/storm-buildtools/storm-maven-plugins/pom.xml b/storm-buildtools/storm-maven-plugins/pom.xml index 3619c35..c5b1b59 100644 --- a/storm-buildtools/storm-maven-plugins/pom.xml +++ b/storm-buildtools/storm-maven-plugins/pom.xml @@ -78,6 +78,10 @@ <maxAllowedViolations>11</maxAllowedViolations> </configuration> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> </project> diff --git a/storm-client/pom.xml b/storm-client/pom.xml index 30468dd..546ec32 100644 --- a/storm-client/pom.xml +++ b/storm-client/pom.xml @@ -240,6 +240,14 @@ </execution> </executions> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-checkstyle-plugin</artifactId> + </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> <profiles> diff --git a/storm-clojure-test/pom.xml b/storm-clojure-test/pom.xml index b0fddd6..c58ceec 100644 --- a/storm-clojure-test/pom.xml +++ b/storm-clojure-test/pom.xml @@ -59,6 +59,14 @@ </execution> </executions> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-checkstyle-plugin</artifactId> + </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> </project> diff --git a/storm-clojure/pom.xml b/storm-clojure/pom.xml index 85e5aba..f886767 100644 --- a/storm-clojure/pom.xml +++ b/storm-clojure/pom.xml @@ -113,6 +113,10 @@ <maxAllowedViolations>173</maxAllowedViolations> </configuration> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> </project> diff --git a/storm-core/pom.xml b/storm-core/pom.xml index 61ad7c1..2bebab4 100644 --- a/storm-core/pom.xml +++ b/storm-core/pom.xml @@ -308,6 +308,10 @@ </plugin> <plugin> <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-surefire-report-plugin</artifactId> <configuration> <reportsDirectories> diff --git a/storm-multilang/javascript/pom.xml b/storm-multilang/javascript/pom.xml index 196ba01..005b04a 100644 --- a/storm-multilang/javascript/pom.xml +++ b/storm-multilang/javascript/pom.xml @@ -28,4 +28,17 @@ <artifactId>multilang-javascript</artifactId> <packaging>jar</packaging> <name>multilang-javascript</name> + + <build> + <plugins> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-checkstyle-plugin</artifactId> + </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> + </plugins> + </build> </project> diff --git a/storm-multilang/python/pom.xml b/storm-multilang/python/pom.xml index 56173f8..99f5b65 100644 --- a/storm-multilang/python/pom.xml +++ b/storm-multilang/python/pom.xml @@ -28,4 +28,17 @@ <artifactId>multilang-python</artifactId> <packaging>jar</packaging> <name>multilang-python</name> + + <build> + <plugins> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-checkstyle-plugin</artifactId> + </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> + </plugins> + </build> </project> diff --git a/storm-multilang/ruby/pom.xml b/storm-multilang/ruby/pom.xml index 325999b..c2589b6 100644 --- a/storm-multilang/ruby/pom.xml +++ b/storm-multilang/ruby/pom.xml @@ -28,4 +28,17 @@ <artifactId>multilang-ruby</artifactId> <packaging>jar</packaging> <name>multilang-ruby</name> + + <build> + <plugins> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-checkstyle-plugin</artifactId> + </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> + </plugins> + </build> </project> diff --git a/storm-server/pom.xml b/storm-server/pom.xml index 6688cd0..2a93616 100644 --- a/storm-server/pom.xml +++ b/storm-server/pom.xml @@ -186,6 +186,10 @@ </plugin> <plugin> <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-source-plugin</artifactId> <executions> <execution> diff --git a/storm-shaded-deps/pom.xml b/storm-shaded-deps/pom.xml index 48ffdf7..16c4e37 100644 --- a/storm-shaded-deps/pom.xml +++ b/storm-shaded-deps/pom.xml @@ -289,6 +289,14 @@ </filters> </configuration> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-checkstyle-plugin</artifactId> + </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> </project> diff --git a/storm-submit-tools/pom.xml b/storm-submit-tools/pom.xml index c19b4e2..2036d81 100644 --- a/storm-submit-tools/pom.xml +++ b/storm-submit-tools/pom.xml @@ -118,6 +118,10 @@ <maxAllowedViolations>38</maxAllowedViolations> </configuration> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> </plugins> </build> diff --git a/storm-webapp/pom.xml b/storm-webapp/pom.xml index 7ac824a..b0ada88 100644 --- a/storm-webapp/pom.xml +++ b/storm-webapp/pom.xml @@ -313,6 +313,10 @@ </configuration> </plugin> <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + </plugin> + <plugin> <artifactId>maven-dependency-plugin</artifactId> <executions> <execution>