This is an automated email from the ASF dual-hosted git repository. srdo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/storm.git
The following commit(s) were added to refs/heads/master by this push: new 052e082 STORM-3431: rocketmq-examples: fix all checkstyle warnings new ead0bdd Merge pull request #3047 from krichter722/checkstyle-rocketmq-examples 052e082 is described below commit 052e082376a4640987993148d000e6b12922550d Author: Karl-Philipp Richter <krich...@posteo.de> AuthorDate: Thu Jun 27 23:22:20 2019 +0200 STORM-3431: rocketmq-examples: fix all checkstyle warnings --- examples/storm-rocketmq-examples/pom.xml | 2 +- .../java/org/apache/storm/rocketmq/topology/WordCountTopology.java | 5 ++--- .../java/org/apache/storm/rocketmq/trident/WordCountTrident.java | 2 +- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/examples/storm-rocketmq-examples/pom.xml b/examples/storm-rocketmq-examples/pom.xml index de57c51..31774a4 100644 --- a/examples/storm-rocketmq-examples/pom.xml +++ b/examples/storm-rocketmq-examples/pom.xml @@ -87,7 +87,7 @@ <artifactId>maven-checkstyle-plugin</artifactId> <!--Note - the version would be inherited--> <configuration> - <maxAllowedViolations>23</maxAllowedViolations> + <maxAllowedViolations>0</maxAllowedViolations> </configuration> </plugin> <plugin> diff --git a/examples/storm-rocketmq-examples/src/main/java/org/apache/storm/rocketmq/topology/WordCountTopology.java b/examples/storm-rocketmq-examples/src/main/java/org/apache/storm/rocketmq/topology/WordCountTopology.java index 40d3eb4..3b40b51 100644 --- a/examples/storm-rocketmq-examples/src/main/java/org/apache/storm/rocketmq/topology/WordCountTopology.java +++ b/examples/storm-rocketmq-examples/src/main/java/org/apache/storm/rocketmq/topology/WordCountTopology.java @@ -41,7 +41,7 @@ public class WordCountTopology { private static final String CONSUMER_GROUP = "wordcount"; private static final String CONSUMER_TOPIC = "source"; - public static StormTopology buildTopology(String nameserverAddr, String topic){ + public static StormTopology buildTopology(String nameserverAddr, String topic) { Properties properties = new Properties(); properties.setProperty(SpoutConfig.NAME_SERVER_ADDR, nameserverAddr); properties.setProperty(SpoutConfig.CONSUMER_GROUP, CONSUMER_GROUP); @@ -49,8 +49,6 @@ public class WordCountTopology { RocketMqSpout spout = new RocketMqSpout(properties); - WordCounter bolt = new WordCounter(); - TupleToMessageMapper mapper = new FieldNameBasedTupleToMessageMapper("word", "count"); TopicSelector selector = new DefaultTopicSelector(topic); @@ -65,6 +63,7 @@ public class WordCountTopology { // wordSpout ==> countBolt ==> insertBolt TopologyBuilder builder = new TopologyBuilder(); + WordCounter bolt = new WordCounter(); builder.setSpout(WORD_SPOUT, spout, 1); builder.setBolt(COUNT_BOLT, bolt, 1).fieldsGrouping(WORD_SPOUT, new Fields("str")); builder.setBolt(INSERT_BOLT, insertBolt, 1).shuffleGrouping(COUNT_BOLT); diff --git a/examples/storm-rocketmq-examples/src/main/java/org/apache/storm/rocketmq/trident/WordCountTrident.java b/examples/storm-rocketmq-examples/src/main/java/org/apache/storm/rocketmq/trident/WordCountTrident.java index 6b73d3f..dbdee93 100644 --- a/examples/storm-rocketmq-examples/src/main/java/org/apache/storm/rocketmq/trident/WordCountTrident.java +++ b/examples/storm-rocketmq-examples/src/main/java/org/apache/storm/rocketmq/trident/WordCountTrident.java @@ -39,7 +39,7 @@ import org.apache.storm.tuple.Values; public class WordCountTrident { - public static StormTopology buildTopology(String nameserverAddr, String topic){ + public static StormTopology buildTopology(String nameserverAddr, String topic) { Fields fields = new Fields("word", "count"); FixedBatchSpout spout = new FixedBatchSpout(fields, 4, new Values("storm", 1),