This is an automated email from the ASF dual-hosted git repository. srdo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/storm.git
The following commit(s) were added to refs/heads/master by this push: new 905007f STORM-3441: hbase: fix all checkstyle warnings new 1389492 Merge pull request #3057 from krichter722/checkstyle-hbase 905007f is described below commit 905007fb1db4f18158c85b3f92211be7ab73138b Author: Karl-Philipp Richter <krich...@posteo.de> AuthorDate: Thu Jun 27 22:43:40 2019 +0200 STORM-3441: hbase: fix all checkstyle warnings --- external/storm-hbase/pom.xml | 2 +- .../apache/storm/hbase/bolt/AbstractHBaseBolt.java | 1 + .../org/apache/storm/hbase/bolt/HBaseBolt.java | 5 +- .../apache/storm/hbase/bolt/HBaseLookupBolt.java | 6 +-- .../storm/hbase/bolt/mapper/HBaseMapper.java | 8 +--- .../hbase/bolt/mapper/HBaseProjectionCriteria.java | 9 ---- .../storm/hbase/bolt/mapper/HBaseValueMapper.java | 12 ++--- .../storm/hbase/bolt/mapper/SimpleHBaseMapper.java | 10 ++-- .../org/apache/storm/hbase/common/ColumnList.java | 55 ++++------------------ .../java/org/apache/storm/hbase/common/Utils.java | 4 +- .../hbase/state/HBaseKeyValueStateIterator.java | 4 +- .../hbase/state/HBaseKeyValueStateProvider.java | 18 +++---- .../trident/mapper/SimpleTridentHBaseMapper.java | 9 ++-- .../trident/mapper/TridentHBaseMapMapper.java | 6 --- .../hbase/trident/mapper/TridentHBaseMapper.java | 7 --- .../storm/hbase/trident/state/HBaseQuery.java | 1 + .../storm/hbase/trident/state/HBaseState.java | 5 +- .../hbase/trident/state/HBaseStateFactory.java | 2 +- .../storm/hbase/trident/state/HBaseUpdater.java | 1 + 19 files changed, 50 insertions(+), 115 deletions(-) diff --git a/external/storm-hbase/pom.xml b/external/storm-hbase/pom.xml index 4a9f78f..6620f6a 100644 --- a/external/storm-hbase/pom.xml +++ b/external/storm-hbase/pom.xml @@ -117,7 +117,7 @@ <artifactId>maven-checkstyle-plugin</artifactId> <!--Note - the version would be inherited--> <configuration> - <maxAllowedViolations>100</maxAllowedViolations> + <maxAllowedViolations>0</maxAllowedViolations> </configuration> </plugin> <plugin> diff --git a/external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/AbstractHBaseBolt.java b/external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/AbstractHBaseBolt.java index bb3e93c..4d0855e 100644 --- a/external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/AbstractHBaseBolt.java +++ b/external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/AbstractHBaseBolt.java @@ -33,6 +33,7 @@ public abstract class AbstractHBaseBolt extends BaseRichBolt { private static final Logger LOG = LoggerFactory.getLogger(AbstractHBaseBolt.class); protected transient OutputCollector collector; + @SuppressWarnings("checkstyle:MemberName") protected transient HBaseClient hBaseClient; protected String tableName; protected HBaseMapper mapper; diff --git a/external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/HBaseBolt.java b/external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/HBaseBolt.java index fa6acb5..16759ca 100644 --- a/external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/HBaseBolt.java +++ b/external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/HBaseBolt.java @@ -31,12 +31,14 @@ import org.slf4j.LoggerFactory; /** * Basic bolt for writing to HBase. * - * Note: Each HBaseBolt defined in a topology is tied to a specific table. + * <p>Note: Each HBaseBolt defined in a topology is tied to a specific table. */ +@SuppressWarnings("checkstyle:AbbreviationAsWordInName") public class HBaseBolt extends AbstractHBaseBolt { private static final Logger LOG = LoggerFactory.getLogger(HBaseBolt.class); private static final int DEFAULT_FLUSH_INTERVAL_SECS = 1; + @SuppressWarnings("checkstyle:AbbreviationAsWordInName") boolean writeToWAL = true; List<Mutation> batchMutations; int flushIntervalSecs = DEFAULT_FLUSH_INTERVAL_SECS; @@ -48,6 +50,7 @@ public class HBaseBolt extends AbstractHBaseBolt { this.batchMutations = new LinkedList<>(); } + @SuppressWarnings("checkstyle:AbbreviationAsWordInName") public HBaseBolt writeToWAL(boolean writeToWAL) { this.writeToWAL = writeToWAL; return this; diff --git a/external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/HBaseLookupBolt.java b/external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/HBaseLookupBolt.java index 538d896..85262ca 100644 --- a/external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/HBaseLookupBolt.java +++ b/external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/HBaseLookupBolt.java @@ -36,7 +36,7 @@ import org.slf4j.LoggerFactory; /** * Basic bolt for querying from HBase. * - * Note: Each HBaseBolt defined in a topology is tied to a specific table. + * <p>Note: Each HBaseBolt defined in a topology is tied to a specific table. */ public class HBaseLookupBolt extends AbstractHBaseBolt { private static final Logger LOG = LoggerFactory.getLogger(HBaseLookupBolt.class); @@ -66,10 +66,10 @@ public class HBaseLookupBolt extends AbstractHBaseBolt { public void prepare(Map<String, Object> config, TopologyContext topologyContext, OutputCollector collector) { super.prepare(config, topologyContext, collector); cacheEnabled = Boolean.parseBoolean(config.getOrDefault("hbase.cache.enable", "false").toString()); - int cacheTTL = Integer.parseInt(config.getOrDefault("hbase.cache.ttl.seconds", "300").toString()); + int cacheTtl = Integer.parseInt(config.getOrDefault("hbase.cache.ttl.seconds", "300").toString()); int maxCacheSize = Integer.parseInt(config.getOrDefault("hbase.cache.size", "1000").toString()); if (cacheEnabled) { - cache = Caffeine.newBuilder().maximumSize(maxCacheSize).expireAfterWrite(cacheTTL, TimeUnit.SECONDS) + cache = Caffeine.newBuilder().maximumSize(maxCacheSize).expireAfterWrite(cacheTtl, TimeUnit.SECONDS) .build(new CacheLoader<byte[], Result>() { @Override diff --git a/external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/mapper/HBaseMapper.java b/external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/mapper/HBaseMapper.java index bf3eca6..2785093 100644 --- a/external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/mapper/HBaseMapper.java +++ b/external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/mapper/HBaseMapper.java @@ -12,8 +12,8 @@ package org.apache.storm.hbase.bolt.mapper; - import java.io.Serializable; + import org.apache.storm.hbase.common.ColumnList; import org.apache.storm.tuple.Tuple; @@ -24,17 +24,11 @@ public interface HBaseMapper extends Serializable { /** * Given a tuple, return the HBase rowkey. - * - * @param tuple - * @return */ byte[] rowKey(Tuple tuple); /** * Given a tuple, return a list of HBase columns to insert. - * - * @param tuple - * @return */ ColumnList columns(Tuple tuple); diff --git a/external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/mapper/HBaseProjectionCriteria.java b/external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/mapper/HBaseProjectionCriteria.java index 18322c6..c9ab6d8 100644 --- a/external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/mapper/HBaseProjectionCriteria.java +++ b/external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/mapper/HBaseProjectionCriteria.java @@ -32,9 +32,6 @@ public class HBaseProjectionCriteria implements Serializable { /** * all columns from this family will be included as result of HBase lookup. - * - * @param columnFamily - * @return */ public HBaseProjectionCriteria addColumnFamily(String columnFamily) { this.columnFamilies.add(columnFamily.getBytes()); @@ -43,9 +40,6 @@ public class HBaseProjectionCriteria implements Serializable { /** * all columns from this family will be included as result of HBase lookup. - * - * @param columnFamily - * @return */ public HBaseProjectionCriteria addColumnFamily(byte[] columnFamily) { this.columnFamilies.add(Arrays.copyOf(columnFamily, columnFamily.length)); @@ -54,9 +48,6 @@ public class HBaseProjectionCriteria implements Serializable { /** * Only this column from the the columnFamily will be included as result of HBase lookup. - * - * @param column - * @return */ public HBaseProjectionCriteria addColumn(ColumnMetaData column) { this.columns.add(column); diff --git a/external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/mapper/HBaseValueMapper.java b/external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/mapper/HBaseValueMapper.java index 004cf03..d26b125 100644 --- a/external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/mapper/HBaseValueMapper.java +++ b/external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/mapper/HBaseValueMapper.java @@ -20,19 +20,17 @@ import org.apache.storm.tuple.ITuple; import org.apache.storm.tuple.Values; public interface HBaseValueMapper extends Serializable { + /** - * @param input tuple. - * @param result HBase lookup result instance. - * @return list of values that should be emitted by the lookup bolt. - * - * @throws Exception + * Map to values. + * @param input tuple + * @param result HBase lookup result instance + * @return list of values that should be emitted by the lookup bolt */ public List<Values> toValues(ITuple input, Result result) throws Exception; /** * declares the output fields for the lookup bolt. - * - * @param declarer */ void declareOutputFields(OutputFieldsDeclarer declarer); } diff --git a/external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/mapper/SimpleHBaseMapper.java b/external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/mapper/SimpleHBaseMapper.java index f37995c..152a1b6 100644 --- a/external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/mapper/SimpleHBaseMapper.java +++ b/external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/mapper/SimpleHBaseMapper.java @@ -12,18 +12,16 @@ package org.apache.storm.hbase.bolt.mapper; +import static org.apache.storm.hbase.common.Utils.toBytes; +import static org.apache.storm.hbase.common.Utils.toLong; + import org.apache.storm.hbase.common.ColumnList; import org.apache.storm.tuple.Fields; import org.apache.storm.tuple.Tuple; + import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import static org.apache.storm.hbase.common.Utils.toBytes; -import static org.apache.storm.hbase.common.Utils.toLong; - -/** - * - */ public class SimpleHBaseMapper implements HBaseMapper { private static final Logger LOG = LoggerFactory.getLogger(SimpleHBaseMapper.class); diff --git a/external/storm-hbase/src/main/java/org/apache/storm/hbase/common/ColumnList.java b/external/storm-hbase/src/main/java/org/apache/storm/hbase/common/ColumnList.java index 045b2e5..8971469 100644 --- a/external/storm-hbase/src/main/java/org/apache/storm/hbase/common/ColumnList.java +++ b/external/storm-hbase/src/main/java/org/apache/storm/hbase/common/ColumnList.java @@ -18,15 +18,15 @@ import java.util.List; /** * Represents a list of HBase columns. * - * There are two types of columns, <i>standard</i> and <i>counter</i>. + * <p>There are two types of columns, <i>standard</i> and <i>counter</i>. * - * Standard columns have <i>column family</i> (required), <i>qualifier</i> (optional), + * <p>Standard columns have <i>column family</i> (required), <i>qualifier</i> (optional), * <i>timestamp</i> (optional), and a <i>value</i> (optional) values. * - * Counter columns have <i>column family</i> (required), <i>qualifier</i> (optional), and an <i>increment</i> (optional, but recommended) + * <p>Counter columns have <i>column family</i> (required), <i>qualifier</i> (optional), and an <i>increment</i> (optional, but recommended) * values. * - * Inserts/Updates can be added via the <code>addColumn()</code> and <code>addCounter()</code> methods. + * <p>Inserts/Updates can be added via the <code>addColumn()</code> and <code>addCounter()</code> methods. */ public class ColumnList { @@ -57,12 +57,6 @@ public class ColumnList { /** * Add a standard HBase column. - * - * @param family - * @param qualifier - * @param ts - * @param value - * @return */ public ColumnList addColumn(byte[] family, byte[] qualifier, long ts, byte[] value) { columns().add(new Column(family, qualifier, ts, value)); @@ -70,12 +64,7 @@ public class ColumnList { } /** - * Add a standard HBase column - * - * @param family - * @param qualifier - * @param value - * @return + * Add a standard HBase column. */ public ColumnList addColumn(byte[] family, byte[] qualifier, byte[] value) { columns().add(new Column(family, qualifier, -1, value)); @@ -84,9 +73,6 @@ public class ColumnList { /** * Add a standard HBase column given an instance of a class that implements the <code>IColumn</code> interface. - * - * @param column - * @return */ public ColumnList addColumn(IColumn column) { return this.addColumn(column.family(), column.qualifier(), column.timestamp(), column.value()); @@ -94,11 +80,6 @@ public class ColumnList { /** * Add an HBase counter column. - * - * @param family - * @param qualifier - * @param incr - * @return */ public ColumnList addCounter(byte[] family, byte[] qualifier, long incr) { counters().add(new Counter(family, qualifier, incr)); @@ -108,20 +89,13 @@ public class ColumnList { /** * Add an HBase counter column given an instance of a class that implements the * <code>ICounter</code> interface. - * - * @param counter - * @return */ public ColumnList addCounter(ICounter counter) { return this.addCounter(counter.family(), counter.qualifier(), counter.increment()); } /** - * Remove a standard HBase column - * - * @param family - * @param qualifier - * @return + * Remove a standard HBase column. */ public ColumnList deleteColumn(byte[] family, byte[] qualifier) { columnsToDelete().add(new Column(family, qualifier, -1, null)); @@ -130,8 +104,6 @@ public class ColumnList { /** * Query to determine if we have column definitions. - * - * @return */ public boolean hasColumns() { return this.columns != null; @@ -139,8 +111,6 @@ public class ColumnList { /** * Query to determine if we have column delete definitions. - * - * @return */ public boolean hasColumnsToDelete() { return this.columnsToDelete != null; @@ -148,8 +118,6 @@ public class ColumnList { /** * Query to determine if we have counter definitions. - * - * @return */ public boolean hasCounters() { return this.counters != null; @@ -157,8 +125,6 @@ public class ColumnList { /** * Get the list of column definitions. - * - * @return */ public List<Column> getColumns() { return this.columns; @@ -166,8 +132,6 @@ public class ColumnList { /** * Get the list of 'column to delete' definitions. - * - * @return */ public ArrayList<Column> getColumnsToDelete() { return this.columnsToDelete; @@ -175,15 +139,14 @@ public class ColumnList { /** * Get the list of counter definitions. - * - * @return */ public List<Counter> getCounters() { return this.counters; } - public static abstract class AbstractColumn { - byte[] family, qualifier; + public abstract static class AbstractColumn { + byte[] family; + byte[] qualifier; AbstractColumn(byte[] family, byte[] qualifier) { this.family = family; diff --git a/external/storm-hbase/src/main/java/org/apache/storm/hbase/common/Utils.java b/external/storm-hbase/src/main/java/org/apache/storm/hbase/common/Utils.java index defa092..bba2798 100644 --- a/external/storm-hbase/src/main/java/org/apache/storm/hbase/common/Utils.java +++ b/external/storm-hbase/src/main/java/org/apache/storm/hbase/common/Utils.java @@ -64,8 +64,8 @@ public class Utils { foundHBaseAuthToken = true; } else { - LOG.warn("Found multiple HBASE_AUTH_TOKEN - will use already found token. " + - "Please enable DEBUG log level to track delegation tokens."); + LOG.warn("Found multiple HBASE_AUTH_TOKEN - will use already found token. " + + "Please enable DEBUG log level to track delegation tokens."); } } } diff --git a/external/storm-hbase/src/main/java/org/apache/storm/hbase/state/HBaseKeyValueStateIterator.java b/external/storm-hbase/src/main/java/org/apache/storm/hbase/state/HBaseKeyValueStateIterator.java index dbbd6d0..13e9b99 100644 --- a/external/storm-hbase/src/main/java/org/apache/storm/hbase/state/HBaseKeyValueStateIterator.java +++ b/external/storm-hbase/src/main/java/org/apache/storm/hbase/state/HBaseKeyValueStateIterator.java @@ -12,6 +12,8 @@ package org.apache.storm.hbase.state; +import static org.apache.storm.hbase.state.HBaseKeyValueState.STATE_QUALIFIER; + import com.google.common.primitives.UnsignedBytes; import java.util.Arrays; import java.util.Iterator; @@ -25,8 +27,6 @@ import org.apache.storm.state.DefaultStateEncoder; import org.apache.storm.state.Serializer; import org.apache.storm.state.StateEncoder; -import static org.apache.storm.hbase.state.HBaseKeyValueState.STATE_QUALIFIER; - /** * An iterator over {@link HBaseKeyValueState}. */ diff --git a/external/storm-hbase/src/main/java/org/apache/storm/hbase/state/HBaseKeyValueStateProvider.java b/external/storm-hbase/src/main/java/org/apache/storm/hbase/state/HBaseKeyValueStateProvider.java index 491bdb4..3819bf0 100644 --- a/external/storm-hbase/src/main/java/org/apache/storm/hbase/state/HBaseKeyValueStateProvider.java +++ b/external/storm-hbase/src/main/java/org/apache/storm/hbase/state/HBaseKeyValueStateProvider.java @@ -151,15 +151,15 @@ public class HBaseKeyValueStateProvider implements StateProvider { @Override public String toString() { - return "StateConfig{" + - "keyClass='" + keyClass + '\'' + - ", valueClass='" + valueClass + '\'' + - ", keySerializerClass='" + keySerializerClass + '\'' + - ", valueSerializerClass='" + valueSerializerClass + '\'' + - ", hbaseConfigKey='" + hbaseConfigKey + '\'' + - ", tableName='" + tableName + '\'' + - ", columnFamily='" + columnFamily + '\'' + - '}'; + return "StateConfig{" + + "keyClass='" + keyClass + '\'' + + ", valueClass='" + valueClass + '\'' + + ", keySerializerClass='" + keySerializerClass + '\'' + + ", valueSerializerClass='" + valueSerializerClass + '\'' + + ", hbaseConfigKey='" + hbaseConfigKey + '\'' + + ", tableName='" + tableName + '\'' + + ", columnFamily='" + columnFamily + '\'' + + '}'; } } } diff --git a/external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/mapper/SimpleTridentHBaseMapper.java b/external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/mapper/SimpleTridentHBaseMapper.java index f7ec2c7..cf043af 100644 --- a/external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/mapper/SimpleTridentHBaseMapper.java +++ b/external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/mapper/SimpleTridentHBaseMapper.java @@ -12,18 +12,15 @@ package org.apache.storm.hbase.trident.mapper; +import static org.apache.storm.hbase.common.Utils.toBytes; +import static org.apache.storm.hbase.common.Utils.toLong; + import org.apache.storm.hbase.common.ColumnList; import org.apache.storm.trident.tuple.TridentTuple; import org.apache.storm.tuple.Fields; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import static org.apache.storm.hbase.common.Utils.toBytes; -import static org.apache.storm.hbase.common.Utils.toLong; - -/** - * - */ public class SimpleTridentHBaseMapper implements TridentHBaseMapper { private static final Logger LOG = LoggerFactory.getLogger(SimpleTridentHBaseMapper.class); diff --git a/external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/mapper/TridentHBaseMapMapper.java b/external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/mapper/TridentHBaseMapMapper.java index 0fb83c5..a9ea429 100644 --- a/external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/mapper/TridentHBaseMapMapper.java +++ b/external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/mapper/TridentHBaseMapMapper.java @@ -24,17 +24,11 @@ import java.util.List; public interface TridentHBaseMapMapper extends Serializable { /** * Given a tuple's grouped key list, return the HBase rowkey. - * - * @param keys - * @return */ public byte[] rowKey(List<Object> keys); /** * Given a tuple's grouped key list, return the HBase qualifier. - * - * @param keys - * @return */ public String qualifier(List<Object> keys); } diff --git a/external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/mapper/TridentHBaseMapper.java b/external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/mapper/TridentHBaseMapper.java index dfdc2b2..9639f6e 100644 --- a/external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/mapper/TridentHBaseMapper.java +++ b/external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/mapper/TridentHBaseMapper.java @@ -18,7 +18,6 @@ package org.apache.storm.hbase.trident.mapper; - import java.io.Serializable; import org.apache.storm.hbase.common.ColumnList; import org.apache.storm.trident.tuple.TridentTuple; @@ -31,17 +30,11 @@ public interface TridentHBaseMapper extends Serializable { /** * Given a tuple, return the HBase rowkey. - * - * @param tuple - * @return */ byte[] rowKey(TridentTuple tuple); /** * Given a tuple, return a list of HBase columns to insert. - * - * @param tuple - * @return */ ColumnList columns(TridentTuple tuple); } diff --git a/external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/state/HBaseQuery.java b/external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/state/HBaseQuery.java index e3c8755..4de5873 100644 --- a/external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/state/HBaseQuery.java +++ b/external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/state/HBaseQuery.java @@ -21,6 +21,7 @@ import org.apache.storm.tuple.Values; public class HBaseQuery extends BaseQueryFunction<HBaseState, List<Values>> { @Override + @SuppressWarnings("checkstyle:ParameterName") public List<List<Values>> batchRetrieve(HBaseState hBaseState, List<TridentTuple> tridentTuples) { return hBaseState.batchRetrieve(tridentTuples); } diff --git a/external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/state/HBaseState.java b/external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/state/HBaseState.java index 0f81678..3381121 100644 --- a/external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/state/HBaseState.java +++ b/external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/state/HBaseState.java @@ -43,6 +43,7 @@ public class HBaseState implements State { private static final Logger LOG = LoggerFactory.getLogger(HBaseState.class); private Options options; + @SuppressWarnings("checkstyle:MemberName") private HBaseClient hBaseClient; private Map<String, Object> map; private int numPartitions; @@ -80,12 +81,12 @@ public class HBaseState implements State { } @Override - public void beginCommit(Long aLong) { + public void beginCommit(Long someLong) { LOG.debug("beginCommit is noop."); } @Override - public void commit(Long aLong) { + public void commit(Long someLong) { LOG.debug("commit is noop."); } diff --git a/external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/state/HBaseStateFactory.java b/external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/state/HBaseStateFactory.java index 99b87b5..2c5cf94 100644 --- a/external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/state/HBaseStateFactory.java +++ b/external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/state/HBaseStateFactory.java @@ -26,7 +26,7 @@ public class HBaseStateFactory implements StateFactory { } @Override - public State makeState(Map<String, Object> map, IMetricsContext iMetricsContext, int partitionIndex, int numPartitions) { + public State makeState(Map<String, Object> map, IMetricsContext metricsContext, int partitionIndex, int numPartitions) { HBaseState state = new HBaseState(map, partitionIndex, numPartitions, options); state.prepare(); return state; diff --git a/external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/state/HBaseUpdater.java b/external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/state/HBaseUpdater.java index 6340abc..2cde3c0 100644 --- a/external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/state/HBaseUpdater.java +++ b/external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/state/HBaseUpdater.java @@ -20,6 +20,7 @@ import org.apache.storm.trident.tuple.TridentTuple; public class HBaseUpdater extends BaseStateUpdater<HBaseState> { @Override + @SuppressWarnings("checkstyle:ParameterName") public void updateState(HBaseState hBaseState, List<TridentTuple> tuples, TridentCollector collector) { hBaseState.updateState(tuples, collector); }